From: Sudeep Holla <sudeep.holla@arm.com>
To: peng.fan@nxp.com
Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, linux-imx@nxp.com,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 2/2] firmware: arm_scmi: add smc/hvc transport
Date: Wed, 4 Mar 2020 10:40:05 +0000 [thread overview]
Message-ID: <20200304103954.GA25004@bogus> (raw)
In-Reply-To: <1583201219-15839-3-git-send-email-peng.fan@nxp.com>
On Tue, Mar 03, 2020 at 10:06:59AM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Take arm,smc-id as the 1st arg, leave the other args as zero for now.
> There is no Rx, only Tx because of smc/hvc not support Rx.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
[...]
> +static int smc_send_message(struct scmi_chan_info *cinfo,
> + struct scmi_xfer *xfer)
> +{
> + struct scmi_smc *scmi_info = cinfo->transport_info;
> + struct arm_smccc_res res;
> +
> + shmem_tx_prepare(scmi_info->shmem, xfer);
How do we protect another thread/process on another CPU going and
modifying the same shmem with another request ? We may need notion
of channel with associated shmem and it is protected with some lock.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: peng.fan@nxp.com
Cc: robh+dt@kernel.org, viresh.kumar@linaro.org,
f.fainelli@gmail.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH V4 2/2] firmware: arm_scmi: add smc/hvc transport
Date: Wed, 4 Mar 2020 10:40:05 +0000 [thread overview]
Message-ID: <20200304103954.GA25004@bogus> (raw)
In-Reply-To: <1583201219-15839-3-git-send-email-peng.fan@nxp.com>
On Tue, Mar 03, 2020 at 10:06:59AM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Take arm,smc-id as the 1st arg, leave the other args as zero for now.
> There is no Rx, only Tx because of smc/hvc not support Rx.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
[...]
> +static int smc_send_message(struct scmi_chan_info *cinfo,
> + struct scmi_xfer *xfer)
> +{
> + struct scmi_smc *scmi_info = cinfo->transport_info;
> + struct arm_smccc_res res;
> +
> + shmem_tx_prepare(scmi_info->shmem, xfer);
How do we protect another thread/process on another CPU going and
modifying the same shmem with another request ? We may need notion
of channel with associated shmem and it is protected with some lock.
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-03-04 10:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 2:06 [PATCH V4 0/2] firmware: arm_scmi: add smc/hvc transports support peng.fan
2020-03-03 2:06 ` peng.fan
2020-03-03 2:06 ` [PATCH V4 1/2] dt-bindings: arm: arm,scmi: add smc/hvc transport peng.fan
2020-03-03 2:06 ` peng.fan
2020-03-04 16:31 ` Rob Herring
2020-03-04 16:31 ` Rob Herring
2020-03-03 2:06 ` [PATCH V4 2/2] firmware: arm_scmi: " peng.fan
2020-03-03 2:06 ` peng.fan
2020-03-04 10:40 ` Sudeep Holla [this message]
2020-03-04 10:40 ` Sudeep Holla
2020-03-04 12:49 ` Peng Fan
2020-03-04 12:49 ` Peng Fan
2020-03-04 14:16 ` Peng Fan
2020-03-04 14:16 ` Peng Fan
2020-03-04 17:03 ` Sudeep Holla
2020-03-04 17:03 ` Sudeep Holla
2020-03-05 11:25 ` Peng Fan
2020-03-05 11:25 ` Peng Fan
2020-03-05 16:06 ` Sudeep Holla
2020-03-05 16:06 ` Sudeep Holla
2020-03-05 17:27 ` Florian Fainelli
2020-03-05 17:27 ` Florian Fainelli
2020-03-06 8:07 ` Peng Fan
2020-03-06 8:07 ` Peng Fan
2020-03-06 14:23 ` Sudeep Holla
2020-03-06 14:23 ` Sudeep Holla
2020-03-06 18:08 ` Florian Fainelli
2020-03-06 18:08 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304103954.GA25004@bogus \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.