From: Chris Down <chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org>
To: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Cc: Vincenzo Frascino
<vincenzo.frascino-5wv7dgnIgG8@public.gmane.org>,
Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vladimir Davydov
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH] mm: Make mem_cgroup_id_get_many dependent on MMU and MEMCG_SWAP
Date: Thu, 5 Mar 2020 18:34:26 +0000 [thread overview]
Message-ID: <20200305183426.GA752201@chrisdown.name> (raw)
In-Reply-To: <20200305160929.GA1166-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Johannes Weiner writes:
>I would ack a patch that adds __maybe_unused.
>
>This is a tiny function. If we keep it around a few releases after
>removing the last user, it costs us absolutely nothing. Eventually
>somebody will notice and send a patch to remove it. No big deal.
>
>There is, however, real cost in keeping bogus warnings around and
>telling people to ignore them. It's actively lowering the
>signal-to-noise ratio and normalizing warnings to developers. That's
>the kind of thing that will actually hide problems in the kernel.
>
>We know that the function can be unused in certain scenarios. It's
>silly to let the compiler continue to warn about it. That's exactly
>what __maybe_unused is for, so let's use it here.
Yeah, this is exactly what I was trying to express in the first one[0]. The
fact that this patch came around a second time, as expected, just solidifies my
concern around the waste to human time.
I would also ack a patch that adds __maybe_unused.
0: https://lore.kernel.org/linux-mm/20191217143720.GB131030-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org/
WARNING: multiple messages have this Message-ID (diff)
From: Chris Down <chris@chrisdown.name>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
Michal Hocko <mhocko@kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: Make mem_cgroup_id_get_many dependent on MMU and MEMCG_SWAP
Date: Thu, 5 Mar 2020 18:34:26 +0000 [thread overview]
Message-ID: <20200305183426.GA752201@chrisdown.name> (raw)
In-Reply-To: <20200305160929.GA1166@cmpxchg.org>
Johannes Weiner writes:
>I would ack a patch that adds __maybe_unused.
>
>This is a tiny function. If we keep it around a few releases after
>removing the last user, it costs us absolutely nothing. Eventually
>somebody will notice and send a patch to remove it. No big deal.
>
>There is, however, real cost in keeping bogus warnings around and
>telling people to ignore them. It's actively lowering the
>signal-to-noise ratio and normalizing warnings to developers. That's
>the kind of thing that will actually hide problems in the kernel.
>
>We know that the function can be unused in certain scenarios. It's
>silly to let the compiler continue to warn about it. That's exactly
>what __maybe_unused is for, so let's use it here.
Yeah, this is exactly what I was trying to express in the first one[0]. The
fact that this patch came around a second time, as expected, just solidifies my
concern around the waste to human time.
I would also ack a patch that adds __maybe_unused.
0: https://lore.kernel.org/linux-mm/20191217143720.GB131030@chrisdown.name/
next prev parent reply other threads:[~2020-03-05 18:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 14:23 [PATCH] mm: Make mem_cgroup_id_get_many dependent on MMU and MEMCG_SWAP Vincenzo Frascino
2020-03-04 14:23 ` Vincenzo Frascino
[not found] ` <20200304142348.48167-1-vincenzo.frascino-5wv7dgnIgG8@public.gmane.org>
2020-03-04 16:53 ` Michal Hocko
2020-03-04 16:53 ` Michal Hocko
[not found] ` <20200304165336.GO16139-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-03-05 9:49 ` Vincenzo Frascino
2020-03-05 9:49 ` Vincenzo Frascino
[not found] ` <8c489836-b824-184e-7cfe-25e55ab73000-5wv7dgnIgG8@public.gmane.org>
2020-03-05 10:00 ` Michal Hocko
2020-03-05 10:00 ` Michal Hocko
2020-03-05 10:46 ` Vincenzo Frascino
[not found] ` <acf13158-40a3-4027-f36a-25d24efe3242-5wv7dgnIgG8@public.gmane.org>
2020-03-05 14:18 ` Michal Hocko
2020-03-05 14:18 ` Michal Hocko
2020-03-05 16:09 ` Johannes Weiner
2020-03-05 16:21 ` Vincenzo Frascino
[not found] ` <20200305160929.GA1166-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2020-03-05 18:34 ` Chris Down [this message]
2020-03-05 18:34 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305183426.GA752201@chrisdown.name \
--to=chris-6bi1550ioqenzz6mram98g@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vincenzo.frascino-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.