Re: [PATCH 2/2] USB: cdc-acm: fix rounding error in TIOCSSERIAL

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2809 bytes --]

Hi Anthony,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on peter.chen-usb/ci-for-usb-next balbi-usb/next v5.6-rc4 next-20200305]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Anthony-Mallet/USB-cdc-acm-fix-close_delay-and-closing_wait-units-in-TIOCSSERIAL/20200306-021541
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: openrisc-randconfig-a001-20200305 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/usb/class/cdc-acm.c: In function 'set_serial_info':
>> drivers/usb/class/cdc-acm.c:930:3: error: expected '}' before 'else'
     930 |   else {
         |   ^~~~

vim +930 drivers/usb/class/cdc-acm.c

   905	
   906	static int set_serial_info(struct tty_struct *tty, struct serial_struct *ss)
   907	{
   908		struct acm *acm = tty->driver_data;
   909		unsigned int closing_wait, close_delay;
   910		unsigned int old_closing_wait, old_close_delay;
   911		int retval = 0;
   912	
   913		close_delay = msecs_to_jiffies(ss->close_delay * 10);
   914		closing_wait = ss->closing_wait == ASYNC_CLOSING_WAIT_NONE ?
   915				ASYNC_CLOSING_WAIT_NONE :
   916				msecs_to_jiffies(ss->closing_wait * 10);
   917	
   918		/* we must redo the rounding here, so that the values match */
   919		old_close_delay	= jiffies_to_msecs(acm->port.close_delay) / 10;
   920		old_closing_wait = acm->port.closing_wait == ASYNC_CLOSING_WAIT_NONE ?
   921					ASYNC_CLOSING_WAIT_NONE :
   922					jiffies_to_msecs(acm->port.closing_wait) / 10;
   923	
   924		mutex_lock(&acm->port.mutex);
   925	
   926		if ((ss->close_delay != old_close_delay) ||
   927	            (ss->closing_wait != old_closing_wait)) {
   928			if (!capable(CAP_SYS_ADMIN)) {
   929				retval = -EPERM;
 > 930			else {
   931				acm->port.close_delay  = close_delay;
   932				acm->port.closing_wait = closing_wait;
   933			}
   934		} else
   935			retval = -EOPNOTSUPP;
   936	
   937		mutex_unlock(&acm->port.mutex);
   938		return retval;
   939	}
   940	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20636 bytes --]