All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Anson Huang" <Anson.Huang@nxp.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	amit.kucheria@verdurent.com, wim@linux-watchdog.org,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	"Oleksij Rempel" <linux@rempel-privat.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
	"Ronald Tschalär" <ronald@innovation.ch>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	linux-rtc@vger.kernel.org, "Linux PM" <linux-pm@vger.kernel.org>,
	LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
	"NXP Linux Team" <Linux-imx@nxp.com>
Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY
Date: Fri, 6 Mar 2020 22:15:38 +0100	[thread overview]
Message-ID: <20200306211538.GA8060@piout.net> (raw)
In-Reply-To: <CAKdAkRRhXE6Hviqx90_5hWmP7YQnKO2QLJgDYnzt_CPjeH7D0A@mail.gmail.com>

On 06/03/2020 12:05:42-0800, Dmitry Torokhov wrote:
> On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote:
> > > Add COMPILE_TEST support to i.MX SC keyboard driver for better compile
> > > testing coverage.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >
> > Applied, thank you.
> 
> Actually, not:
> 
> ERROR: "imx_scu_irq_register_notifier"
> [drivers/input/keyboard/imx_sc_key.ko] undefined!
> ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko] undefined!
> ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko] undefined!
> ERROR: "imx_scu_irq_unregister_notifier"
> [drivers/input/keyboard/imx_sc_key.ko] undefined!
> ERROR: "imx_scu_irq_group_enable"
> [drivers/input/keyboard/imx_sc_key.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1282: modules] Error 2
> 
> If you want to enable compile test coverage you need to provide stubs
> for the above functions.
> 

or select IMX_SCU

or leave out COMPILE_TEST from the individual drivers as having
COMPILE_TEST for IMX_SCU is enough to be able to select the drivers.

> Thanks.
> 
> -- 
> Dmitry

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Marco Felsch" <m.felsch@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	linux-rtc@vger.kernel.org, amit.kucheria@verdurent.com,
	wim@linux-watchdog.org, "Anson Huang" <Anson.Huang@nxp.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"NXP Linux Team" <Linux-imx@nxp.com>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Ronald Tschalär" <ronald@innovation.ch>,
	"Guenter Roeck" <linux@roeck-us.net>,
	LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Linux PM" <linux-pm@vger.kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"Oleksij Rempel" <linux@rempel-privat.de>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
	"Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY
Date: Fri, 6 Mar 2020 22:15:38 +0100	[thread overview]
Message-ID: <20200306211538.GA8060@piout.net> (raw)
In-Reply-To: <CAKdAkRRhXE6Hviqx90_5hWmP7YQnKO2QLJgDYnzt_CPjeH7D0A@mail.gmail.com>

On 06/03/2020 12:05:42-0800, Dmitry Torokhov wrote:
> On Fri, Mar 6, 2020 at 11:33 AM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Fri, Mar 06, 2020 at 11:42:34PM +0800, Anson Huang wrote:
> > > Add COMPILE_TEST support to i.MX SC keyboard driver for better compile
> > > testing coverage.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> >
> > Applied, thank you.
> 
> Actually, not:
> 
> ERROR: "imx_scu_irq_register_notifier"
> [drivers/input/keyboard/imx_sc_key.ko] undefined!
> ERROR: "imx_scu_get_handle" [drivers/input/keyboard/imx_sc_key.ko] undefined!
> ERROR: "imx_scu_call_rpc" [drivers/input/keyboard/imx_sc_key.ko] undefined!
> ERROR: "imx_scu_irq_unregister_notifier"
> [drivers/input/keyboard/imx_sc_key.ko] undefined!
> ERROR: "imx_scu_irq_group_enable"
> [drivers/input/keyboard/imx_sc_key.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1282: modules] Error 2
> 
> If you want to enable compile test coverage you need to provide stubs
> for the above functions.
> 

or select IMX_SCU

or leave out COMPILE_TEST from the individual drivers as having
COMPILE_TEST for IMX_SCU is enough to be able to select the drivers.

> Thanks.
> 
> -- 
> Dmitry

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-03-06 21:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 15:42 [PATCH 1/5] firmware: imx: add COMPILE_TEST support Anson Huang
2020-03-06 15:42 ` Anson Huang
2020-03-06 15:42 ` [PATCH 2/5] rtc: add COMPILE_TEST support for i.MX SC RTC Anson Huang
2020-03-06 15:42   ` Anson Huang
2020-03-06 15:42 ` [PATCH 3/5] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Anson Huang
2020-03-06 15:42   ` Anson Huang
2020-03-06 19:33   ` Dmitry Torokhov
2020-03-06 19:33     ` Dmitry Torokhov
2020-03-06 20:05     ` Dmitry Torokhov
2020-03-06 20:05       ` Dmitry Torokhov
2020-03-06 21:15       ` Alexandre Belloni [this message]
2020-03-06 21:15         ` Alexandre Belloni
2020-03-07  1:36         ` Anson Huang
2020-03-07  1:36           ` Anson Huang
2020-03-07  2:57           ` Alexandre Belloni
2020-03-07  2:57             ` Alexandre Belloni
2020-03-07  3:33             ` Anson Huang
2020-03-07  3:33               ` Anson Huang
2020-03-07  0:18       ` Anson Huang
2020-03-07  0:18         ` Anson Huang
2020-03-07  0:51         ` Dmitry Torokhov
2020-03-07  0:51           ` Dmitry Torokhov
2020-03-07  1:01           ` Anson Huang
2020-03-07  1:01             ` Anson Huang
2020-03-06 15:42 ` [PATCH 4/5] watchdog: add COMPILE_TEST support for IMX_SC_WDT Anson Huang
2020-03-06 15:42   ` Anson Huang
2020-03-06 15:42 ` [PATCH 5/5] thermal: add COMPILE_TEST support for IMX_SC_THERMAL Anson Huang
2020-03-06 15:42   ` Anson Huang
2020-03-06 16:38   ` Amit Kucheria
2020-03-06 16:38     ` Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200306211538.GA8060@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=Anson.Huang@nxp.com \
    --cc=Linux-imx@nxp.com \
    --cc=a.zummo@towertech.it \
    --cc=amit.kucheria@verdurent.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=daniel.baluta@nxp.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=enric.balletbo@collabora.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@rempel-privat.de \
    --cc=linux@roeck-us.net \
    --cc=m.felsch@pengutronix.de \
    --cc=ronald@innovation.ch \
    --cc=rui.zhang@intel.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.