From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH 1/7] xfs: remove the unused return value from xfs_log_unmount_write
Date: Mon, 9 Mar 2020 09:02:52 +0100 [thread overview]
Message-ID: <20200309080252.GA31481@lst.de> (raw)
In-Reply-To: <20200306160917.GD2773@bfoster>
On Fri, Mar 06, 2020 at 11:09:17AM -0500, Brian Foster wrote:
> On Fri, Mar 06, 2020 at 07:31:31AM -0700, Christoph Hellwig wrote:
> > Remove the ignored return value from xfs_log_unmount_write, and also
> > remove a rather pointless assert on the return value from xfs_log_force.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
>
> I guess there's going to be obvious conflicts with Dave's series and
> some of these changes. I'm just going to ignore that and you guys can
> figure it out. :)
I'm glad to rebase this on top of the parts of his series that I think
make sense. Just wanted to send this out for now to show what I have
in mind in this area.
next prev parent reply other threads:[~2020-03-09 8:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 14:31 cleanup log I/O error handling Christoph Hellwig
2020-03-06 14:31 ` [PATCH 1/7] xfs: remove the unused return value from xfs_log_unmount_write Christoph Hellwig
2020-03-06 16:09 ` Brian Foster
2020-03-09 8:02 ` Christoph Hellwig [this message]
2020-03-10 22:28 ` Dave Chinner
2020-03-10 22:45 ` Darrick J. Wong
2020-03-11 5:59 ` Christoph Hellwig
2020-03-06 14:31 ` [PATCH 2/7] xfs: remove dead code " Christoph Hellwig
2020-03-06 16:10 ` Brian Foster
2020-03-06 14:31 ` [PATCH 3/7] xfs: cleanup xfs_log_unmount_write Christoph Hellwig
2020-03-06 16:12 ` Brian Foster
2020-03-06 14:31 ` [PATCH 4/7] xfs: remove the aborted parameter to xlog_state_done_syncing Christoph Hellwig
2020-03-06 17:12 ` Brian Foster
2020-03-09 8:03 ` Christoph Hellwig
2020-03-06 14:31 ` [PATCH 5/7] xfs: factor out a xlog_state_activate_iclog helper Christoph Hellwig
2020-03-06 17:12 ` Brian Foster
2020-03-09 8:03 ` Christoph Hellwig
2020-03-06 14:31 ` [PATCH 6/7] xfs: cleanup xlog_state_clean_iclog Christoph Hellwig
2020-03-06 17:12 ` Brian Foster
2020-03-06 14:31 ` [PATCH 7/7] xfs: kill XLOG_STATE_IOERROR Christoph Hellwig
2020-03-06 17:15 ` Brian Foster
2020-03-09 8:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309080252.GA31481@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.