From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH 7/7] xfs: kill XLOG_STATE_IOERROR
Date: Mon, 9 Mar 2020 09:05:44 +0100 [thread overview]
Message-ID: <20200309080544.GD31481@lst.de> (raw)
In-Reply-To: <20200306171545.GJ2773@bfoster>
On Fri, Mar 06, 2020 at 12:15:45PM -0500, Brian Foster wrote:
> If we were to first significantly reduce the number of error state
> checks required throughout this code (i.e. reduced to the minimum
> critical points necessary that ensure we don't do more log I/O or other
> "bad things"), _then_ I see the value of a patch to kill off the error
> state. Until we get to that point, this kind of strikes me as
> rejiggering complexity around. For example, things like how
> xlog_state_do_callback() passes ioerror to
> xlog_state_iodone_process_iclog(), which assigns it based on shutdown
> state, only for the caller to also check the shutdown state again are
> indication that more cleanup is in order before killing off the state.
I've added a few more patches fixing up some low hanging fruit and
completely redoing the code structure around
xlog_state_iodone_process_iclog. Although that means the series keeps
growing, so I might split it into multiple series with some easier
prep patches and then the bigger changes in a second round.
prev parent reply other threads:[~2020-03-09 8:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 14:31 cleanup log I/O error handling Christoph Hellwig
2020-03-06 14:31 ` [PATCH 1/7] xfs: remove the unused return value from xfs_log_unmount_write Christoph Hellwig
2020-03-06 16:09 ` Brian Foster
2020-03-09 8:02 ` Christoph Hellwig
2020-03-10 22:28 ` Dave Chinner
2020-03-10 22:45 ` Darrick J. Wong
2020-03-11 5:59 ` Christoph Hellwig
2020-03-06 14:31 ` [PATCH 2/7] xfs: remove dead code " Christoph Hellwig
2020-03-06 16:10 ` Brian Foster
2020-03-06 14:31 ` [PATCH 3/7] xfs: cleanup xfs_log_unmount_write Christoph Hellwig
2020-03-06 16:12 ` Brian Foster
2020-03-06 14:31 ` [PATCH 4/7] xfs: remove the aborted parameter to xlog_state_done_syncing Christoph Hellwig
2020-03-06 17:12 ` Brian Foster
2020-03-09 8:03 ` Christoph Hellwig
2020-03-06 14:31 ` [PATCH 5/7] xfs: factor out a xlog_state_activate_iclog helper Christoph Hellwig
2020-03-06 17:12 ` Brian Foster
2020-03-09 8:03 ` Christoph Hellwig
2020-03-06 14:31 ` [PATCH 6/7] xfs: cleanup xlog_state_clean_iclog Christoph Hellwig
2020-03-06 17:12 ` Brian Foster
2020-03-06 14:31 ` [PATCH 7/7] xfs: kill XLOG_STATE_IOERROR Christoph Hellwig
2020-03-06 17:15 ` Brian Foster
2020-03-09 8:05 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200309080544.GD31481@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.