All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis
Date: Mon, 9 Mar 2020 13:58:52 +0100	[thread overview]
Message-ID: <20200309135852.3134f4b8@elisabeth> (raw)
In-Reply-To: <CAJyzNhmr11fNVVdKTUQeTGJE+a81mr4kJN_exk=Hn3Z2tVGDBg@mail.gmail.com>

On Mon, 9 Mar 2020 17:23:42 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:

> On Mon, Mar 9, 2020, 5:11 PM Stefano Brivio <sbrivio@redhat.com> wrote:
> 
> > On Mon,  9 Mar 2020 00:25:18 +0530
> > Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> >  
> > > Align code to open parenthesis.
> > >
> > > Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> > > ---
> > >  drivers/staging/wfx/data_tx.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/staging/wfx/data_tx.c  
> > b/drivers/staging/wfx/data_tx.c  
> > > index 8b0c52392319..0038dc7666cf 100644
> > > --- a/drivers/staging/wfx/data_tx.c
> > > +++ b/drivers/staging/wfx/data_tx.c
> > > @@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif,  
> > struct ieee80211_hdr *hdr,  
> > >  }
> > >
> > >  static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> > > -                                   struct ieee80211_sta *sta,
> > > -                                   struct ieee80211_hdr *hdr)
> > > +                              struct ieee80211_sta *sta,
> > > +                              struct ieee80211_hdr *hdr)
> > >  {
> > >       struct wfx_sta_priv *sta_priv =
> > >               sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> > > @@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct  
> > ieee80211_tx_rate *rates)  
> > >  }
> > >
> > >  static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> > > -                               struct ieee80211_tx_info *tx_info)
> > > +                          struct ieee80211_tx_info *tx_info)
> > >  {
> > >       bool tx_policy_renew = false;
> > >       u8 rate_id;  
> >
> > Change looks good, more Cc:'s needed.
> >  
> 
> Is is needed to resend all these patches to send them to the other
> maintainers?

I think it would be nice, yes.

-- 
Stefano



  reply	other threads:[~2020-03-09 12:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-08 18:55 [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis Payal Kshirsagar
2020-03-09 11:41 ` Stefano Brivio
2020-03-09 11:53   ` Payal Kshirsagar
2020-03-09 12:58     ` Stefano Brivio [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-03-09 16:45 Payal Kshirsagar
2020-03-09 17:33 ` Jérôme Pouiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200309135852.3134f4b8@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=payalskshirsagar1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.