From: "Jérôme Pouiller" <Jerome.Pouiller@silabs.com>
To: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"outreachy-kernel@googlegroups.com"
<outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis
Date: Mon, 9 Mar 2020 17:33:25 +0000 [thread overview]
Message-ID: <3300885.yygXCFTgMT@pc-42> (raw)
In-Reply-To: <20200309164515.4880-1-payalskshirsagar1234@gmail.com>
On Monday 9 March 2020 17:45:15 CET Payal Kshirsagar wrote:
>
> Align code to open parenthesis.
>
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> drivers/staging/wfx/data_tx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 8b0c52392319..0038dc7666cf 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -301,8 +301,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
> }
>
> static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> - struct ieee80211_sta *sta,
> - struct ieee80211_hdr *hdr)
> + struct ieee80211_sta *sta,
> + struct ieee80211_hdr *hdr)
> {
> struct wfx_sta_priv *sta_priv =
> sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -369,7 +369,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
> }
>
> static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> - struct ieee80211_tx_info *tx_info)
> + struct ieee80211_tx_info *tx_info)
> {
> bool tx_policy_renew = false;
> u8 rate_id;
> --
> 2.17.1
>
Hello Payal,
Thank you for your contribution.
A similar patch has already been submitted a few weeks ago:
https://lkml.org/lkml/2020/2/23/208
Joe Perches has suggested that the patch should address all parenthesis
alignments:
https://lkml.org/lkml/2020/2/24/653
--
Jérôme Pouiller
next prev parent reply other threads:[~2020-03-09 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 16:45 [PATCH] [Outreachy kernel] staging: wfx: alignment should match open parenthesis Payal Kshirsagar
2020-03-09 17:33 ` Jérôme Pouiller [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-08 18:55 Payal Kshirsagar
2020-03-09 11:41 ` Stefano Brivio
2020-03-09 11:53 ` Payal Kshirsagar
2020-03-09 12:58 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3300885.yygXCFTgMT@pc-42 \
--to=jerome.pouiller@silabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=payalskshirsagar1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.