From: Dan Carpenter <dan.carpenter@oracle.com>
To: Walter Harms <wharms@bfs.de>
Cc: "Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] bfs: prevent underflow in bfs_find_entry()
Date: Tue, 10 Mar 2020 09:06:44 +0000 [thread overview]
Message-ID: <20200310090644.GA11583@kadam> (raw)
In-Reply-To: <ba294b1d861142ca8f7b204356009dd0@bfs.de>
On Mon, Mar 09, 2020 at 08:40:28AM +0000, Walter Harms wrote:
> hi Dan,
> the namelen usage is fishy. It goes into bfs_namecmp()
> where it is checked for namelen < BFS_NAMELEN, leaving
> only the case =.
The rule in bfs_namecmp() is that the name has to be NUL terminated if
there is enough space.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Walter Harms <wharms@bfs.de>
Cc: "Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] bfs: prevent underflow in bfs_find_entry()
Date: Tue, 10 Mar 2020 12:06:44 +0300 [thread overview]
Message-ID: <20200310090644.GA11583@kadam> (raw)
In-Reply-To: <ba294b1d861142ca8f7b204356009dd0@bfs.de>
On Mon, Mar 09, 2020 at 08:40:28AM +0000, Walter Harms wrote:
> hi Dan,
> the namelen usage is fishy. It goes into bfs_namecmp()
> where it is checked for namelen < BFS_NAMELEN, leaving
> only the case ==.
The rule in bfs_namecmp() is that the name has to be NUL terminated if
there is enough space.
regards,
dan carpenter
next prev parent reply other threads:[~2020-03-10 9:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 6:08 [PATCH] bfs: prevent underflow in bfs_find_entry() Dan Carpenter
2020-03-07 6:08 ` Dan Carpenter
2020-03-09 8:40 ` AW: " Walter Harms
2020-03-09 8:40 ` Walter Harms
2020-03-10 9:06 ` Dan Carpenter [this message]
2020-03-10 9:06 ` Dan Carpenter
2020-03-10 17:57 ` AW: " Walter Harms
2020-03-10 18:22 ` Tigran Aivazian
2020-03-09 9:14 ` Tigran Aivazian
2020-03-09 9:14 ` Tigran Aivazian
2020-03-10 8:38 ` Dan Carpenter
2020-03-10 8:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310090644.GA11583@kadam \
--to=dan.carpenter@oracle.com \
--cc=aivazian.tigran@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.