* [PATCH] staging: greybus: i2c.c: remove commented out function
@ 2020-03-09 17:06 Lourdes Pedrajas
2020-03-10 15:13 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Lourdes Pedrajas @ 2020-03-09 17:06 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, vireshk, johan, elder
Remove function gb_i2c_smbus_xfer() which is unused.
Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
drivers/staging/greybus/i2c.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c
index ab06fc3b9e7e..c48fa1de89b0 100644
--- a/drivers/staging/greybus/i2c.c
+++ b/drivers/staging/greybus/i2c.c
@@ -215,20 +215,6 @@ static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
return gb_i2c_transfer_operation(gb_i2c_dev, msgs, msg_count);
}
-#if 0
-/* Later */
-static int gb_i2c_smbus_xfer(struct i2c_adapter *adap,
- u16 addr, unsigned short flags, char read_write,
- u8 command, int size, union i2c_smbus_data *data)
-{
- struct gb_i2c_device *gb_i2c_dev;
-
- gb_i2c_dev = i2c_get_adapdata(adap);
-
- return 0;
-}
-#endif
-
static u32 gb_i2c_functionality(struct i2c_adapter *adap)
{
struct gb_i2c_device *gb_i2c_dev = i2c_get_adapdata(adap);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: i2c.c: remove commented out function
2020-03-09 17:06 [PATCH] staging: greybus: i2c.c: remove commented out function Lourdes Pedrajas
@ 2020-03-10 15:13 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2020-03-10 15:13 UTC (permalink / raw)
To: Lourdes Pedrajas; +Cc: outreachy-kernel, gregkh, vireshk, johan, elder
On Mon, Mar 09, 2020 at 06:06:43PM +0100, Lourdes Pedrajas wrote:
> Remove function gb_i2c_smbus_xfer() which is unused.
Sure, why not. But please remove the out-commented pointer in
gb_i2c_algorithm as well.
Also please drop the ".c" in the module prefix; "staging: greybus: i2c:"
is enough to indicate which driver (component) is being modified.
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> ---
> drivers/staging/greybus/i2c.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/staging/greybus/i2c.c b/drivers/staging/greybus/i2c.c
> index ab06fc3b9e7e..c48fa1de89b0 100644
> --- a/drivers/staging/greybus/i2c.c
> +++ b/drivers/staging/greybus/i2c.c
> @@ -215,20 +215,6 @@ static int gb_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
> return gb_i2c_transfer_operation(gb_i2c_dev, msgs, msg_count);
> }
>
> -#if 0
> -/* Later */
> -static int gb_i2c_smbus_xfer(struct i2c_adapter *adap,
> - u16 addr, unsigned short flags, char read_write,
> - u8 command, int size, union i2c_smbus_data *data)
> -{
> - struct gb_i2c_device *gb_i2c_dev;
> -
> - gb_i2c_dev = i2c_get_adapdata(adap);
> -
> - return 0;
> -}
> -#endif
> -
> static u32 gb_i2c_functionality(struct i2c_adapter *adap)
> {
> struct gb_i2c_device *gb_i2c_dev = i2c_get_adapdata(adap);
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-10 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-09 17:06 [PATCH] staging: greybus: i2c.c: remove commented out function Lourdes Pedrajas
2020-03-10 15:13 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.