From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to check i_compr_blocks correctly
Date: Tue, 10 Mar 2020 09:18:38 -0700 [thread overview]
Message-ID: <20200310161838.GB240315@google.com> (raw)
In-Reply-To: <3525f924-7d65-c005-a7e6-d315cf14aab2@kernel.org>
On 03/10, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2020-2-25 18:26, Chao Yu wrote:
> > inode.i_blocks counts based on 512byte sector, we need to convert
> > to 4kb sized block count before comparing to i_compr_blocks.
> >
> > In addition, add to print message when sanity check on inode
> > compression configs failed.
> >
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>
> > ---
> > fs/f2fs/inode.c | 23 ++++++++++++++++++++---
> > 1 file changed, 20 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > index 156cc5ef3044..299611562f7e 100644
> > --- a/fs/f2fs/inode.c
> > +++ b/fs/f2fs/inode.c
> > @@ -291,13 +291,30 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page)
> > fi->i_flags & F2FS_COMPR_FL &&
> > F2FS_FITS_IN_INODE(ri, fi->i_extra_isize,
> > i_log_cluster_size)) {
> > - if (ri->i_compress_algorithm >= COMPRESS_MAX)
> > + if (ri->i_compress_algorithm >= COMPRESS_MAX) {
> > + f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "
> > + "compress algorithm: %u, run fsck to fix",
> > + __func__, inode->i_ino,
> > + ri->i_compress_algorithm);
> > return false;
> > - if (le64_to_cpu(ri->i_compr_blocks) > inode->i_blocks)
> > + }
> > + if (le64_to_cpu(ri->i_compr_blocks) >
> > + SECTOR_TO_BLOCK(inode->i_blocks)) {
> > + f2fs_warn(sbi, "%s: inode (ino=%lx) hash inconsistent "
>
> This is a typo: hash -> has
>
> Could you please manually fix this in your tree?
Done.
>
> Thanks
>
> > + "i_compr_blocks:%llu, i_blocks:%llu, run fsck to fix",
> > + __func__, inode->i_ino,
> > + le64_to_cpu(ri->i_compr_blocks),
> > + SECTOR_TO_BLOCK(inode->i_blocks));
> > return false;
> > + }
> > if (ri->i_log_cluster_size < MIN_COMPRESS_LOG_SIZE ||
> > - ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE)
> > + ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE) {
> > + f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "
> > + "log cluster size: %u, run fsck to fix",
> > + __func__, inode->i_ino,
> > + ri->i_log_cluster_size);
> > return false;
> > + }
> > }
> >
> > return true;
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix to check i_compr_blocks correctly
Date: Tue, 10 Mar 2020 09:18:38 -0700 [thread overview]
Message-ID: <20200310161838.GB240315@google.com> (raw)
In-Reply-To: <3525f924-7d65-c005-a7e6-d315cf14aab2@kernel.org>
On 03/10, Chao Yu wrote:
> Hi Jaegeuk,
>
> On 2020-2-25 18:26, Chao Yu wrote:
> > inode.i_blocks counts based on 512byte sector, we need to convert
> > to 4kb sized block count before comparing to i_compr_blocks.
> >
> > In addition, add to print message when sanity check on inode
> > compression configs failed.
> >
> > Signed-off-by: Chao Yu <yuchao0@huawei.com>
> > ---
> > fs/f2fs/inode.c | 23 ++++++++++++++++++++---
> > 1 file changed, 20 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> > index 156cc5ef3044..299611562f7e 100644
> > --- a/fs/f2fs/inode.c
> > +++ b/fs/f2fs/inode.c
> > @@ -291,13 +291,30 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page)
> > fi->i_flags & F2FS_COMPR_FL &&
> > F2FS_FITS_IN_INODE(ri, fi->i_extra_isize,
> > i_log_cluster_size)) {
> > - if (ri->i_compress_algorithm >= COMPRESS_MAX)
> > + if (ri->i_compress_algorithm >= COMPRESS_MAX) {
> > + f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "
> > + "compress algorithm: %u, run fsck to fix",
> > + __func__, inode->i_ino,
> > + ri->i_compress_algorithm);
> > return false;
> > - if (le64_to_cpu(ri->i_compr_blocks) > inode->i_blocks)
> > + }
> > + if (le64_to_cpu(ri->i_compr_blocks) >
> > + SECTOR_TO_BLOCK(inode->i_blocks)) {
> > + f2fs_warn(sbi, "%s: inode (ino=%lx) hash inconsistent "
>
> This is a typo: hash -> has
>
> Could you please manually fix this in your tree?
Done.
>
> Thanks
>
> > + "i_compr_blocks:%llu, i_blocks:%llu, run fsck to fix",
> > + __func__, inode->i_ino,
> > + le64_to_cpu(ri->i_compr_blocks),
> > + SECTOR_TO_BLOCK(inode->i_blocks));
> > return false;
> > + }
> > if (ri->i_log_cluster_size < MIN_COMPRESS_LOG_SIZE ||
> > - ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE)
> > + ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE) {
> > + f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "
> > + "log cluster size: %u, run fsck to fix",
> > + __func__, inode->i_ino,
> > + ri->i_log_cluster_size);
> > return false;
> > + }
> > }
> >
> > return true;
> >
next prev parent reply other threads:[~2020-03-10 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 10:26 [f2fs-dev] [PATCH] f2fs: fix to check i_compr_blocks correctly Chao Yu
2020-02-25 10:26 ` Chao Yu
2020-03-10 15:26 ` [f2fs-dev] " Chao Yu
2020-03-10 15:26 ` Chao Yu
2020-03-10 16:18 ` Jaegeuk Kim [this message]
2020-03-10 16:18 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310161838.GB240315@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.