From: Stefano Brivio <sbrivio@redhat.com>
To: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3] [Outreachy kernel] staging: vt6655: remove line over 80 characters
Date: Tue, 10 Mar 2020 18:17:03 +0100 [thread overview]
Message-ID: <20200310181703.299d2e41@elisabeth> (raw)
In-Reply-To: <20200310123229.2424-1-payalskshirsagar1234@gmail.com>
Payal,
On Tue, 10 Mar 2020 18:02:28 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:
> Reformatting code to not have lines over 80 characters.
The change looks good, but the subject (that is, the commit title)
still doesn't match the contents of the change. You're not removing,
and it's not a single line.
Also,
> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> v3: Change in patch description.
This should be cumulative, that is:
v4: < you know what :) >
v3: Change in patch
v2: < changes you listed for v2 >
Otherwise, reviewers and maintainers will have a hard time tracking
your submissions. Thanks,
--
Stefano
prev parent reply other threads:[~2020-03-10 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 12:32 [PATCH v3] [Outreachy kernel] staging: vt6655: remove line over 80 characters Payal Kshirsagar
2020-03-10 17:17 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310181703.299d2e41@elisabeth \
--to=sbrivio@redhat.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=payalskshirsagar1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.