All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] [Outreachy kernel] staging: vt6655: remove line over 80 characters
@ 2020-03-10 12:32 Payal Kshirsagar
  2020-03-10 17:17 ` Stefano Brivio
  0 siblings, 1 reply; 2+ messages in thread
From: Payal Kshirsagar @ 2020-03-10 12:32 UTC (permalink / raw)
  To: forest, gregkh, outreachy-kernel; +Cc: Payal Kshirsagar

Reformatting code to not have lines over 80 characters.

Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
---
v3: Change in patch description.

 drivers/staging/vt6655/mac.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index c7888c4e96f2..eb56e16637f6 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -884,9 +884,11 @@ bool MACbIsIntDisable(struct vnt_private *priv);
 void MACvSetShortRetryLimit(struct vnt_private *priv,
 			    unsigned char byRetryLimit);
 
-void MACvSetLongRetryLimit(struct vnt_private *priv, unsigned char byRetryLimit);
+void MACvSetLongRetryLimit(struct vnt_private *priv,
+			   unsigned char byRetryLimit);
 
-void MACvSetLoopbackMode(struct vnt_private *priv, unsigned char byLoopbackMode);
+void MACvSetLoopbackMode(struct vnt_private *priv,
+			 unsigned char byLoopbackMode);
 
 void MACvSaveContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
 void MACvRestoreContext(struct vnt_private *priv, unsigned char *pbyCxtBuf);
@@ -913,7 +915,8 @@ void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv,
 void MACvSetCurrATIMDescAddrEx(struct vnt_private *priv,
 			       u32 curr_desc_addr);
 void MACvTimer0MicroSDelay(struct vnt_private *priv, unsigned int uDelay);
-void MACvOneShotTimer1MicroSec(struct vnt_private *priv, unsigned int uDelayTime);
+void MACvOneShotTimer1MicroSec(struct vnt_private *priv,
+			       unsigned int uDelayTime);
 
 void MACvSetMISCFifo(struct vnt_private *priv, unsigned short wOffset,
 		     u32 dwData);
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] [Outreachy kernel] staging: vt6655: remove line over 80 characters
  2020-03-10 12:32 [PATCH v3] [Outreachy kernel] staging: vt6655: remove line over 80 characters Payal Kshirsagar
@ 2020-03-10 17:17 ` Stefano Brivio
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2020-03-10 17:17 UTC (permalink / raw)
  To: Payal Kshirsagar; +Cc: forest, gregkh, outreachy-kernel

Payal,

On Tue, 10 Mar 2020 18:02:28 +0530
Payal Kshirsagar <payalskshirsagar1234@gmail.com> wrote:

> Reformatting code to not have lines over 80 characters.

The change looks good, but the subject (that is, the commit title)
still doesn't match the contents of the change. You're not removing,
and it's not a single line.

Also,

> Signed-off-by: Payal Kshirsagar <payalskshirsagar1234@gmail.com>
> ---
> v3: Change in patch description.

This should be cumulative, that is:

v4: < you know what :) >
v3: Change in patch 
v2: < changes you listed for v2 >

Otherwise, reviewers and maintainers will have a hard time tracking
your submissions. Thanks,

-- 
Stefano



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-10 17:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-10 12:32 [PATCH v3] [Outreachy kernel] staging: vt6655: remove line over 80 characters Payal Kshirsagar
2020-03-10 17:17 ` Stefano Brivio

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.