Re: [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver

[Stefano Brivio <sbrivio@redhat.com>]

On Wed, 11 Mar 2020 00:54:31 +0530
Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:

> On Tue, Mar 10, 2020 at 07:45:21PM +0100, Stefano Brivio wrote:
> > On Tue, 10 Mar 2020 23:43:02 +0530
> > Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:
> >   
> > > On Tue, Mar 10, 2020 at 11:37:49PM +0530, Kaaira Gupta wrote:  
> > > > On Tue, Mar 10, 2020 at 06:40:33PM +0100, Stefano Brivio wrote:  
> > > >  
> > > > > And as you're posting this series for the second time, you should
> > > > > indicate this with v2 (check out the "--subject-prefix" option of git
> > > > > format-patch), and indicate the change history for these patches -- see
> > > > > other recent discussions on this list for examples of how it's done.    
> > > > 
> > > > Hey! No, I am not posting this series for the second time. As was
> > > > pointed out in my earlier patchset( which included 5/6 and 2/6 of this
> > > > patch set) that I have to create a patch set of related changes or
> > > > changes in the same driver, hence I sent this different patch set.    
> > > 
> > > THe previous patch set stands discarded, as it was not a proper set. I
> > > didn't even write a proper cover letter in that one :/  
> > 
> > Oh, right, I got confused by the fact that patch 2/6 here was 3/7 in
> > the non-series, and 5/6 was 4/7.
> > 
> > Now, at a second look, I see the series is very different, but see: if
> > you included a description of the differences for those two patches it
> > would have helped :)  
> 
> Yes, sorry I should have take care of this. I'll remember from now.
> 
> > 
> > I'll review this later. Thanks for the clarification.  
> 
> Should I correct the spellings and submit a v2? Or should I just take
> care from the next time?

I (personally) don't consider spelling mistakes very relevant in cover
letters: they don't end up in the git log, so they won't affect
later searches for specific words.

In general, I would recommend that you wait a bit (few hours to
few days, depending on how big/complicated the series is) before
re-posting: reviewers might need some time. So... give me/us time to
review this, first :)

-- 
Stefano