All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Kaaira Gupta <kgupta@es.iitr.ac.in>
Cc: jerome.pouiller@silabs.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver
Date: Tue, 10 Mar 2020 18:40:33 +0100	[thread overview]
Message-ID: <20200310184033.007d0230@elisabeth> (raw)
In-Reply-To: <20200310142509.25632-1-kgupta@es.iitr.ac.in>

Kaaira,

On Tue, 10 Mar 2020 19:55:03 +0530
Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:

> The patchset removes a few unecessary spaces in some files in the

"unnecessary"

> driver. It also removes an unused structure and uneccessary variable

"unnecessary" :)

> declaration. It also assigns a bool instaed of a digit to a boolean

"instead"

> variable.
> 
> Kaaira Gupta (6):
>   staging: wfx: data_rx.c: remove space after cast
>   staging: wfx: change 1 to bool
>   staging: wfx: dat_tx.c: remove space after a cast
>   staging: wfx: data_tx.h: remove space after cast
>   staging: wfx: remove variable declaration
>   staging: wfx: remove unused structure

And as you're posting this series for the second time, you should
indicate this with v2 (check out the "--subject-prefix" option of git
format-patch), and indicate the change history for these patches -- see
other recent discussions on this list for examples of how it's done.

I would also suggest that you give reviewers the time to answer your
questions, before re-posting. You had a question on 2/7, and I
understand it's getting late in your timezone... but you asked it just
three hours ago.

-- 
Stefano



  parent reply	other threads:[~2020-03-10 17:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 14:25 [PATCH 0/6] Clean-ups in wfx driver Kaaira Gupta
2020-03-10 14:25 ` [PATCH 1/6] staging: wfx: data_rx.c: remove space after cast Kaaira Gupta
2020-03-10 14:25 ` [PATCH 2/6] staging: wfx: change 1 to bool Kaaira Gupta
2020-03-10 14:25 ` [PATCH 3/6] staging: wfx: dat_tx.c: remove space after a cast Kaaira Gupta
2020-03-10 14:25 ` [PATCH 4/6] staging: wfx: data_tx.h: remove space after cast Kaaira Gupta
2020-03-10 14:25 ` [PATCH 5/6] staging: wfx: remove variable declaration Kaaira Gupta
2020-03-10 14:25 ` [PATCH 6/6] staging: wfx: remove unused structure Kaaira Gupta
2020-03-10 17:40 ` Stefano Brivio [this message]
2020-03-10 18:07   ` [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver Kaaira Gupta
2020-03-10 18:13     ` Kaaira Gupta
2020-03-10 18:45       ` Stefano Brivio
2020-03-10 19:24         ` Kaaira Gupta
2020-03-10 19:30           ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310184033.007d0230@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jerome.pouiller@silabs.com \
    --cc=kgupta@es.iitr.ac.in \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.