[PATCH 0/6] Clean-ups in wfx driver

[PATCH 0/6] Clean-ups in wfx driver

[Kaaira Gupta]

The patchset removes a few unecessary spaces in some files in the
driver. It also removes an unused structure and uneccessary variable
declaration. It also assigns a bool instaed of a digit to a boolean
variable.

Kaaira Gupta (6):
  staging: wfx: data_rx.c: remove space after cast
  staging: wfx: change 1 to bool
  staging: wfx: dat_tx.c: remove space after a cast
  staging: wfx: data_tx.h: remove space after cast
  staging: wfx: remove variable declaration
  staging: wfx: remove unused structure

 drivers/staging/wfx/data_rx.c     | 2 +-
 drivers/staging/wfx/data_tx.c     | 6 +++---
 drivers/staging/wfx/data_tx.h     | 2 +-
 drivers/staging/wfx/hif_api_cmd.h | 4 ----
 drivers/staging/wfx/sta.c         | 3 +--
 5 files changed, 6 insertions(+), 11 deletions(-)

-- 
2.17.1

[PATCH 1/6] staging: wfx: data_rx.c: remove space after cast

[Kaaira Gupta]

remove an unesseccary space after a cast in file data_rx.c

Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
 drivers/staging/wfx/data_rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wfx/data_rx.c b/drivers/staging/wfx/data_rx.c
index 2a09f6b978c3..c5b83fedeb55 100644
--- a/drivers/staging/wfx/data_rx.c
+++ b/drivers/staging/wfx/data_rx.c
@@ -17,7 +17,7 @@ static int wfx_drop_encrypt_data(struct wfx_dev *wdev,
 				 const struct hif_ind_rx *arg,
 				 struct sk_buff *skb)
 {
-	struct ieee80211_hdr *frame = (struct ieee80211_hdr *) skb->data;
+	struct ieee80211_hdr *frame = (struct ieee80211_hdr *)skb->data;
 	size_t hdrlen = ieee80211_hdrlen(frame->frame_control);
 	size_t iv_len, icv_len;
 
-- 
2.17.1

[PATCH 2/6] staging: wfx: change 1 to bool

[Kaaira Gupta]

policies[i].uploaded is a bool. 1 is assigned to it. Change it to bool.

Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
 drivers/staging/wfx/data_tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index 815fde0913f5..ef617347abad 100644
--- a/drivers/staging/wfx/data_tx.c
+++ b/drivers/staging/wfx/data_tx.c
@@ -227,7 +227,7 @@ static int wfx_tx_policy_upload(struct wfx_vif *wvif)
 			    memzcmp(policies[i].rates, sizeof(policies[i].rates)))
 				break;
 		if (i < HIF_MIB_NUM_TX_RATE_RETRY_POLICIES) {
-			policies[i].uploaded = 1;
+			policies[i].uploaded = true;
 			memcpy(tmp_rates, policies[i].rates, sizeof(tmp_rates));
 			spin_unlock_bh(&wvif->tx_policy_cache.lock);
 			hif_set_tx_rate_retry_policy(wvif, i, tmp_rates);
-- 
2.17.1

[PATCH 3/6] staging: wfx: dat_tx.c: remove space after a cast

[Kaaira Gupta]

remove extra spaces after casts in file data_tx.c

Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
 drivers/staging/wfx/data_tx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
index ef617347abad..42183c70d4df 100644
--- a/drivers/staging/wfx/data_tx.c
+++ b/drivers/staging/wfx/data_tx.c
@@ -304,7 +304,7 @@ static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
 				 struct ieee80211_hdr *hdr)
 {
 	struct wfx_sta_priv *sta_priv =
-		sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
+		sta ? (struct wfx_sta_priv *)&sta->drv_priv : NULL;
 	const u8 *da = ieee80211_get_DA(hdr);
 
 	if (sta_priv && sta_priv->link_id)
@@ -430,7 +430,7 @@ static int wfx_tx_inner(struct wfx_vif *wvif, struct ieee80211_sta *sta,
 	struct ieee80211_key_conf *hw_key = tx_info->control.hw_key;
 	struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
 	int queue_id = tx_info->hw_queue;
-	size_t offset = (size_t) skb->data & 3;
+	size_t offset = (size_t)skb->data & 3;
 	int wmsg_len = sizeof(struct hif_msg) +
 			sizeof(struct hif_req_tx) + offset;
 
-- 
2.17.1

[PATCH 4/6] staging: wfx: data_tx.h: remove space after cast

[Kaaira Gupta]

remove extra space after a cast in file data_tx.h

Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
 drivers/staging/wfx/data_tx.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wfx/data_tx.h b/drivers/staging/wfx/data_tx.h
index 04b2147101b6..c545dd75449b 100644
--- a/drivers/staging/wfx/data_tx.h
+++ b/drivers/staging/wfx/data_tx.h
@@ -61,7 +61,7 @@ static inline struct wfx_tx_priv *wfx_skb_tx_priv(struct sk_buff *skb)
 static inline struct hif_req_tx *wfx_skb_txreq(struct sk_buff *skb)
 {
 	struct hif_msg *hif = (struct hif_msg *)skb->data;
-	struct hif_req_tx *req = (struct hif_req_tx *) hif->body;
+	struct hif_req_tx *req = (struct hif_req_tx *)hif->body;
 
 	return req;
 }
-- 
2.17.1

[PATCH 5/6] staging: wfx: remove variable declaration

[Kaaira Gupta]

int ret is uneccessarily declared and 0 assigned to it. Return o
directly instead.

Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
 drivers/staging/wfx/sta.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 03d0f224ffdb..a60ac03fa73d 100644
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -293,7 +293,6 @@ int wfx_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 	struct wfx_dev *wdev = hw->priv;
 	struct wfx_vif *wvif = (struct wfx_vif *) vif->drv_priv;
 	int old_uapsd = wvif->uapsd_mask;
-	int ret = 0;
 
 	WARN_ON(queue >= hw->queues);
 
@@ -307,7 +306,7 @@ int wfx_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
 		wfx_update_pm(wvif);
 	}
 	mutex_unlock(&wdev->conf_mutex);
-	return ret;
+	return 0;
 }
 
 int wfx_set_rts_threshold(struct ieee80211_hw *hw, u32 value)
-- 
2.17.1

[PATCH 6/6] staging: wfx: remove unused structure

[Kaaira Gupta]

struct hif_cnf_reset is not used anywhere in wfx. It's parent file
hif_api_cmd.h is imported form some other driver, hence some functions
in it are not used. This is one of them. Hence remove it.

Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
 drivers/staging/wfx/hif_api_cmd.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h
index 5554d6eddbf3..071b71e2a107 100644
--- a/drivers/staging/wfx/hif_api_cmd.h
+++ b/drivers/staging/wfx/hif_api_cmd.h
@@ -95,10 +95,6 @@ struct hif_req_reset {
 	struct hif_reset_flags reset_flags;
 } __packed;
 
-struct hif_cnf_reset {
-	u32   status;
-} __packed;
-
 struct hif_req_read_mib {
 	u16   mib_id;
 	u16   reserved;
-- 
2.17.1

Re: [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver

[Stefano Brivio]

Kaaira,

On Tue, 10 Mar 2020 19:55:03 +0530
Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:

> The patchset removes a few unecessary spaces in some files in the

"unnecessary"

> driver. It also removes an unused structure and uneccessary variable

"unnecessary" :)

> declaration. It also assigns a bool instaed of a digit to a boolean

"instead"

> variable.
> 
> Kaaira Gupta (6):
>   staging: wfx: data_rx.c: remove space after cast
>   staging: wfx: change 1 to bool
>   staging: wfx: dat_tx.c: remove space after a cast
>   staging: wfx: data_tx.h: remove space after cast
>   staging: wfx: remove variable declaration
>   staging: wfx: remove unused structure

And as you're posting this series for the second time, you should
indicate this with v2 (check out the "--subject-prefix" option of git
format-patch), and indicate the change history for these patches -- see
other recent discussions on this list for examples of how it's done.

I would also suggest that you give reviewers the time to answer your
questions, before re-posting. You had a question on 2/7, and I
understand it's getting late in your timezone... but you asked it just
three hours ago.

-- 
Stefano

Re: [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver

[Kaaira Gupta]

On Tue, Mar 10, 2020 at 06:40:33PM +0100, Stefano Brivio wrote:
> Kaaira,
> 
> On Tue, 10 Mar 2020 19:55:03 +0530
> Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:
> 
> > The patchset removes a few unecessary spaces in some files in the
> 
> "unnecessary"

Thanks, I'll change the spelling errors.

> 
> > driver. It also removes an unused structure and uneccessary variable
> 
> "unnecessary" :)
> 
> > declaration. It also assigns a bool instaed of a digit to a boolean
> 
> "instead"
> 
> > variable.
> > 
> > Kaaira Gupta (6):
> >   staging: wfx: data_rx.c: remove space after cast
> >   staging: wfx: change 1 to bool
> >   staging: wfx: dat_tx.c: remove space after a cast
> >   staging: wfx: data_tx.h: remove space after cast
> >   staging: wfx: remove variable declaration
> >   staging: wfx: remove unused structure
> 
> And as you're posting this series for the second time, you should
> indicate this with v2 (check out the "--subject-prefix" option of git
> format-patch), and indicate the change history for these patches -- see
> other recent discussions on this list for examples of how it's done.

Hey! No, I am not posting this series for the second time. As was
pointed out in my earlier patchset( which included 5/6 and 2/6 of this
patch set) that I have to create a patch set of related changes or
changes in the same driver, hence I sent this different patch set.

> 
> I would also suggest that you give reviewers the time to answer your
> questions, before re-posting. You had a question on 2/7, and I
> understand it's getting late in your timezone... but you asked it just
> three hours ago.

As for this, thanks for understanding. But that patch was different from
any of the patches I Have sent here. That was for a change in vt6656.

Thanks for your time!

> 
> -- 
> Stefano
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200310184033.007d0230%40elisabeth.

Re: [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver

[Kaaira Gupta]

On Tue, Mar 10, 2020 at 11:37:49PM +0530, Kaaira Gupta wrote:
> On Tue, Mar 10, 2020 at 06:40:33PM +0100, Stefano Brivio wrote:
> > Kaaira,
> > 
> > On Tue, 10 Mar 2020 19:55:03 +0530
> > Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:
> > 
> > > The patchset removes a few unecessary spaces in some files in the
> > 
> > "unnecessary"
> 
> Thanks, I'll change the spelling errors.
> 
> > 
> > > driver. It also removes an unused structure and uneccessary variable
> > 
> > "unnecessary" :)
> > 
> > > declaration. It also assigns a bool instaed of a digit to a boolean
> > 
> > "instead"
> > 
> > > variable.
> > > 
> > > Kaaira Gupta (6):
> > >   staging: wfx: data_rx.c: remove space after cast
> > >   staging: wfx: change 1 to bool
> > >   staging: wfx: dat_tx.c: remove space after a cast
> > >   staging: wfx: data_tx.h: remove space after cast
> > >   staging: wfx: remove variable declaration
> > >   staging: wfx: remove unused structure
> > 
> > And as you're posting this series for the second time, you should
> > indicate this with v2 (check out the "--subject-prefix" option of git
> > format-patch), and indicate the change history for these patches -- see
> > other recent discussions on this list for examples of how it's done.
> 
> Hey! No, I am not posting this series for the second time. As was
> pointed out in my earlier patchset( which included 5/6 and 2/6 of this
> patch set) that I have to create a patch set of related changes or
> changes in the same driver, hence I sent this different patch set.

THe previous patch set stands discarded, as it was not a proper set. I
didn't even write a proper cover letter in that one :/

> 
> > 
> > I would also suggest that you give reviewers the time to answer your
> > questions, before re-posting. You had a question on 2/7, and I
> > understand it's getting late in your timezone... but you asked it just
> > three hours ago.
> 
> As for this, thanks for understanding. But that patch was different from
> any of the patches I Have sent here. That was for a change in vt6656.
> 
> Thanks for your time!
> 
> > 
> > -- 
> > Stefano
> > 
> > -- 
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200310184033.007d0230%40elisabeth.

Re: [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver

[Stefano Brivio]

On Tue, 10 Mar 2020 23:43:02 +0530
Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:

> On Tue, Mar 10, 2020 at 11:37:49PM +0530, Kaaira Gupta wrote:
> > On Tue, Mar 10, 2020 at 06:40:33PM +0100, Stefano Brivio wrote:  
> >
> > > And as you're posting this series for the second time, you should
> > > indicate this with v2 (check out the "--subject-prefix" option of git
> > > format-patch), and indicate the change history for these patches -- see
> > > other recent discussions on this list for examples of how it's done.  
> > 
> > Hey! No, I am not posting this series for the second time. As was
> > pointed out in my earlier patchset( which included 5/6 and 2/6 of this
> > patch set) that I have to create a patch set of related changes or
> > changes in the same driver, hence I sent this different patch set.  
> 
> THe previous patch set stands discarded, as it was not a proper set. I
> didn't even write a proper cover letter in that one :/

Oh, right, I got confused by the fact that patch 2/6 here was 3/7 in
the non-series, and 5/6 was 4/7.

Now, at a second look, I see the series is very different, but see: if
you included a description of the differences for those two patches it
would have helped :)

I'll review this later. Thanks for the clarification.

-- 
Stefano

Re: [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver

[Kaaira Gupta]

On Tue, Mar 10, 2020 at 07:45:21PM +0100, Stefano Brivio wrote:
> On Tue, 10 Mar 2020 23:43:02 +0530
> Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:
> 
> > On Tue, Mar 10, 2020 at 11:37:49PM +0530, Kaaira Gupta wrote:
> > > On Tue, Mar 10, 2020 at 06:40:33PM +0100, Stefano Brivio wrote:  
> > >
> > > > And as you're posting this series for the second time, you should
> > > > indicate this with v2 (check out the "--subject-prefix" option of git
> > > > format-patch), and indicate the change history for these patches -- see
> > > > other recent discussions on this list for examples of how it's done.  
> > > 
> > > Hey! No, I am not posting this series for the second time. As was
> > > pointed out in my earlier patchset( which included 5/6 and 2/6 of this
> > > patch set) that I have to create a patch set of related changes or
> > > changes in the same driver, hence I sent this different patch set.  
> > 
> > THe previous patch set stands discarded, as it was not a proper set. I
> > didn't even write a proper cover letter in that one :/
> 
> Oh, right, I got confused by the fact that patch 2/6 here was 3/7 in
> the non-series, and 5/6 was 4/7.
> 
> Now, at a second look, I see the series is very different, but see: if
> you included a description of the differences for those two patches it
> would have helped :)

Yes, sorry I should have take care of this. I'll remember from now.

> 
> I'll review this later. Thanks for the clarification.

Should I correct the spellings and submit a v2? Or should I just take
care from the next time?

Thanks!

> 
> -- 
> Stefano
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200310194521.485e04a4%40elisabeth.

Re: [Outreachy kernel] [PATCH 0/6] Clean-ups in wfx driver

[Stefano Brivio]

On Wed, 11 Mar 2020 00:54:31 +0530
Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:

> On Tue, Mar 10, 2020 at 07:45:21PM +0100, Stefano Brivio wrote:
> > On Tue, 10 Mar 2020 23:43:02 +0530
> > Kaaira Gupta <kgupta@es.iitr.ac.in> wrote:
> >   
> > > On Tue, Mar 10, 2020 at 11:37:49PM +0530, Kaaira Gupta wrote:  
> > > > On Tue, Mar 10, 2020 at 06:40:33PM +0100, Stefano Brivio wrote:  
> > > >  
> > > > > And as you're posting this series for the second time, you should
> > > > > indicate this with v2 (check out the "--subject-prefix" option of git
> > > > > format-patch), and indicate the change history for these patches -- see
> > > > > other recent discussions on this list for examples of how it's done.    
> > > > 
> > > > Hey! No, I am not posting this series for the second time. As was
> > > > pointed out in my earlier patchset( which included 5/6 and 2/6 of this
> > > > patch set) that I have to create a patch set of related changes or
> > > > changes in the same driver, hence I sent this different patch set.    
> > > 
> > > THe previous patch set stands discarded, as it was not a proper set. I
> > > didn't even write a proper cover letter in that one :/  
> > 
> > Oh, right, I got confused by the fact that patch 2/6 here was 3/7 in
> > the non-series, and 5/6 was 4/7.
> > 
> > Now, at a second look, I see the series is very different, but see: if
> > you included a description of the differences for those two patches it
> > would have helped :)  
> 
> Yes, sorry I should have take care of this. I'll remember from now.
> 
> > 
> > I'll review this later. Thanks for the clarification.  
> 
> Should I correct the spellings and submit a v2? Or should I just take
> care from the next time?

I (personally) don't consider spelling mistakes very relevant in cover
letters: they don't end up in the git log, so they won't affect
later searches for specific words.

In general, I would recommend that you wait a bit (few hours to
few days, depending on how big/complicated the series is) before
re-posting: reviewers might need some time. So... give me/us time to
review this, first :)

-- 
Stefano