Re: Re: [PATCH 02/10] Bluetooth: Add initial implementation of CIS connections

[kernel test robot <rong.a.chen@intel.com>]

> On Tue, Jan 7, 2020 at 12:22 PM, kbuild test robot <lkp@intel.com> wrote:
> > Hi Luiz,
> > 
> > Thank you for the patch! Yet something to improve:
> > 
> > [auto build test ERROR on bluetooth-next/master]
> > [also build test ERROR on next-20200106]
> > [cannot apply to bluetooth/master v5.5-rc5]
> > [if your patch is applied to the wrong git tree, please drop us a note to
> > help
> > improve the system. BTW, we also suggest to use '--base' option to specify
> > the
> > base tree in git format-patch, please see
> > <https://stackoverflow.com/a/37406982>]
> > 
> > url:    <https://github.com/0day-ci/linux/commits/Luiz-Augusto-von-Dentz/Bluetooth-5-2-initial-support/20200107-160723>
> > base:   <https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git>
> > master
> > config: i386-randconfig-f001-20200107 (attached as .config)
> > compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com <mailto:lkp@intel.com>>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    ld: net/bluetooth/af_bluetooth.o: in function `bt_init':
> > > >  net/bluetooth/af_bluetooth.c:760: undefined reference to `iso_init'
> > > >  ld: net/bluetooth/af_bluetooth.c:771: undefined reference to
> > > > `iso_exit'
> >    ld: net/bluetooth/hci_core.o: in function `hci_isodata_packet':
> > > >  net/bluetooth/hci_core.c:4480: undefined reference to `iso_recv'
> >    ld: net/bluetooth/hci_event.o: in function `hci_proto_connect_ind':
> > > >  include/net/bluetooth/hci_core.h:1285: undefined reference to
> > > > `iso_connect_ind'
> > > >  ld: include/net/bluetooth/hci_core.h:1285: undefined reference to
> > > > `iso_connect_ind'
> > 
> 
> Interesting, I don't get these error even when compiling patch by patch, those
> symbols are in a new file net/bluetooth/iso.c which seems to be properly added
> so I wonder what is going on here.


Hi,

We confirmed that it could be reproduced with gcc-7.

Best Regards,
Rong Chen

> 
> > vim +760 net/bluetooth/af_bluetooth.c
> > 
> >    718
> >    719	#define VERSION __stringify(BT_SUBSYS_VERSION) "." \
> >    720			__stringify(BT_SUBSYS_REVISION)
> >    721
> >    722	static int __init bt_init(void)
> >    723	{
> >    724		int err;
> >    725
> >    726		sock_skb_cb_check_size(sizeof(struct bt_skb_cb));
> >    727
> >    728		BT_INFO("Core ver %s", VERSION);
> >    729
> >    730		err = bt_selftest();
> >    731		if (err < 0)
> >    732			return err;
> >    733
> >    734		bt_debugfs = debugfs_create_dir("bluetooth", NULL);
> >    735
> >    736		bt_leds_init();
> >    737
> >    738		err = bt_sysfs_init();
> >    739		if (err < 0)
> >    740			return err;
> >    741
> >    742		err = sock_register(&bt_sock_family_ops);
> >    743		if (err)
> >    744			goto cleanup_sysfs;
> >    745
> >    746		BT_INFO("HCI device and connection manager initialized");
> >    747
> >    748		err = hci_sock_init();
> >    749		if (err)
> >    750			goto unregister_socket;
> >    751
> >    752		err = l2cap_init();
> >    753		if (err)
> >    754			goto cleanup_socket;
> >    755
> >    756		err = sco_init();
> >    757		if (err)
> >    758			goto cleanup_cap;
> >    759
> >  > 760		err = iso_init();
> >    761		if (err)
> >    762			goto cleanup_sco;
> >    763
> >    764		err = mgmt_init();
> >    765		if (err)
> >    766			goto cleanup_iso;
> >    767
> >    768		return 0;
> >    769
> >    770	cleanup_iso:
> >  > 771		iso_exit();
> >    772	cleanup_sco:
> >    773		sco_exit();
> >    774	cleanup_cap:
> >    775		l2cap_exit();
> >    776	cleanup_socket:
> >    777		hci_sock_cleanup();
> >    778	unregister_socket:
> >    779		sock_unregister(PF_BLUETOOTH);
> >    780	cleanup_sysfs:
> >    781		bt_sysfs_cleanup();
> >    782		return err;
> >    783	}
> >    784
> > 
> > ---
> > 0-DAY kernel test infrastructure                 Open Source Technology
> > Center
> > <https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org> Intel
> > Corporation
> 
> 
> ----- End forwarded message -----