[PATCH] Staging: qlge: include newline after declarations

[PATCH] Staging: qlge: include newline after declarations

[Enrique Vargas]

add newline following coding conventions

Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
 drivers/staging/qlge/qlge_dbg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 670361873d1d..52704c67e110 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
 {
 	int i;
 	u32 value;
+
 	for (i = 0; i < qdev->intr_count; i++) {
 		ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
 		value = ql_read32(qdev, INTR_EN);
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] Staging: qlge: include newline after declarations

[Julia Lawall]

On Wed, 11 Mar 2020, Enrique Vargas wrote:

> add newline following coding conventions

The patch seems conceptually fine.  But it would be nice to make a proper
sentence, ie start with a capital letter and end with a period.  Also, if
checkpatch helped you find the problem, it could be good to acknowledge
that.

julia

>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
>  drivers/staging/qlge/qlge_dbg.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 670361873d1d..52704c67e110 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
>  {
>  	int i;
>  	u32 value;
> +
>  	for (i = 0; i < qdev->intr_count; i++) {
>  		ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
>  		value = ql_read32(qdev, INTR_EN);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311141857.GA16781%40evX1.
>

Re: [Outreachy kernel] [PATCH] Staging: qlge: include newline after declarations

[Enrique Vargas]

On 3/11/20 8:23 AM, Julia Lawall wrote:
>
> On Wed, 11 Mar 2020, Enrique Vargas wrote:
>
>> add newline following coding conventions
> The patch seems conceptually fine.  But it would be nice to make a proper
> sentence, ie start with a capital letter and end with a period.  Also, if
> checkpatch helped you find the problem, it could be good to acknowledge
> that.
>
> julia
>
>> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
>> ---
>>  drivers/staging/qlge/qlge_dbg.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
>> index 670361873d1d..52704c67e110 100644
>> --- a/drivers/staging/qlge/qlge_dbg.c
>> +++ b/drivers/staging/qlge/qlge_dbg.c
>> @@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
>>  {
>>  	int i;
>>  	u32 value;
>> +
>>  	for (i = 0; i < qdev->intr_count; i++) {
>>  		ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
>>  		value = ql_read32(qdev, INTR_EN);
>> --
>> 2.17.1
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200311141857.GA16781%40evX1.
>>

Thanks for the feedback, resending with your comments.

[PATCH] Staging: qlge: include newline after declarations

[Enrique Vargas]

Add newline following coding conventions, to eliminate WARNING found
using checkpath.

Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
 drivers/staging/qlge/qlge_dbg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 670361873d1d..52704c67e110 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -1332,6 +1332,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
 {
 	int i;
 	u32 value;
+
 	for (i = 0; i < qdev->intr_count; i++) {
 		ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
 		value = ql_read32(qdev, INTR_EN);
-- 
2.17.1

Re: [PATCH] Staging: qlge: include newline after declarations

[Greg Kroah-Hartman]

On Wed, Mar 11, 2020 at 08:28:36AM -0600, Enrique Vargas wrote:
> Add newline following coding conventions, to eliminate WARNING found
> using checkpath.
> 
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
>  drivers/staging/qlge/qlge_dbg.c | 1 +
>  1 file changed, 1 insertion(+)

As this is a "version 2" of the patch, you need to tell me that
somehow.  Please read the submitting patches document in the kernel
Documentation directory for how to do that properly.

Please fix up and send a v3.

thanks,

greg k-h