From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Wambui Karuga <wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: daniel-/w4YWyX8dFk@public.gmane.org,
airlied-cv59FeDIM0c@public.gmane.org,
Jonathan Hunter
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value
Date: Thu, 12 Mar 2020 00:24:46 +0100 [thread overview]
Message-ID: <20200311232446.GA998881@ulmo> (raw)
In-Reply-To: <alpine.LNX.2.21.99999.375.2003111750360.14786@wambui>
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
On Wed, Mar 11, 2020 at 05:54:46PM +0300, Wambui Karuga wrote:
> Hey Thierry,
>
> On Wed, 11 Mar 2020, Thierry Reding wrote:
>
> > On Thu, Feb 27, 2020 at 03:02:21PM +0300, Wambui Karuga wrote:
> > > Since 987d65d01356 (drm: debugfs: make
> > > drm_debugfs_create_files() never fail) there is no need to check the
> > > return value of drm_debugfs_create_files(). Therefore, remove the
> > > return checks and error handling of the drm_debugfs_create_files()
> > > function from various debugfs init functions in drm/tegra and have
> > > them return 0 directly.
> > >
> > > This change also includes removing the use of drm_debugfs_create_files
> > > as a return value in tegra_debugfs_init() and have the function declared
> > > as void.
> > >
> > > Signed-off-by: Wambui Karuga <wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > ---
> > > drivers/gpu/drm/tegra/dc.c | 11 +----------
> > > drivers/gpu/drm/tegra/drm.c | 8 ++++----
> > > drivers/gpu/drm/tegra/dsi.c | 11 +----------
> > > drivers/gpu/drm/tegra/hdmi.c | 11 +----------
> > > drivers/gpu/drm/tegra/sor.c | 11 +----------
> > > 5 files changed, 8 insertions(+), 44 deletions(-)
> >
> > Applied, thanks.
> >
> There's a newer version[1] of this patch series as this specific patch
> depends on other work in drm.
Oh yeah, I just noticed that this patch causes a build failure, so I
backed it out again.
If there's dependencies on other work, it's probably best to take this
through drm-misc, in which case:
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Let me know if you'd prefer me to apply this to drm/tegra instead.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Wambui Karuga <wambui.karugax@gmail.com>
Cc: airlied@linux.ie, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value
Date: Thu, 12 Mar 2020 00:24:46 +0100 [thread overview]
Message-ID: <20200311232446.GA998881@ulmo> (raw)
In-Reply-To: <alpine.LNX.2.21.99999.375.2003111750360.14786@wambui>
[-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --]
On Wed, Mar 11, 2020 at 05:54:46PM +0300, Wambui Karuga wrote:
> Hey Thierry,
>
> On Wed, 11 Mar 2020, Thierry Reding wrote:
>
> > On Thu, Feb 27, 2020 at 03:02:21PM +0300, Wambui Karuga wrote:
> > > Since 987d65d01356 (drm: debugfs: make
> > > drm_debugfs_create_files() never fail) there is no need to check the
> > > return value of drm_debugfs_create_files(). Therefore, remove the
> > > return checks and error handling of the drm_debugfs_create_files()
> > > function from various debugfs init functions in drm/tegra and have
> > > them return 0 directly.
> > >
> > > This change also includes removing the use of drm_debugfs_create_files
> > > as a return value in tegra_debugfs_init() and have the function declared
> > > as void.
> > >
> > > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
> > > ---
> > > drivers/gpu/drm/tegra/dc.c | 11 +----------
> > > drivers/gpu/drm/tegra/drm.c | 8 ++++----
> > > drivers/gpu/drm/tegra/dsi.c | 11 +----------
> > > drivers/gpu/drm/tegra/hdmi.c | 11 +----------
> > > drivers/gpu/drm/tegra/sor.c | 11 +----------
> > > 5 files changed, 8 insertions(+), 44 deletions(-)
> >
> > Applied, thanks.
> >
> There's a newer version[1] of this patch series as this specific patch
> depends on other work in drm.
Oh yeah, I just noticed that this patch causes a build failure, so I
backed it out again.
If there's dependencies on other work, it's probably best to take this
through drm-misc, in which case:
Acked-by: Thierry Reding <treding@nvidia.com>
Let me know if you'd prefer me to apply this to drm/tegra instead.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Wambui Karuga <wambui.karugax@gmail.com>
Cc: daniel@ffwll.ch, airlied@linux.ie,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value
Date: Thu, 12 Mar 2020 00:24:46 +0100 [thread overview]
Message-ID: <20200311232446.GA998881@ulmo> (raw)
In-Reply-To: <alpine.LNX.2.21.99999.375.2003111750360.14786@wambui>
[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]
On Wed, Mar 11, 2020 at 05:54:46PM +0300, Wambui Karuga wrote:
> Hey Thierry,
>
> On Wed, 11 Mar 2020, Thierry Reding wrote:
>
> > On Thu, Feb 27, 2020 at 03:02:21PM +0300, Wambui Karuga wrote:
> > > Since 987d65d01356 (drm: debugfs: make
> > > drm_debugfs_create_files() never fail) there is no need to check the
> > > return value of drm_debugfs_create_files(). Therefore, remove the
> > > return checks and error handling of the drm_debugfs_create_files()
> > > function from various debugfs init functions in drm/tegra and have
> > > them return 0 directly.
> > >
> > > This change also includes removing the use of drm_debugfs_create_files
> > > as a return value in tegra_debugfs_init() and have the function declared
> > > as void.
> > >
> > > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
> > > ---
> > > drivers/gpu/drm/tegra/dc.c | 11 +----------
> > > drivers/gpu/drm/tegra/drm.c | 8 ++++----
> > > drivers/gpu/drm/tegra/dsi.c | 11 +----------
> > > drivers/gpu/drm/tegra/hdmi.c | 11 +----------
> > > drivers/gpu/drm/tegra/sor.c | 11 +----------
> > > 5 files changed, 8 insertions(+), 44 deletions(-)
> >
> > Applied, thanks.
> >
> There's a newer version[1] of this patch series as this specific patch
> depends on other work in drm.
Oh yeah, I just noticed that this patch causes a build failure, so I
backed it out again.
If there's dependencies on other work, it's probably best to take this
through drm-misc, in which case:
Acked-by: Thierry Reding <treding@nvidia.com>
Let me know if you'd prefer me to apply this to drm/tegra instead.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-11 23:24 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 12:02 [PATCH 00/21] drm: subsytem-wide debugfs functions refactor Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 01/21] drm/debugfs: remove checks for return value of drm_debugfs functions Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 02/21] drm: convert the drm_driver.debugfs_init() hook to return void Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:23 ` Greg KH
2020-02-27 12:23 ` Greg KH
2020-02-27 12:29 ` Wambui Karuga
2020-02-27 12:29 ` Wambui Karuga
2020-02-27 12:34 ` Greg KH
2020-02-27 12:34 ` Greg KH
2020-02-27 12:02 ` [PATCH 03/21] drm: convert drm_debugfs functions " Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 04/21] drm/vram-helper: make drm_vram_mm_debugfs_init() " Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-28 8:03 ` Thomas Zimmermann
2020-02-28 8:03 ` Thomas Zimmermann
2020-02-27 12:02 ` [PATCH 05/21] drm/vc4: remove check of return value of drm_debugfs functions Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 06/21] drm/arc: make arcpgu_debugfs_init return void Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 14:43 ` Alexey Brodkin
2020-02-27 14:43 ` Alexey Brodkin
2020-02-27 12:02 ` [PATCH 07/21] drm/arm: make hdlcd_debugfs_init() " Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 14:53 ` Liviu Dudau
2020-02-27 14:53 ` Liviu Dudau
2020-02-27 12:02 ` [PATCH 08/21] drm/etnaviv: remove check for return value of drm_debugfs function Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 13:36 ` Lucas Stach
2020-02-27 13:36 ` Lucas Stach
[not found] ` <20200227120232.19413-1-wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-02-27 12:02 ` [PATCH 09/21] drm/nouveau: remove checks for return value of debugfs functions Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
[not found] ` <20200227120232.19413-11-wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-11 14:37 ` Thierry Reding
2020-03-11 14:37 ` Thierry Reding
2020-03-11 14:37 ` Thierry Reding
2020-03-11 14:54 ` Wambui Karuga
2020-03-11 14:54 ` Wambui Karuga
2020-03-11 14:54 ` Wambui Karuga
2020-03-11 23:24 ` Thierry Reding [this message]
2020-03-11 23:24 ` Thierry Reding
2020-03-11 23:24 ` Thierry Reding
2020-03-16 8:33 ` Daniel Vetter
2020-03-16 8:33 ` Daniel Vetter
2020-02-27 12:02 ` [PATCH 11/21] drm/v3d: make v3d_debugfs_init return void Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 12/21] drm/msm: remove checks for return value of drm_debugfs functions Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 14:45 ` Daniel Vetter
2020-02-27 14:45 ` Daniel Vetter
2020-02-28 7:24 ` kbuild test robot
2020-02-28 7:24 ` kbuild test robot
2020-02-28 7:24 ` kbuild test robot
2020-02-27 12:02 ` [PATCH 13/21] drm/omapdrm: " Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 14/21] drm/pl111: make pl111_debugfs_init return void Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 15/21] drm/sti: remove use drm_debugfs functions as return value Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 14:51 ` Daniel Vetter
2020-02-27 14:51 ` Daniel Vetter
2020-02-27 12:02 ` [PATCH 16/21] drm/i915: make *_debugfs_register() functions return void Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [Intel-gfx] " Wambui Karuga
2020-02-27 13:08 ` Jani Nikula
2020-02-27 13:08 ` Jani Nikula
2020-02-27 13:08 ` [Intel-gfx] " Jani Nikula
2020-02-27 12:02 ` [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:12 ` Jyri Sarha
2020-02-27 12:12 ` Jyri Sarha
2020-02-27 12:23 ` Wambui Karuga
2020-02-27 12:23 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 18/21] drm/virtio: make virtio_gpu_debugfs() return void Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 19/21] drm/mipi_dbi: make midi_dbi_debugfs_init() " Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 20/21] drm/qxl: have debugfs functions " Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 12:02 ` [PATCH 21/21] drm/arm: have malidp_debufs_init() " Wambui Karuga
2020-02-27 12:02 ` Wambui Karuga
2020-02-27 14:53 ` Liviu Dudau
2020-02-27 14:53 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311232446.GA998881@ulmo \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=daniel-/w4YWyX8dFk@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wambui.karugax-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.