All of lore.kernel.org
 help / color / mirror / Atom feed
* [MPTCP] [mptcp:t/mptcp-Add-handling-of-outgoing-MP_JOIN-requests 1/4] net//mptcp/options.c:391:41: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack'
@ 2020-03-11 21:41 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-03-11 21:41 UTC (permalink / raw)
  To: mptcp 

[-- Attachment #1: Type: text/plain, Size: 6860 bytes --]

tree:   https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-Add-handling-of-outgoing-MP_JOIN-requests
head:   d1a5f94551a0e54cc7cdcd7305e22971aa2dbacb
commit: e06605d017e3bf2ee4c4803da4d25b2544735718 [1/4] tgupdate: merge t/mptcp-Add-handling-of-outgoing-MP_JOIN-requests base into t/mptcp-Add-handling-of-outgoing-MP_JOIN-requests
config: openrisc-randconfig-a001-20200312 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout e06605d017e3bf2ee4c4803da4d25b2544735718
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>

Note: the mptcp/t/mptcp-Add-handling-of-outgoing-MP_JOIN-requests HEAD d1a5f94551a0e54cc7cdcd7305e22971aa2dbacb builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   net//mptcp/options.c: In function 'mptcp_established_options_mp':
>> net//mptcp/options.c:391:41: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack'
     391 |  } else if (subflow->mp_join && !subflow->fourth_ack) {
         |                                         ^~
   net//mptcp/options.c:395:10: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack'
     395 |   subflow->fourth_ack = 1;
         |          ^~

vim +391 net//mptcp/options.c

cec37a6e41aae7 Peter Krystad    2020-01-21  343  
cc7972ea193233 Christoph Paasch 2020-01-21  344  static bool mptcp_established_options_mp(struct sock *sk, struct sk_buff *skb,
cc7972ea193233 Christoph Paasch 2020-01-21  345  					 unsigned int *size,
6d0060f600adfd Mat Martineau    2020-01-21  346  					 unsigned int remaining,
cec37a6e41aae7 Peter Krystad    2020-01-21  347  					 struct mptcp_out_options *opts)
cec37a6e41aae7 Peter Krystad    2020-01-21  348  {
cec37a6e41aae7 Peter Krystad    2020-01-21  349  	struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(sk);
cc7972ea193233 Christoph Paasch 2020-01-21  350  	struct mptcp_ext *mpext;
cc7972ea193233 Christoph Paasch 2020-01-21  351  	unsigned int data_len;
cc7972ea193233 Christoph Paasch 2020-01-21  352  
9ca72cd814cdd8 Paolo Abeni      2020-03-05  353  	pr_debug("subflow=%p fully established=%d seq=%x:%x remaining=%d",
9ca72cd814cdd8 Paolo Abeni      2020-03-05  354  		 subflow, subflow->fully_established, subflow->snd_isn,
cc7972ea193233 Christoph Paasch 2020-01-21  355  		 skb ? TCP_SKB_CB(skb)->seq : 0, remaining);
cc7972ea193233 Christoph Paasch 2020-01-21  356  
9ca72cd814cdd8 Paolo Abeni      2020-03-05  357  	if (subflow->mp_capable && !subflow->fully_established && skb &&
cc7972ea193233 Christoph Paasch 2020-01-21  358  	    subflow->snd_isn == TCP_SKB_CB(skb)->seq) {
cc7972ea193233 Christoph Paasch 2020-01-21  359  		/* When skb is not available, we better over-estimate the
cc7972ea193233 Christoph Paasch 2020-01-21  360  		 * emitted options len. A full DSS option is longer than
cc7972ea193233 Christoph Paasch 2020-01-21  361  		 * TCPOLEN_MPTCP_MPC_ACK_DATA, so let's the caller try to fit
cc7972ea193233 Christoph Paasch 2020-01-21  362  		 * that.
cc7972ea193233 Christoph Paasch 2020-01-21  363  		 */
cc7972ea193233 Christoph Paasch 2020-01-21  364  		mpext = mptcp_get_ext(skb);
cc7972ea193233 Christoph Paasch 2020-01-21  365  		data_len = mpext ? mpext->data_len : 0;
cec37a6e41aae7 Peter Krystad    2020-01-21  366  
cc7972ea193233 Christoph Paasch 2020-01-21  367  		/* we will check ext_copy.data_len in mptcp_write_options() to
cc7972ea193233 Christoph Paasch 2020-01-21  368  		 * discriminate between TCPOLEN_MPTCP_MPC_ACK_DATA and
cc7972ea193233 Christoph Paasch 2020-01-21  369  		 * TCPOLEN_MPTCP_MPC_ACK
cc7972ea193233 Christoph Paasch 2020-01-21  370  		 */
cc7972ea193233 Christoph Paasch 2020-01-21  371  		opts->ext_copy.data_len = data_len;
cec37a6e41aae7 Peter Krystad    2020-01-21  372  		opts->suboptions = OPTION_MPTCP_MPC_ACK;
cec37a6e41aae7 Peter Krystad    2020-01-21  373  		opts->sndr_key = subflow->local_key;
cec37a6e41aae7 Peter Krystad    2020-01-21  374  		opts->rcvr_key = subflow->remote_key;
cc7972ea193233 Christoph Paasch 2020-01-21  375  
cc7972ea193233 Christoph Paasch 2020-01-21  376  		/* Section 3.1.
cc7972ea193233 Christoph Paasch 2020-01-21  377  		 * The MP_CAPABLE option is carried on the SYN, SYN/ACK, and ACK
cc7972ea193233 Christoph Paasch 2020-01-21  378  		 * packets that start the first subflow of an MPTCP connection,
cc7972ea193233 Christoph Paasch 2020-01-21  379  		 * as well as the first packet that carries data
cc7972ea193233 Christoph Paasch 2020-01-21  380  		 */
cc7972ea193233 Christoph Paasch 2020-01-21  381  		if (data_len > 0)
cc7972ea193233 Christoph Paasch 2020-01-21  382  			*size = ALIGN(TCPOLEN_MPTCP_MPC_ACK_DATA, 4);
cc7972ea193233 Christoph Paasch 2020-01-21  383  		else
cec37a6e41aae7 Peter Krystad    2020-01-21  384  			*size = TCPOLEN_MPTCP_MPC_ACK;
cc7972ea193233 Christoph Paasch 2020-01-21  385  
cc7972ea193233 Christoph Paasch 2020-01-21  386  		pr_debug("subflow=%p, local_key=%llu, remote_key=%llu map_len=%d",
cc7972ea193233 Christoph Paasch 2020-01-21  387  			 subflow, subflow->local_key, subflow->remote_key,
cc7972ea193233 Christoph Paasch 2020-01-21  388  			 data_len);
cc7972ea193233 Christoph Paasch 2020-01-21  389  
cec37a6e41aae7 Peter Krystad    2020-01-21  390  		return true;
58d3e05e59695f Peter Krystad    2020-02-26 @391  	} else if (subflow->mp_join && !subflow->fourth_ack) {
58d3e05e59695f Peter Krystad    2020-02-26  392  		opts->suboptions = OPTION_MPTCP_MPJ_ACK;
58d3e05e59695f Peter Krystad    2020-02-26  393  		memcpy(opts->hmac, subflow->hmac, MPTCPOPT_HMAC_LEN);
58d3e05e59695f Peter Krystad    2020-02-26  394  		*size = TCPOLEN_MPTCP_MPJ_ACK;
58d3e05e59695f Peter Krystad    2020-02-26  395  		subflow->fourth_ack = 1;
58d3e05e59695f Peter Krystad    2020-02-26  396  		pr_debug("subflow=%p", subflow);
58d3e05e59695f Peter Krystad    2020-02-26  397  		return true;
cec37a6e41aae7 Peter Krystad    2020-01-21  398  	}
cec37a6e41aae7 Peter Krystad    2020-01-21  399  	return false;
cec37a6e41aae7 Peter Krystad    2020-01-21  400  }
cec37a6e41aae7 Peter Krystad    2020-01-21  401  

:::::: The code at line 391 was first introduced by commit
:::::: 58d3e05e59695fb74330e0a7dc80b67d3101f6e9 mptcp: Add handling of outgoing MP_JOIN requests

:::::: TO: Peter Krystad <peter.krystad(a)linux.intel.com>
:::::: CC: Matthieu Baerts <matthieu.baerts(a)tessares.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26576 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-11 21:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-11 21:41 [MPTCP] [mptcp:t/mptcp-Add-handling-of-outgoing-MP_JOIN-requests 1/4] net//mptcp/options.c:391:41: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack' kbuild test robot
2020-03-11 21:41 ` kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.