From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 4/6] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU
Date: Thu, 12 Mar 2020 06:30:00 +0800 [thread overview]
Message-ID: <202003120633.5qH6NDR4%lkp@intel.com> (raw)
In-Reply-To: <1583919461-27405-5-git-send-email-ego@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 14955 bytes --]
Hi "Gautham,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on linus/master v5.6-rc5 next-20200311]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Gautham-R-Shenoy/Track-and-expose-idle-PURR-and-SPURR-ticks/20200312-041724
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-fsp2_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/byteorder/big_endian.h:5,
from arch/powerpc/include/uapi/asm/byteorder.h:14,
from include/asm-generic/bitops/le.h:6,
from arch/powerpc/include/asm/bitops.h:250,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/rculist.h:10,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from arch/powerpc/kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h: In function 'update_idle_purr_accounting':
>> arch/powerpc/include/asm/idle.h:25:28: error: implicit declaration of function 'get_lppaca'; did you mean 'get_page'? [-Werror=implicit-function-declaration]
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:25:16: note: in expansion of macro 'be64_to_cpu'
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
arch/powerpc/include/asm/idle.h:25:40: error: invalid type argument of '->' (have 'int')
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:25:16: note: in expansion of macro 'be64_to_cpu'
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
In file included from arch/powerpc/kernel/sysfs.c:22:
arch/powerpc/include/asm/idle.h:27:14: error: invalid type argument of '->' (have 'int')
27 | get_lppaca()->wait_state_cycles = cpu_to_be64(wait_cycles);
| ^~
arch/powerpc/include/asm/idle.h: In function 'pseries_idle_prolog':
arch/powerpc/include/asm/idle.h:47:14: error: invalid type argument of '->' (have 'int')
47 | get_lppaca()->idle = 1;
| ^~
arch/powerpc/include/asm/idle.h: In function 'pseries_idle_epilog':
arch/powerpc/include/asm/idle.h:54:14: error: invalid type argument of '->' (have 'int')
54 | get_lppaca()->idle = 0;
| ^~
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from arch/powerpc/kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h: In function 'read_this_idle_purr':
arch/powerpc/include/asm/idle.h:66:27: error: invalid type argument of '->' (have 'int')
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
In file included from include/linux/byteorder/big_endian.h:5,
from arch/powerpc/include/uapi/asm/byteorder.h:14,
from include/asm-generic/bitops/le.h:6,
from arch/powerpc/include/asm/bitops.h:250,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/rculist.h:10,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from arch/powerpc/kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h:71:33: error: invalid type argument of '->' (have 'int')
71 | return be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:71:9: note: in expansion of macro 'be64_to_cpu'
71 | return be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
In file included from arch/powerpc/kernel/sysfs.c:22:
arch/powerpc/include/asm/idle.h: In function 'read_this_idle_spurr':
arch/powerpc/include/asm/idle.h:82:18: error: invalid type argument of '->' (have 'int')
82 | if (get_lppaca()->idle == 1) {
| ^~
In file included from arch/powerpc/kernel/sysfs.c:2:
At top level:
>> include/linux/device.h:126:26: error: 'dev_attr_idle_spurr' defined but not used [-Werror=unused-variable]
126 | struct device_attribute dev_attr_##_name = __ATTR(_name, _mode, _show, _store)
| ^~~~~~~~~
>> arch/powerpc/kernel/sysfs.c:798:8: note: in expansion of macro 'DEVICE_ATTR'
798 | static DEVICE_ATTR(idle_spurr, 0400, idle_spurr_show, NULL);
| ^~~~~~~~~~~
>> include/linux/device.h:126:26: error: 'dev_attr_idle_purr' defined but not used [-Werror=unused-variable]
126 | struct device_attribute dev_attr_##_name = __ATTR(_name, _mode, _show, _store)
| ^~~~~~~~~
arch/powerpc/kernel/sysfs.c:780:8: note: in expansion of macro 'DEVICE_ATTR'
780 | static DEVICE_ATTR(idle_purr, 0400, idle_purr_show, NULL);
| ^~~~~~~~~~~
cc1: all warnings being treated as errors
--
In file included from include/linux/byteorder/big_endian.h:5,
from arch/powerpc/include/uapi/asm/byteorder.h:14,
from include/asm-generic/bitops/le.h:6,
from arch/powerpc/include/asm/bitops.h:250,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/rculist.h:10,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from arch/powerpc//kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h: In function 'update_idle_purr_accounting':
>> arch/powerpc/include/asm/idle.h:25:28: error: implicit declaration of function 'get_lppaca'; did you mean 'get_page'? [-Werror=implicit-function-declaration]
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:25:16: note: in expansion of macro 'be64_to_cpu'
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
arch/powerpc/include/asm/idle.h:25:40: error: invalid type argument of '->' (have 'int')
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:25:16: note: in expansion of macro 'be64_to_cpu'
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
In file included from arch/powerpc//kernel/sysfs.c:22:
arch/powerpc/include/asm/idle.h:27:14: error: invalid type argument of '->' (have 'int')
27 | get_lppaca()->wait_state_cycles = cpu_to_be64(wait_cycles);
| ^~
arch/powerpc/include/asm/idle.h: In function 'pseries_idle_prolog':
arch/powerpc/include/asm/idle.h:47:14: error: invalid type argument of '->' (have 'int')
47 | get_lppaca()->idle = 1;
| ^~
arch/powerpc/include/asm/idle.h: In function 'pseries_idle_epilog':
arch/powerpc/include/asm/idle.h:54:14: error: invalid type argument of '->' (have 'int')
54 | get_lppaca()->idle = 0;
| ^~
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from arch/powerpc//kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h: In function 'read_this_idle_purr':
arch/powerpc/include/asm/idle.h:66:27: error: invalid type argument of '->' (have 'int')
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
In file included from include/linux/byteorder/big_endian.h:5,
from arch/powerpc/include/uapi/asm/byteorder.h:14,
from include/asm-generic/bitops/le.h:6,
from arch/powerpc/include/asm/bitops.h:250,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/linux/list.h:9,
from include/linux/rculist.h:10,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from arch/powerpc//kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h:71:33: error: invalid type argument of '->' (have 'int')
71 | return be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:71:9: note: in expansion of macro 'be64_to_cpu'
71 | return be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
In file included from arch/powerpc//kernel/sysfs.c:22:
arch/powerpc/include/asm/idle.h: In function 'read_this_idle_spurr':
arch/powerpc/include/asm/idle.h:82:18: error: invalid type argument of '->' (have 'int')
82 | if (get_lppaca()->idle == 1) {
| ^~
In file included from arch/powerpc//kernel/sysfs.c:2:
At top level:
>> include/linux/device.h:126:26: error: 'dev_attr_idle_spurr' defined but not used [-Werror=unused-variable]
126 | struct device_attribute dev_attr_##_name = __ATTR(_name, _mode, _show, _store)
| ^~~~~~~~~
arch/powerpc//kernel/sysfs.c:798:8: note: in expansion of macro 'DEVICE_ATTR'
798 | static DEVICE_ATTR(idle_spurr, 0400, idle_spurr_show, NULL);
| ^~~~~~~~~~~
>> include/linux/device.h:126:26: error: 'dev_attr_idle_purr' defined but not used [-Werror=unused-variable]
126 | struct device_attribute dev_attr_##_name = __ATTR(_name, _mode, _show, _store)
| ^~~~~~~~~
arch/powerpc//kernel/sysfs.c:780:8: note: in expansion of macro 'DEVICE_ATTR'
780 | static DEVICE_ATTR(idle_purr, 0400, idle_purr_show, NULL);
| ^~~~~~~~~~~
cc1: all warnings being treated as errors
vim +25 arch/powerpc/include/asm/idle.h
03d989e21479c7 Gautham R. Shenoy 2020-03-11 19
2452f5988544ea Gautham R. Shenoy 2020-03-11 20 static inline void update_idle_purr_accounting(void)
2452f5988544ea Gautham R. Shenoy 2020-03-11 21 {
2452f5988544ea Gautham R. Shenoy 2020-03-11 22 u64 wait_cycles;
2452f5988544ea Gautham R. Shenoy 2020-03-11 23 u64 in_purr = *this_cpu_ptr(&idle_entry_purr_snap);
2452f5988544ea Gautham R. Shenoy 2020-03-11 24
2452f5988544ea Gautham R. Shenoy 2020-03-11 @25 wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
2452f5988544ea Gautham R. Shenoy 2020-03-11 26 wait_cycles += mfspr(SPRN_PURR) - in_purr;
2452f5988544ea Gautham R. Shenoy 2020-03-11 27 get_lppaca()->wait_state_cycles = cpu_to_be64(wait_cycles);
2452f5988544ea Gautham R. Shenoy 2020-03-11 28 }
2452f5988544ea Gautham R. Shenoy 2020-03-11 29
:::::: The code at line 25 was first introduced by commit
:::::: 2452f5988544eaae0c9f73103c2f7083ef4e2fa7 powerpc/idle: Add accessor function to always read latest idle PURR
:::::: TO: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 15487 bytes --]
next prev parent reply other threads:[~2020-03-11 22:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 9:37 [PATCH v3 0/6] Track and expose idle PURR and SPURR ticks Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 1/6] powerpc: Move idle_loop_prolog()/epilog() functions to header file Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 2/6] powerpc/idle: Add accessor function to always read latest idle PURR Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 3/6] powerpc/pseries: Account for SPURR ticks on idle CPUs Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 4/6] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 22:30 ` kbuild test robot [this message]
2020-03-11 23:13 ` kbuild test robot
2020-03-11 23:48 ` kbuild test robot
2020-03-11 9:37 ` [PATCH v3 5/6] Documentation: Document sysfs interfaces purr, spurr, idle_purr, idle_spurr Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 6/6] pseries/sysfs: Minimise IPI noise while reading [idle_][s]purr Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 23:12 ` kbuild test robot
2020-03-12 0:09 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003120633.5qH6NDR4%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.