From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 4/6] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU
Date: Thu, 12 Mar 2020 07:48:26 +0800 [thread overview]
Message-ID: <202003120727.VhEZDIvo%lkp@intel.com> (raw)
In-Reply-To: <1583919461-27405-5-git-send-email-ego@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 15987 bytes --]
Hi "Gautham,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on linus/master scottwood/next v5.6-rc5 next-20200311]
[cannot apply to mpe/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Gautham-R-Shenoy/Track-and-expose-idle-PURR-and-SPURR-ticks/20200312-041724
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-randconfig-a001-20200311 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/byteorder/big_endian.h:5,
from arch/powerpc/include/uapi/asm/byteorder.h:14,
from include/asm-generic/bitops/le.h:6,
from arch/powerpc/include/asm/bitops.h:250,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/asm-generic/bug.h:19,
from arch/powerpc/include/asm/bug.h:109,
from include/linux/bug.h:5,
from arch/powerpc/include/asm/mmu.h:130,
from arch/powerpc/include/asm/paca.h:18,
from arch/powerpc/include/asm/current.h:13,
from include/linux/sched.h:12,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from arch/powerpc/kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h: In function 'update_idle_purr_accounting':
arch/powerpc/include/asm/idle.h:25:28: error: implicit declaration of function 'get_lppaca'; did you mean 'get_paca'? [-Werror=implicit-function-declaration]
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:25:16: note: in expansion of macro 'be64_to_cpu'
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
arch/powerpc/include/asm/idle.h:25:40: error: invalid type argument of '->' (have 'int')
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:25:16: note: in expansion of macro 'be64_to_cpu'
25 | wait_cycles = be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
In file included from arch/powerpc/kernel/sysfs.c:22:
arch/powerpc/include/asm/idle.h:27:14: error: invalid type argument of '->' (have 'int')
27 | get_lppaca()->wait_state_cycles = cpu_to_be64(wait_cycles);
| ^~
arch/powerpc/include/asm/idle.h: In function 'pseries_idle_prolog':
arch/powerpc/include/asm/idle.h:47:14: error: invalid type argument of '->' (have 'int')
47 | get_lppaca()->idle = 1;
| ^~
arch/powerpc/include/asm/idle.h: In function 'pseries_idle_epilog':
arch/powerpc/include/asm/idle.h:54:14: error: invalid type argument of '->' (have 'int')
54 | get_lppaca()->idle = 0;
| ^~
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from arch/powerpc/kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h: In function 'read_this_idle_purr':
arch/powerpc/include/asm/idle.h:66:27: error: invalid type argument of '->' (have 'int')
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
>> arch/powerpc/include/asm/idle.h:66:2: note: in expansion of macro 'if'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:48:24: note: in expansion of macro '__branch_check__'
48 | # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
>> arch/powerpc/include/asm/idle.h:66:6: note: in expansion of macro 'unlikely'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~~~~~~~
arch/powerpc/include/asm/idle.h:66:27: error: invalid type argument of '->' (have 'int')
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
>> arch/powerpc/include/asm/idle.h:66:2: note: in expansion of macro 'if'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:48:24: note: in expansion of macro '__branch_check__'
48 | # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
>> arch/powerpc/include/asm/idle.h:66:6: note: in expansion of macro 'unlikely'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~~~~~~~
arch/powerpc/include/asm/idle.h:66:27: error: invalid type argument of '->' (have 'int')
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
>> arch/powerpc/include/asm/idle.h:66:2: note: in expansion of macro 'if'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:48:24: note: in expansion of macro '__branch_check__'
48 | # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
>> arch/powerpc/include/asm/idle.h:66:6: note: in expansion of macro 'unlikely'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~~~~~~~
arch/powerpc/include/asm/idle.h:66:27: error: invalid type argument of '->' (have 'int')
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
>> arch/powerpc/include/asm/idle.h:66:2: note: in expansion of macro 'if'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:48:24: note: in expansion of macro '__branch_check__'
48 | # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
>> arch/powerpc/include/asm/idle.h:66:6: note: in expansion of macro 'unlikely'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~~~~~~~
arch/powerpc/include/asm/idle.h:66:27: error: invalid type argument of '->' (have 'int')
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value'
69 | (cond) ? \
| ^~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
>> arch/powerpc/include/asm/idle.h:66:2: note: in expansion of macro 'if'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:48:24: note: in expansion of macro '__branch_check__'
48 | # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
>> arch/powerpc/include/asm/idle.h:66:6: note: in expansion of macro 'unlikely'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~~~~~~~
arch/powerpc/include/asm/idle.h:66:27: error: invalid type argument of '->' (have 'int')
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value'
69 | (cond) ? \
| ^~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
>> arch/powerpc/include/asm/idle.h:66:2: note: in expansion of macro 'if'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~
include/linux/compiler.h:48:24: note: in expansion of macro '__branch_check__'
48 | # define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
| ^~~~~~~~~~~~~~~~
>> arch/powerpc/include/asm/idle.h:66:6: note: in expansion of macro 'unlikely'
66 | if (unlikely(get_lppaca()->idle == 1)) {
| ^~~~~~~~
In file included from include/linux/byteorder/big_endian.h:5,
from arch/powerpc/include/uapi/asm/byteorder.h:14,
from include/asm-generic/bitops/le.h:6,
from arch/powerpc/include/asm/bitops.h:250,
from include/linux/bitops.h:29,
from include/linux/kernel.h:12,
from include/asm-generic/bug.h:19,
from arch/powerpc/include/asm/bug.h:109,
from include/linux/bug.h:5,
from arch/powerpc/include/asm/mmu.h:130,
from arch/powerpc/include/asm/paca.h:18,
from arch/powerpc/include/asm/current.h:13,
from include/linux/sched.h:12,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from arch/powerpc/kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h:71:33: error: invalid type argument of '->' (have 'int')
71 | return be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~
include/uapi/linux/byteorder/big_endian.h:38:51: note: in definition of macro '__be64_to_cpu'
38 | #define __be64_to_cpu(x) ((__force __u64)(__be64)(x))
| ^
arch/powerpc/include/asm/idle.h:71:9: note: in expansion of macro 'be64_to_cpu'
71 | return be64_to_cpu(get_lppaca()->wait_state_cycles);
| ^~~~~~~~~~~
In file included from include/linux/dev_printk.h:14,
from include/linux/device.h:15,
from arch/powerpc/kernel/sysfs.c:2:
arch/powerpc/include/asm/idle.h: In function 'read_this_idle_spurr':
arch/powerpc/include/asm/idle.h:82:18: error: invalid type argument of '->' (have 'int')
82 | if (get_lppaca()->idle == 1) {
| ^~
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
arch/powerpc/include/asm/idle.h:82:2: note: in expansion of macro 'if'
82 | if (get_lppaca()->idle == 1) {
| ^~
arch/powerpc/include/asm/idle.h:82:18: error: invalid type argument of '->' (have 'int')
82 | if (get_lppaca()->idle == 1) {
| ^~
include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
arch/powerpc/include/asm/idle.h:82:2: note: in expansion of macro 'if'
82 | if (get_lppaca()->idle == 1) {
| ^~
arch/powerpc/include/asm/idle.h:82:18: error: invalid type argument of '->' (have 'int')
82 | if (get_lppaca()->idle == 1) {
| ^~
include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value'
69 | (cond) ? \
| ^~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
arch/powerpc/include/asm/idle.h:82:2: note: in expansion of macro 'if'
82 | if (get_lppaca()->idle == 1) {
| ^~
cc1: some warnings being treated as errors
vim +/if +66 arch/powerpc/include/asm/idle.h
2452f5988544ea Gautham R. Shenoy 2020-03-11 57
2452f5988544ea Gautham R. Shenoy 2020-03-11 58 static inline u64 read_this_idle_purr(void)
2452f5988544ea Gautham R. Shenoy 2020-03-11 59 {
2452f5988544ea Gautham R. Shenoy 2020-03-11 60 /*
2452f5988544ea Gautham R. Shenoy 2020-03-11 61 * If we are reading from an idle context, update the
2452f5988544ea Gautham R. Shenoy 2020-03-11 62 * idle-purr cycles corresponding to the last idle period.
2452f5988544ea Gautham R. Shenoy 2020-03-11 63 * Since the idle context is not yet over, take a fresh
2452f5988544ea Gautham R. Shenoy 2020-03-11 64 * snapshot of the idle-purr.
2452f5988544ea Gautham R. Shenoy 2020-03-11 65 */
2452f5988544ea Gautham R. Shenoy 2020-03-11 @66 if (unlikely(get_lppaca()->idle == 1)) {
2452f5988544ea Gautham R. Shenoy 2020-03-11 67 update_idle_purr_accounting();
2452f5988544ea Gautham R. Shenoy 2020-03-11 68 snapshot_purr_idle_entry();
2452f5988544ea Gautham R. Shenoy 2020-03-11 69 }
2452f5988544ea Gautham R. Shenoy 2020-03-11 70
2452f5988544ea Gautham R. Shenoy 2020-03-11 71 return be64_to_cpu(get_lppaca()->wait_state_cycles);
2452f5988544ea Gautham R. Shenoy 2020-03-11 72 }
03d989e21479c7 Gautham R. Shenoy 2020-03-11 73
:::::: The code at line 66 was first introduced by commit
:::::: 2452f5988544eaae0c9f73103c2f7083ef4e2fa7 powerpc/idle: Add accessor function to always read latest idle PURR
:::::: TO: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29200 bytes --]
next prev parent reply other threads:[~2020-03-11 23:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 9:37 [PATCH v3 0/6] Track and expose idle PURR and SPURR ticks Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 1/6] powerpc: Move idle_loop_prolog()/epilog() functions to header file Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 2/6] powerpc/idle: Add accessor function to always read latest idle PURR Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 3/6] powerpc/pseries: Account for SPURR ticks on idle CPUs Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 4/6] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 22:30 ` kbuild test robot
2020-03-11 23:13 ` kbuild test robot
2020-03-11 23:48 ` kbuild test robot [this message]
2020-03-11 9:37 ` [PATCH v3 5/6] Documentation: Document sysfs interfaces purr, spurr, idle_purr, idle_spurr Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 9:37 ` [PATCH v3 6/6] pseries/sysfs: Minimise IPI noise while reading [idle_][s]purr Gautham R. Shenoy
2020-03-11 9:37 ` Gautham R. Shenoy
2020-03-11 23:12 ` kbuild test robot
2020-03-12 0:09 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003120727.VhEZDIvo%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.