* [MPTCP] [mptcp:t/mptcp-allow-dumping-subflow-context-to-userspace 1/7] net/mptcp/diag.c:46:8: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack'
@ 2020-03-11 23:19 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-03-11 23:19 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 6719 bytes --]
Hi Matthieu,
First bad commit (maybe != root cause):
tree: https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-allow-dumping-subflow-context-to-userspace
head: bac8494b909da28ffdf11b03fa39d3c2a3a264ba
commit: 8b8c7c1c3ab581375074b0ce33fa7612fd4b947f [1/7] tgupdate: merge t/mptcp-allow-dumping-subflow-context-to-userspace base into t/mptcp-allow-dumping-subflow-context-to-userspace
config: openrisc-randconfig-a001-20200312 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8b8c7c1c3ab581375074b0ce33fa7612fd4b947f
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the mptcp/t/mptcp-allow-dumping-subflow-context-to-userspace HEAD bac8494b909da28ffdf11b03fa39d3c2a3a264ba builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
net/mptcp/diag.c: In function 'subflow_get_info':
>> net/mptcp/diag.c:46:8: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack'
46 | if (sf->fourth_ack)
| ^~
vim +46 net/mptcp/diag.c
5b04a26c66f161 Davide Caratti 2020-02-26 15
5b04a26c66f161 Davide Caratti 2020-02-26 16 static int subflow_get_info(const struct sock *sk, struct sk_buff *skb)
5b04a26c66f161 Davide Caratti 2020-02-26 17 {
5b04a26c66f161 Davide Caratti 2020-02-26 18 struct mptcp_subflow_context *sf;
5b04a26c66f161 Davide Caratti 2020-02-26 19 struct nlattr *start;
5b04a26c66f161 Davide Caratti 2020-02-26 20 u32 flags = 0;
5b04a26c66f161 Davide Caratti 2020-02-26 21 int err;
5b04a26c66f161 Davide Caratti 2020-02-26 22
5b04a26c66f161 Davide Caratti 2020-02-26 23 start = nla_nest_start_noflag(skb, INET_ULP_INFO_MPTCP);
5b04a26c66f161 Davide Caratti 2020-02-26 24 if (!start)
5b04a26c66f161 Davide Caratti 2020-02-26 25 return -EMSGSIZE;
5b04a26c66f161 Davide Caratti 2020-02-26 26
5b04a26c66f161 Davide Caratti 2020-02-26 27 rcu_read_lock();
5b04a26c66f161 Davide Caratti 2020-02-26 28 sf = rcu_dereference(inet_csk(sk)->icsk_ulp_data);
5b04a26c66f161 Davide Caratti 2020-02-26 29 if (!sf) {
5b04a26c66f161 Davide Caratti 2020-02-26 30 err = 0;
5b04a26c66f161 Davide Caratti 2020-02-26 31 goto nla_failure;
5b04a26c66f161 Davide Caratti 2020-02-26 32 }
5b04a26c66f161 Davide Caratti 2020-02-26 33
5b04a26c66f161 Davide Caratti 2020-02-26 34 if (sf->mp_capable)
5b04a26c66f161 Davide Caratti 2020-02-26 35 flags |= MPTCP_SUBFLOW_FLAG_MCAP_REM;
5b04a26c66f161 Davide Caratti 2020-02-26 36 if (sf->request_mptcp)
5b04a26c66f161 Davide Caratti 2020-02-26 37 flags |= MPTCP_SUBFLOW_FLAG_MCAP_LOC;
5b04a26c66f161 Davide Caratti 2020-02-26 38 if (sf->mp_join)
5b04a26c66f161 Davide Caratti 2020-02-26 39 flags |= MPTCP_SUBFLOW_FLAG_JOIN_REM;
5b04a26c66f161 Davide Caratti 2020-02-26 40 if (sf->request_join)
5b04a26c66f161 Davide Caratti 2020-02-26 41 flags |= MPTCP_SUBFLOW_FLAG_JOIN_LOC;
5b04a26c66f161 Davide Caratti 2020-02-26 42 if (sf->backup)
5b04a26c66f161 Davide Caratti 2020-02-26 43 flags |= MPTCP_SUBFLOW_FLAG_BKUP_REM;
5b04a26c66f161 Davide Caratti 2020-02-26 44 if (sf->request_bkup)
5b04a26c66f161 Davide Caratti 2020-02-26 45 flags |= MPTCP_SUBFLOW_FLAG_BKUP_LOC;
5b04a26c66f161 Davide Caratti 2020-02-26 @46 if (sf->fourth_ack)
5b04a26c66f161 Davide Caratti 2020-02-26 47 flags |= MPTCP_SUBFLOW_FLAG_4THACK;
5b04a26c66f161 Davide Caratti 2020-02-26 48 if (sf->conn_finished)
5b04a26c66f161 Davide Caratti 2020-02-26 49 flags |= MPTCP_SUBFLOW_FLAG_CONNECTED;
5b04a26c66f161 Davide Caratti 2020-02-26 50 if (sf->map_valid)
5b04a26c66f161 Davide Caratti 2020-02-26 51 flags |= MPTCP_SUBFLOW_FLAG_MAPVALID;
5b04a26c66f161 Davide Caratti 2020-02-26 52
5b04a26c66f161 Davide Caratti 2020-02-26 53 if (nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_TOKEN_REM, sf->remote_token) ||
5b04a26c66f161 Davide Caratti 2020-02-26 54 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_TOKEN_LOC, sf->token) ||
5b04a26c66f161 Davide Caratti 2020-02-26 55 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_RELWRITE_SEQ,
5b04a26c66f161 Davide Caratti 2020-02-26 56 sf->rel_write_seq) ||
5b04a26c66f161 Davide Caratti 2020-02-26 57 nla_put_u64_64bit(skb, MPTCP_SUBFLOW_ATTR_MAP_SEQ, sf->map_seq,
5b04a26c66f161 Davide Caratti 2020-02-26 58 MPTCP_SUBFLOW_ATTR_PAD) ||
5b04a26c66f161 Davide Caratti 2020-02-26 59 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_MAP_SFSEQ,
5b04a26c66f161 Davide Caratti 2020-02-26 60 sf->map_subflow_seq) ||
5b04a26c66f161 Davide Caratti 2020-02-26 61 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_SSN_OFFSET, sf->ssn_offset) ||
5b04a26c66f161 Davide Caratti 2020-02-26 62 nla_put_u16(skb, MPTCP_SUBFLOW_ATTR_MAP_DATALEN,
5b04a26c66f161 Davide Caratti 2020-02-26 63 sf->map_data_len) ||
5b04a26c66f161 Davide Caratti 2020-02-26 64 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_FLAGS, flags) ||
5b04a26c66f161 Davide Caratti 2020-02-26 65 nla_put_u8(skb, MPTCP_SUBFLOW_ATTR_ID_REM, sf->remote_id) ||
5b04a26c66f161 Davide Caratti 2020-02-26 66 nla_put_u8(skb, MPTCP_SUBFLOW_ATTR_ID_LOC, sf->local_id)) {
5b04a26c66f161 Davide Caratti 2020-02-26 67 err = -EMSGSIZE;
5b04a26c66f161 Davide Caratti 2020-02-26 68 goto nla_failure;
5b04a26c66f161 Davide Caratti 2020-02-26 69 }
5b04a26c66f161 Davide Caratti 2020-02-26 70
5b04a26c66f161 Davide Caratti 2020-02-26 71 rcu_read_unlock();
5b04a26c66f161 Davide Caratti 2020-02-26 72 nla_nest_end(skb, start);
5b04a26c66f161 Davide Caratti 2020-02-26 73 return 0;
5b04a26c66f161 Davide Caratti 2020-02-26 74
5b04a26c66f161 Davide Caratti 2020-02-26 75 nla_failure:
5b04a26c66f161 Davide Caratti 2020-02-26 76 rcu_read_unlock();
5b04a26c66f161 Davide Caratti 2020-02-26 77 nla_nest_cancel(skb, start);
5b04a26c66f161 Davide Caratti 2020-02-26 78 return err;
5b04a26c66f161 Davide Caratti 2020-02-26 79 }
5b04a26c66f161 Davide Caratti 2020-02-26 80
:::::: The code at line 46 was first introduced by commit
:::::: 5b04a26c66f161428203e8e504af59dd05ed2a8d mptcp: allow dumping subflow context to userspace
:::::: TO: Davide Caratti <dcaratti(a)redhat.com>
:::::: CC: Matthieu Baerts <matthieu.baerts(a)tessares.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26576 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* [mptcp:t/mptcp-allow-dumping-subflow-context-to-userspace 1/7] net/mptcp/diag.c:46:8: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack'
@ 2020-03-11 23:19 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-03-11 23:19 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 6713 bytes --]
Hi Matthieu,
First bad commit (maybe != root cause):
tree: https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-allow-dumping-subflow-context-to-userspace
head: bac8494b909da28ffdf11b03fa39d3c2a3a264ba
commit: 8b8c7c1c3ab581375074b0ce33fa7612fd4b947f [1/7] tgupdate: merge t/mptcp-allow-dumping-subflow-context-to-userspace base into t/mptcp-allow-dumping-subflow-context-to-userspace
config: openrisc-randconfig-a001-20200312 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8b8c7c1c3ab581375074b0ce33fa7612fd4b947f
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Note: the mptcp/t/mptcp-allow-dumping-subflow-context-to-userspace HEAD bac8494b909da28ffdf11b03fa39d3c2a3a264ba builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
net/mptcp/diag.c: In function 'subflow_get_info':
>> net/mptcp/diag.c:46:8: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack'
46 | if (sf->fourth_ack)
| ^~
vim +46 net/mptcp/diag.c
5b04a26c66f161 Davide Caratti 2020-02-26 15
5b04a26c66f161 Davide Caratti 2020-02-26 16 static int subflow_get_info(const struct sock *sk, struct sk_buff *skb)
5b04a26c66f161 Davide Caratti 2020-02-26 17 {
5b04a26c66f161 Davide Caratti 2020-02-26 18 struct mptcp_subflow_context *sf;
5b04a26c66f161 Davide Caratti 2020-02-26 19 struct nlattr *start;
5b04a26c66f161 Davide Caratti 2020-02-26 20 u32 flags = 0;
5b04a26c66f161 Davide Caratti 2020-02-26 21 int err;
5b04a26c66f161 Davide Caratti 2020-02-26 22
5b04a26c66f161 Davide Caratti 2020-02-26 23 start = nla_nest_start_noflag(skb, INET_ULP_INFO_MPTCP);
5b04a26c66f161 Davide Caratti 2020-02-26 24 if (!start)
5b04a26c66f161 Davide Caratti 2020-02-26 25 return -EMSGSIZE;
5b04a26c66f161 Davide Caratti 2020-02-26 26
5b04a26c66f161 Davide Caratti 2020-02-26 27 rcu_read_lock();
5b04a26c66f161 Davide Caratti 2020-02-26 28 sf = rcu_dereference(inet_csk(sk)->icsk_ulp_data);
5b04a26c66f161 Davide Caratti 2020-02-26 29 if (!sf) {
5b04a26c66f161 Davide Caratti 2020-02-26 30 err = 0;
5b04a26c66f161 Davide Caratti 2020-02-26 31 goto nla_failure;
5b04a26c66f161 Davide Caratti 2020-02-26 32 }
5b04a26c66f161 Davide Caratti 2020-02-26 33
5b04a26c66f161 Davide Caratti 2020-02-26 34 if (sf->mp_capable)
5b04a26c66f161 Davide Caratti 2020-02-26 35 flags |= MPTCP_SUBFLOW_FLAG_MCAP_REM;
5b04a26c66f161 Davide Caratti 2020-02-26 36 if (sf->request_mptcp)
5b04a26c66f161 Davide Caratti 2020-02-26 37 flags |= MPTCP_SUBFLOW_FLAG_MCAP_LOC;
5b04a26c66f161 Davide Caratti 2020-02-26 38 if (sf->mp_join)
5b04a26c66f161 Davide Caratti 2020-02-26 39 flags |= MPTCP_SUBFLOW_FLAG_JOIN_REM;
5b04a26c66f161 Davide Caratti 2020-02-26 40 if (sf->request_join)
5b04a26c66f161 Davide Caratti 2020-02-26 41 flags |= MPTCP_SUBFLOW_FLAG_JOIN_LOC;
5b04a26c66f161 Davide Caratti 2020-02-26 42 if (sf->backup)
5b04a26c66f161 Davide Caratti 2020-02-26 43 flags |= MPTCP_SUBFLOW_FLAG_BKUP_REM;
5b04a26c66f161 Davide Caratti 2020-02-26 44 if (sf->request_bkup)
5b04a26c66f161 Davide Caratti 2020-02-26 45 flags |= MPTCP_SUBFLOW_FLAG_BKUP_LOC;
5b04a26c66f161 Davide Caratti 2020-02-26 @46 if (sf->fourth_ack)
5b04a26c66f161 Davide Caratti 2020-02-26 47 flags |= MPTCP_SUBFLOW_FLAG_4THACK;
5b04a26c66f161 Davide Caratti 2020-02-26 48 if (sf->conn_finished)
5b04a26c66f161 Davide Caratti 2020-02-26 49 flags |= MPTCP_SUBFLOW_FLAG_CONNECTED;
5b04a26c66f161 Davide Caratti 2020-02-26 50 if (sf->map_valid)
5b04a26c66f161 Davide Caratti 2020-02-26 51 flags |= MPTCP_SUBFLOW_FLAG_MAPVALID;
5b04a26c66f161 Davide Caratti 2020-02-26 52
5b04a26c66f161 Davide Caratti 2020-02-26 53 if (nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_TOKEN_REM, sf->remote_token) ||
5b04a26c66f161 Davide Caratti 2020-02-26 54 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_TOKEN_LOC, sf->token) ||
5b04a26c66f161 Davide Caratti 2020-02-26 55 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_RELWRITE_SEQ,
5b04a26c66f161 Davide Caratti 2020-02-26 56 sf->rel_write_seq) ||
5b04a26c66f161 Davide Caratti 2020-02-26 57 nla_put_u64_64bit(skb, MPTCP_SUBFLOW_ATTR_MAP_SEQ, sf->map_seq,
5b04a26c66f161 Davide Caratti 2020-02-26 58 MPTCP_SUBFLOW_ATTR_PAD) ||
5b04a26c66f161 Davide Caratti 2020-02-26 59 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_MAP_SFSEQ,
5b04a26c66f161 Davide Caratti 2020-02-26 60 sf->map_subflow_seq) ||
5b04a26c66f161 Davide Caratti 2020-02-26 61 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_SSN_OFFSET, sf->ssn_offset) ||
5b04a26c66f161 Davide Caratti 2020-02-26 62 nla_put_u16(skb, MPTCP_SUBFLOW_ATTR_MAP_DATALEN,
5b04a26c66f161 Davide Caratti 2020-02-26 63 sf->map_data_len) ||
5b04a26c66f161 Davide Caratti 2020-02-26 64 nla_put_u32(skb, MPTCP_SUBFLOW_ATTR_FLAGS, flags) ||
5b04a26c66f161 Davide Caratti 2020-02-26 65 nla_put_u8(skb, MPTCP_SUBFLOW_ATTR_ID_REM, sf->remote_id) ||
5b04a26c66f161 Davide Caratti 2020-02-26 66 nla_put_u8(skb, MPTCP_SUBFLOW_ATTR_ID_LOC, sf->local_id)) {
5b04a26c66f161 Davide Caratti 2020-02-26 67 err = -EMSGSIZE;
5b04a26c66f161 Davide Caratti 2020-02-26 68 goto nla_failure;
5b04a26c66f161 Davide Caratti 2020-02-26 69 }
5b04a26c66f161 Davide Caratti 2020-02-26 70
5b04a26c66f161 Davide Caratti 2020-02-26 71 rcu_read_unlock();
5b04a26c66f161 Davide Caratti 2020-02-26 72 nla_nest_end(skb, start);
5b04a26c66f161 Davide Caratti 2020-02-26 73 return 0;
5b04a26c66f161 Davide Caratti 2020-02-26 74
5b04a26c66f161 Davide Caratti 2020-02-26 75 nla_failure:
5b04a26c66f161 Davide Caratti 2020-02-26 76 rcu_read_unlock();
5b04a26c66f161 Davide Caratti 2020-02-26 77 nla_nest_cancel(skb, start);
5b04a26c66f161 Davide Caratti 2020-02-26 78 return err;
5b04a26c66f161 Davide Caratti 2020-02-26 79 }
5b04a26c66f161 Davide Caratti 2020-02-26 80
:::::: The code at line 46 was first introduced by commit
:::::: 5b04a26c66f161428203e8e504af59dd05ed2a8d mptcp: allow dumping subflow context to userspace
:::::: TO: Davide Caratti <dcaratti@redhat.com>
:::::: CC: Matthieu Baerts <matthieu.baerts@tessares.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26576 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-11 23:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-11 23:19 [MPTCP] [mptcp:t/mptcp-allow-dumping-subflow-context-to-userspace 1/7] net/mptcp/diag.c:46:8: error: 'struct mptcp_subflow_context' has no member named 'fourth_ack' kbuild test robot
2020-03-11 23:19 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.