[PATCH] staging: fbtft: Reformat lines over 80 characters

[PATCH] staging: fbtft: Reformat lines over 80 characters

[Deepak R Varma]

Multiple macro definitions crossings 80 character line length nakes it
hard to understand. Reformating the these lines makes the code more
readable and easy to understand. Issue flagged by checkpatch script.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
 drivers/staging/fbtft/fbtft.h | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 5f782da51959..81da30f4062e 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -348,9 +348,17 @@ module_exit(fbtft_driver_module_exit);
 
 /* shorthand debug levels */
 #define DEBUG_LEVEL_1	DEBUG_REQUEST_GPIOS
-#define DEBUG_LEVEL_2	(DEBUG_LEVEL_1 | DEBUG_DRIVER_INIT_FUNCTIONS | DEBUG_TIME_FIRST_UPDATE)
-#define DEBUG_LEVEL_3	(DEBUG_LEVEL_2 | DEBUG_RESET | DEBUG_INIT_DISPLAY | DEBUG_BLANK | DEBUG_REQUEST_GPIOS | DEBUG_FREE_GPIOS | DEBUG_VERIFY_GPIOS | DEBUG_BACKLIGHT | DEBUG_SYSFS)
-#define DEBUG_LEVEL_4	(DEBUG_LEVEL_2 | DEBUG_FB_READ | DEBUG_FB_WRITE | DEBUG_FB_FILLRECT | DEBUG_FB_COPYAREA | DEBUG_FB_IMAGEBLIT | DEBUG_FB_BLANK)
+#define DEBUG_LEVEL_2	(DEBUG_LEVEL_1 | DEBUG_DRIVER_INIT_FUNCTIONS        \
+				       | DEBUG_TIME_FIRST_UPDATE)
+#define DEBUG_LEVEL_3	(DEBUG_LEVEL_2 | DEBUG_RESET | DEBUG_INIT_DISPLAY   \
+				       | DEBUG_BLANK | DEBUG_REQUEST_GPIOS  \
+				       | DEBUG_FREE_GPIOS                   \
+				       | DEBUG_VERIFY_GPIOS                 \
+				       | DEBUG_BACKLIGHT | DEBUG_SYSFS)
+#define DEBUG_LEVEL_4	(DEBUG_LEVEL_2 | DEBUG_FB_READ | DEBUG_FB_WRITE     \
+				       | DEBUG_FB_FILLRECT                  \
+				       | DEBUG_FB_COPYAREA                  \
+				       | DEBUG_FB_IMAGEBLIT | DEBUG_FB_BLANK)
 #define DEBUG_LEVEL_5	(DEBUG_LEVEL_3 | DEBUG_UPDATE_DISPLAY)
 #define DEBUG_LEVEL_6	(DEBUG_LEVEL_4 | DEBUG_LEVEL_5)
 #define DEBUG_LEVEL_7	0xFFFFFFFF
-- 
2.17.1

Re: [PATCH] staging: fbtft: Reformat lines over 80 characters

[Greg KH]

On Thu, Mar 12, 2020 at 02:59:43AM +0530, Deepak R Varma wrote:
> Multiple macro definitions crossings 80 character line length nakes it
> hard to understand. Reformating the these lines makes the code more
> readable and easy to understand. Issue flagged by checkpatch script.
> 
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft.h | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)

You sent 2 patches with almost identical subject lines, yet they did
different things to different files.

Please fix up and make them more unique and resend both of them.

thanks,

greg k-h

Re: [PATCH] staging: fbtft: Reformat lines over 80 characters

[DEEPAK VARMA]

On Thu, Mar 12, 2020 at 09:19:36AM +0100, Greg KH wrote:
> On Thu, Mar 12, 2020 at 02:59:43AM +0530, Deepak R Varma wrote:
> > Multiple macro definitions crossings 80 character line length nakes it
> > hard to understand. Reformating the these lines makes the code more
> > readable and easy to understand. Issue flagged by checkpatch script.
> > 
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> > ---
> >  drivers/staging/fbtft/fbtft.h | 14 +++++++++++---
> >  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> You sent 2 patches with almost identical subject lines, yet they did
> different things to different files.
> 
> Please fix up and make them more unique and resend both of them.
> 
> thanks,
> 
> greg k-h
Hello Greg,

Sure, will do. Thank you.

Deepak.