From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: R Veera Kumar <vkor@vkten.in>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH] staging: rtl8712: Fix for long lines in Kconfig help
Date: Thu, 12 Mar 2020 13:14:49 +0100 [thread overview]
Message-ID: <20200312121449.GA260420@kroah.com> (raw)
In-Reply-To: <20200312120817.GB5010@tulip.local>
On Thu, Mar 12, 2020 at 05:38:18PM +0530, R Veera Kumar wrote:
> On Thu, Mar 12, 2020 at 12:54:09PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 12, 2020 at 01:40:55PM +0530, R Veera Kumar wrote:
> > > Fixes two long line in Kconfig help.
> > > Found using checkpatch.pl
> > >
> > > Signed-off-by: R Veera Kumar <vkor@vkten.in>
> > > ---
> > > drivers/staging/rtl8712/Kconfig | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
> > > index b6dcda77db1f..678bbeace823 100644
> > > --- a/drivers/staging/rtl8712/Kconfig
> > > +++ b/drivers/staging/rtl8712/Kconfig
> > > @@ -6,13 +6,16 @@ config R8712U
> > > select WEXT_PRIV
> > > select FW_LOADER
> > > help
> > > - This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> > > + This option adds the Realtek RTL8712 USB device such as the
> > > + D-Link DWA-130.
> > > +
> > > If built as a module, it will be called r8712u.
> > >
> > > config R8712_TX_AGGR
> > > bool "Realtek RTL8712U Transmit Aggregation code"
> > > depends on R8712U && BROKEN
> > > help
> > > - This option provides transmit aggregation for the Realtek RTL8712 USB device.
> > > + This option provides transmit aggregation for the
> > > + Realtek RTL8712 USB device.
> > >
> >
> > Why did you pick two different line lengths to wrap at for these two
> > options?
> >
> > Please be consistent.
> >
>
> So should I resend the patch.
I can not take it as-is, so why wouldn't you fix it up and resend it?
:)
thanks,
greg k-h
prev parent reply other threads:[~2020-03-12 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 8:10 [PATCH] staging: rtl8712: Fix for long lines in Kconfig help R Veera Kumar
2020-03-12 11:54 ` Greg Kroah-Hartman
2020-03-12 12:08 ` R Veera Kumar
2020-03-12 12:14 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312121449.GA260420@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=vkor@vkten.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.