* [PATCH] staging: rtl8712: Fix for long lines in Kconfig help
@ 2020-03-12 8:10 R Veera Kumar
2020-03-12 11:54 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: R Veera Kumar @ 2020-03-12 8:10 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel,
outreachy-kernel
Fixes two long line in Kconfig help.
Found using checkpatch.pl
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
drivers/staging/rtl8712/Kconfig | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
index b6dcda77db1f..678bbeace823 100644
--- a/drivers/staging/rtl8712/Kconfig
+++ b/drivers/staging/rtl8712/Kconfig
@@ -6,13 +6,16 @@ config R8712U
select WEXT_PRIV
select FW_LOADER
help
- This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
+ This option adds the Realtek RTL8712 USB device such as the
+ D-Link DWA-130.
+
If built as a module, it will be called r8712u.
config R8712_TX_AGGR
bool "Realtek RTL8712U Transmit Aggregation code"
depends on R8712U && BROKEN
help
- This option provides transmit aggregation for the Realtek RTL8712 USB device.
+ This option provides transmit aggregation for the
+ Realtek RTL8712 USB device.
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: Fix for long lines in Kconfig help
2020-03-12 8:10 [PATCH] staging: rtl8712: Fix for long lines in Kconfig help R Veera Kumar
@ 2020-03-12 11:54 ` Greg Kroah-Hartman
2020-03-12 12:08 ` R Veera Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-12 11:54 UTC (permalink / raw)
To: R Veera Kumar; +Cc: Larry Finger, Florian Schilhabel, outreachy-kernel
On Thu, Mar 12, 2020 at 01:40:55PM +0530, R Veera Kumar wrote:
> Fixes two long line in Kconfig help.
> Found using checkpatch.pl
>
> Signed-off-by: R Veera Kumar <vkor@vkten.in>
> ---
> drivers/staging/rtl8712/Kconfig | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
> index b6dcda77db1f..678bbeace823 100644
> --- a/drivers/staging/rtl8712/Kconfig
> +++ b/drivers/staging/rtl8712/Kconfig
> @@ -6,13 +6,16 @@ config R8712U
> select WEXT_PRIV
> select FW_LOADER
> help
> - This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> + This option adds the Realtek RTL8712 USB device such as the
> + D-Link DWA-130.
> +
> If built as a module, it will be called r8712u.
>
> config R8712_TX_AGGR
> bool "Realtek RTL8712U Transmit Aggregation code"
> depends on R8712U && BROKEN
> help
> - This option provides transmit aggregation for the Realtek RTL8712 USB device.
> + This option provides transmit aggregation for the
> + Realtek RTL8712 USB device.
>
Why did you pick two different line lengths to wrap at for these two
options?
Please be consistent.
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: Fix for long lines in Kconfig help
2020-03-12 11:54 ` Greg Kroah-Hartman
@ 2020-03-12 12:08 ` R Veera Kumar
2020-03-12 12:14 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: R Veera Kumar @ 2020-03-12 12:08 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: outreachy-kernel
On Thu, Mar 12, 2020 at 12:54:09PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 12, 2020 at 01:40:55PM +0530, R Veera Kumar wrote:
> > Fixes two long line in Kconfig help.
> > Found using checkpatch.pl
> >
> > Signed-off-by: R Veera Kumar <vkor@vkten.in>
> > ---
> > drivers/staging/rtl8712/Kconfig | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
> > index b6dcda77db1f..678bbeace823 100644
> > --- a/drivers/staging/rtl8712/Kconfig
> > +++ b/drivers/staging/rtl8712/Kconfig
> > @@ -6,13 +6,16 @@ config R8712U
> > select WEXT_PRIV
> > select FW_LOADER
> > help
> > - This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> > + This option adds the Realtek RTL8712 USB device such as the
> > + D-Link DWA-130.
> > +
> > If built as a module, it will be called r8712u.
> >
> > config R8712_TX_AGGR
> > bool "Realtek RTL8712U Transmit Aggregation code"
> > depends on R8712U && BROKEN
> > help
> > - This option provides transmit aggregation for the Realtek RTL8712 USB device.
> > + This option provides transmit aggregation for the
> > + Realtek RTL8712 USB device.
> >
>
> Why did you pick two different line lengths to wrap at for these two
> options?
>
> Please be consistent.
>
So should I resend the patch.
> greg k-h
Regards,
Veera
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8712: Fix for long lines in Kconfig help
2020-03-12 12:08 ` R Veera Kumar
@ 2020-03-12 12:14 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-12 12:14 UTC (permalink / raw)
To: R Veera Kumar; +Cc: outreachy-kernel
On Thu, Mar 12, 2020 at 05:38:18PM +0530, R Veera Kumar wrote:
> On Thu, Mar 12, 2020 at 12:54:09PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 12, 2020 at 01:40:55PM +0530, R Veera Kumar wrote:
> > > Fixes two long line in Kconfig help.
> > > Found using checkpatch.pl
> > >
> > > Signed-off-by: R Veera Kumar <vkor@vkten.in>
> > > ---
> > > drivers/staging/rtl8712/Kconfig | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
> > > index b6dcda77db1f..678bbeace823 100644
> > > --- a/drivers/staging/rtl8712/Kconfig
> > > +++ b/drivers/staging/rtl8712/Kconfig
> > > @@ -6,13 +6,16 @@ config R8712U
> > > select WEXT_PRIV
> > > select FW_LOADER
> > > help
> > > - This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> > > + This option adds the Realtek RTL8712 USB device such as the
> > > + D-Link DWA-130.
> > > +
> > > If built as a module, it will be called r8712u.
> > >
> > > config R8712_TX_AGGR
> > > bool "Realtek RTL8712U Transmit Aggregation code"
> > > depends on R8712U && BROKEN
> > > help
> > > - This option provides transmit aggregation for the Realtek RTL8712 USB device.
> > > + This option provides transmit aggregation for the
> > > + Realtek RTL8712 USB device.
> > >
> >
> > Why did you pick two different line lengths to wrap at for these two
> > options?
> >
> > Please be consistent.
> >
>
> So should I resend the patch.
I can not take it as-is, so why wouldn't you fix it up and resend it?
:)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-12 12:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-12 8:10 [PATCH] staging: rtl8712: Fix for long lines in Kconfig help R Veera Kumar
2020-03-12 11:54 ` Greg Kroah-Hartman
2020-03-12 12:08 ` R Veera Kumar
2020-03-12 12:14 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.