* [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis
@ 2020-03-12 14:27 Enrique Vargas
2020-03-12 14:38 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Enrique Vargas @ 2020-03-12 14:27 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman, linux-iio, outreachy-kernel
Eliminate WARNING found with checkpatch.pl for argument split in two
lines not matching coding conventions identation.
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/staging/iio/adc/ad7192.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index 51b1cd3ad1de..5f65d084e320 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev,
}
static void ad7192_get_available_filter_freq(struct ad7192_state *st,
- int *freq)
+ int *freq)
{
unsigned int fadc;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis
2020-03-12 14:27 [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis Enrique Vargas
@ 2020-03-12 14:38 ` Julia Lawall
2020-03-12 14:40 ` Jesus Enrique Vargas Medrano
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2020-03-12 14:38 UTC (permalink / raw)
To: Enrique Vargas
Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman, linux-iio, outreachy-kernel
On Thu, 12 Mar 2020, Enrique Vargas wrote:
> Eliminate WARNING found with checkpatch.pl for argument split in two
> lines not matching coding conventions identation.
The message seems a bit obscure. There is no argument that is split in
two lines, although it is the case that the argument list is split in two
lines.
For the subject line, maybe "reduce parameter indentation"
And then for the log message:
"Align function parameter with the right side of the open parenthesis
starting the parameter list, to follow kernel coding style. Problem found
using checkpatch."
julia
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 51b1cd3ad1de..5f65d084e320 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev,
> }
>
> static void ad7192_get_available_filter_freq(struct ad7192_state *st,
> - int *freq)
> + int *freq)
> {
> unsigned int fadc;
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200312142721.GA2748%40evX1.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis
2020-03-12 14:38 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-12 14:40 ` Jesus Enrique Vargas Medrano
0 siblings, 0 replies; 3+ messages in thread
From: Jesus Enrique Vargas Medrano @ 2020-03-12 14:40 UTC (permalink / raw)
To: Julia Lawall
Cc: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
Greg Kroah-Hartman, linux-iio, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]
Thanks for the feedback Julia, will include your comments and resend.
On Thu, Mar 12, 2020 at 8:38 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
> On Thu, 12 Mar 2020, Enrique Vargas wrote:
>
> > Eliminate WARNING found with checkpatch.pl for argument split in two
> > lines not matching coding conventions identation.
>
> The message seems a bit obscure. There is no argument that is split in
> two lines, although it is the case that the argument list is split in two
> lines.
>
> For the subject line, maybe "reduce parameter indentation"
>
> And then for the log message:
>
> "Align function parameter with the right side of the open parenthesis
> starting the parameter list, to follow kernel coding style. Problem found
> using checkpatch."
>
> julia
>
>
> >
> > Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> > ---
> > drivers/staging/iio/adc/ad7192.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/iio/adc/ad7192.c
> b/drivers/staging/iio/adc/ad7192.c
> > index 51b1cd3ad1de..5f65d084e320 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -477,7 +477,7 @@ static ssize_t ad7192_set(struct device *dev,
> > }
> >
> > static void ad7192_get_available_filter_freq(struct ad7192_state *st,
> > - int *freq)
> > + int *freq)
> > {
> > unsigned int fadc;
> >
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20200312142721.GA2748%40evX1
> .
> >
>
--
J Enrique
[-- Attachment #2: Type: text/html, Size: 2945 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-12 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-12 14:27 [PATCH] Staging: iio: adc: align multi-line function argument with open parenthesis Enrique Vargas
2020-03-12 14:38 ` [Outreachy kernel] " Julia Lawall
2020-03-12 14:40 ` Jesus Enrique Vargas Medrano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.