From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>,
Michal Hocko <mhocko@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Pekka Enberg <penberg@kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
Christopher Lameter <cl@linux.com>,
linuxppc-dev@lists.ozlabs.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9
Date: Fri, 13 Mar 2020 16:42:46 +0530 [thread overview]
Message-ID: <20200313111246.GB25144@linux.vnet.ibm.com> (raw)
In-Reply-To: <875zf8y1i1.fsf@mpe.ellerman.id.au>
* Michael Ellerman <mpe@ellerman.id.au> [2020-03-13 21:48:06]:
> Sachin Sant <sachinp@linux.vnet.ibm.com> writes:
> >> The patch below might work. Sachin can you test this? I tried faking up
> >> a system with a memoryless node zero but couldn't get it to even start
> >> booting.
> >>
> > The patch did not help. The kernel crashed during
> > the boot with the same call trace.
> >
> > BUG_ON() introduced with the patch was not triggered.
>
> OK, that's weird.
>
> I eventually managed to get a memoryless node going in sim, and it
> appears to work there.
>
> eg in dmesg:
>
> [ 0.000000][ T0] numa: NODE_DATA [mem 0x2000fffa2f80-0x2000fffa7fff]
> [ 0.000000][ T0] numa: NODE_DATA(0) on node 1
> [ 0.000000][ T0] numa: NODE_DATA [mem 0x2000fff9df00-0x2000fffa2f7f]
> ...
> [ 0.000000][ T0] Early memory node ranges
> [ 0.000000][ T0] node 1: [mem 0x0000000000000000-0x00000000ffffffff]
> [ 0.000000][ T0] node 1: [mem 0x0000200000000000-0x00002000ffffffff]
> [ 0.000000][ T0] Could not find start_pfn for node 0
> [ 0.000000][ T0] Initmem setup node 0 [mem 0x0000000000000000-0x0000000000000000]
> [ 0.000000][ T0] On node 0 totalpages: 0
> [ 0.000000][ T0] Initmem setup node 1 [mem 0x0000000000000000-0x00002000ffffffff]
> [ 0.000000][ T0] On node 1 totalpages: 131072
>
> # dmesg | grep set_numa
> [ 0.000000][ T0] set_numa_mem: mem node for 0 = 1
> [ 0.005654][ T0] set_numa_mem: mem node for 1 = 1
>
> So is the problem more than just node zero having no memory?
>
The problem would happen with possible nodes which are not yet present. i.e
no cpus, no memory attached to those nodes.
Please look at
http://lore.kernel.org/lkml/20200312131438.GB3277@linux.vnet.ibm.com/t/#u
for more details.
The summary being: pgdat/Node_Data for such nodes is not allocated. Hence
the node_present_pages(nid) called where nid is a possible but not yet
present node fails. Currently node_present_pages(nid) and node_to_mem_node
don't seem to be equipped to handle possible but not present nodes.
> cheers
--
Thanks and Regards
Srikar Dronamraju
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>,
Michal Hocko <mhocko@kernel.org>,
Pekka Enberg <penberg@kernel.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
Christopher Lameter <cl@linux.com>,
linuxppc-dev@lists.ozlabs.org,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Kirill Tkhai <ktkhai@virtuozzo.com>
Subject: Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9
Date: Fri, 13 Mar 2020 16:42:46 +0530 [thread overview]
Message-ID: <20200313111246.GB25144@linux.vnet.ibm.com> (raw)
In-Reply-To: <875zf8y1i1.fsf@mpe.ellerman.id.au>
* Michael Ellerman <mpe@ellerman.id.au> [2020-03-13 21:48:06]:
> Sachin Sant <sachinp@linux.vnet.ibm.com> writes:
> >> The patch below might work. Sachin can you test this? I tried faking up
> >> a system with a memoryless node zero but couldn't get it to even start
> >> booting.
> >>
> > The patch did not help. The kernel crashed during
> > the boot with the same call trace.
> >
> > BUG_ON() introduced with the patch was not triggered.
>
> OK, that's weird.
>
> I eventually managed to get a memoryless node going in sim, and it
> appears to work there.
>
> eg in dmesg:
>
> [ 0.000000][ T0] numa: NODE_DATA [mem 0x2000fffa2f80-0x2000fffa7fff]
> [ 0.000000][ T0] numa: NODE_DATA(0) on node 1
> [ 0.000000][ T0] numa: NODE_DATA [mem 0x2000fff9df00-0x2000fffa2f7f]
> ...
> [ 0.000000][ T0] Early memory node ranges
> [ 0.000000][ T0] node 1: [mem 0x0000000000000000-0x00000000ffffffff]
> [ 0.000000][ T0] node 1: [mem 0x0000200000000000-0x00002000ffffffff]
> [ 0.000000][ T0] Could not find start_pfn for node 0
> [ 0.000000][ T0] Initmem setup node 0 [mem 0x0000000000000000-0x0000000000000000]
> [ 0.000000][ T0] On node 0 totalpages: 0
> [ 0.000000][ T0] Initmem setup node 1 [mem 0x0000000000000000-0x00002000ffffffff]
> [ 0.000000][ T0] On node 1 totalpages: 131072
>
> # dmesg | grep set_numa
> [ 0.000000][ T0] set_numa_mem: mem node for 0 = 1
> [ 0.005654][ T0] set_numa_mem: mem node for 1 = 1
>
> So is the problem more than just node zero having no memory?
>
The problem would happen with possible nodes which are not yet present. i.e
no cpus, no memory attached to those nodes.
Please look at
http://lore.kernel.org/lkml/20200312131438.GB3277@linux.vnet.ibm.com/t/#u
for more details.
The summary being: pgdat/Node_Data for such nodes is not allocated. Hence
the node_present_pages(nid) called where nid is a possible but not yet
present node fails. Currently node_present_pages(nid) and node_to_mem_node
don't seem to be equipped to handle possible but not present nodes.
> cheers
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2020-03-13 11:12 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 10:45 [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9 Sachin Sant
2020-02-18 10:50 ` Kirill Tkhai
2020-02-18 10:50 ` Kirill Tkhai
2020-02-18 11:01 ` Kirill Tkhai
2020-02-18 11:01 ` Kirill Tkhai
2020-02-18 11:35 ` Kirill Tkhai
2020-02-18 11:35 ` Kirill Tkhai
2020-02-18 11:40 ` Sachin Sant
2020-02-18 11:55 ` Michal Hocko
2020-02-18 11:55 ` Michal Hocko
2020-02-18 14:00 ` Sachin Sant
2020-02-18 14:00 ` Sachin Sant
2020-02-18 14:26 ` Michal Hocko
2020-02-18 14:26 ` Michal Hocko
2020-02-18 15:11 ` Sachin Sant
2020-02-18 15:11 ` Sachin Sant
2020-02-18 15:24 ` Michal Hocko
2020-02-18 15:24 ` Michal Hocko
2020-02-22 3:38 ` Christopher Lameter
2020-02-22 3:38 ` Christopher Lameter
2020-02-24 8:58 ` Michal Hocko
2020-02-24 8:58 ` Michal Hocko
2020-02-26 18:25 ` Christopher Lameter
2020-02-26 18:25 ` Christopher Lameter
2020-02-26 18:41 ` Michal Hocko
2020-02-26 18:41 ` Michal Hocko
2020-02-26 18:44 ` Christopher Lameter
2020-02-26 18:44 ` Christopher Lameter
2020-02-26 19:01 ` Michal Hocko
2020-02-26 19:01 ` Michal Hocko
2020-02-26 20:31 ` David Rientjes
2020-02-26 20:31 ` David Rientjes
2020-02-26 20:52 ` Michal Hocko
2020-02-26 20:52 ` Michal Hocko
2020-02-26 21:45 ` Vlastimil Babka
2020-02-26 21:45 ` Vlastimil Babka
2020-02-26 22:29 ` Vlastimil Babka
2020-02-26 22:29 ` Vlastimil Babka
2020-02-27 12:12 ` Michal Hocko
2020-02-27 12:12 ` Michal Hocko
2020-02-27 16:00 ` Sachin Sant
2020-02-27 16:00 ` Sachin Sant
2020-02-27 16:16 ` Vlastimil Babka
2020-02-27 18:26 ` Michal Hocko
2020-02-27 18:26 ` Michal Hocko
2020-03-10 15:01 ` Michal Hocko
2020-03-10 15:01 ` Michal Hocko
2020-03-12 12:18 ` Michael Ellerman
2020-03-12 12:18 ` Michael Ellerman
2020-03-12 16:51 ` Sachin Sant
2020-03-12 16:51 ` Sachin Sant
2020-03-13 10:48 ` Michael Ellerman
2020-03-13 10:48 ` Michael Ellerman
2020-03-13 11:12 ` Srikar Dronamraju [this message]
2020-03-13 11:12 ` Srikar Dronamraju
2020-03-13 11:35 ` Vlastimil Babka
2020-03-13 11:35 ` Vlastimil Babka
2020-03-14 8:10 ` Sachin Sant
2020-02-27 12:02 ` Michal Hocko
2020-02-27 12:02 ` Michal Hocko
2020-02-18 11:38 ` Sachin Sant
2020-02-18 11:53 ` Kirill Tkhai
2020-03-17 13:17 ` [PATCH 0/4] Fix kmalloc_node on offline nodes Srikar Dronamraju
2020-03-17 13:17 ` Srikar Dronamraju
2020-03-17 13:17 ` [PATCH 1/4] mm: Check for node_online in node_present_pages Srikar Dronamraju
2020-03-17 13:17 ` Srikar Dronamraju
2020-03-17 13:37 ` Srikar Dronamraju
2020-03-17 13:37 ` Srikar Dronamraju
2020-03-17 13:17 ` [PATCH 2/4] mm/slub: Use mem_node to allocate a new slab Srikar Dronamraju
2020-03-17 13:17 ` Srikar Dronamraju
2020-03-17 13:34 ` Vlastimil Babka
2020-03-17 13:34 ` Vlastimil Babka
2020-03-17 13:45 ` Srikar Dronamraju
2020-03-17 13:45 ` Srikar Dronamraju
2020-03-17 13:53 ` Vlastimil Babka
2020-03-17 13:53 ` Vlastimil Babka
2020-03-17 14:51 ` Srikar Dronamraju
2020-03-17 14:51 ` Srikar Dronamraju
2020-03-17 15:29 ` Vlastimil Babka
2020-03-17 15:29 ` Vlastimil Babka
2020-03-18 7:29 ` Srikar Dronamraju
2020-03-18 7:29 ` Srikar Dronamraju
2020-03-17 16:41 ` Srikar Dronamraju
2020-03-17 16:41 ` Srikar Dronamraju
2020-03-17 13:17 ` [PATCH 3/4] mm: Implement reset_numa_mem Srikar Dronamraju
2020-03-17 13:17 ` Srikar Dronamraju
2020-03-17 13:17 ` [PATCH 4/4] powerpc/numa: Set fallback nodes for offline nodes Srikar Dronamraju
2020-03-17 13:17 ` Srikar Dronamraju
2020-03-17 14:22 ` Bharata B Rao
2020-03-17 14:22 ` Bharata B Rao
2020-03-17 14:29 ` Srikar Dronamraju
2020-03-17 14:29 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313111246.GB25144@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.