* [PATCH v2] Staging: media: imx: eliminate unused code
@ 2020-03-13 13:49 Enrique Vargas
2020-03-13 16:15 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Enrique Vargas @ 2020-03-13 13:49 UTC (permalink / raw)
To: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab,
Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
outreachy-kernel
Eliminate code that is never used inside #ifdef 0 / #endif. This eliminates WARNING found using checkpatch.
Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
---
drivers/staging/media/imx/imx-media-csi.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index b60ed4f22f6d..2001f7851e90 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -1131,13 +1131,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
* enters the CSI's however, they are treated internally
* in the IPU as virtual channel 0.
*/
-#if 0
- mutex_unlock(&priv->lock);
- vc_num = imx_media_find_mipi_csi2_channel(&priv->sd.entity);
- if (vc_num < 0)
- return vc_num;
- mutex_lock(&priv->lock);
-#endif
+
ipu_csi_set_mipi_datatype(priv->csi, vc_num,
&priv->format_mbus[CSI_SINK_PAD]);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Staging: media: imx: eliminate unused code
2020-03-13 13:49 [PATCH v2] Staging: media: imx: eliminate unused code Enrique Vargas
@ 2020-03-13 16:15 ` Greg Kroah-Hartman
2020-03-13 17:22 ` Enrique Vargas
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-13 16:15 UTC (permalink / raw)
To: Enrique Vargas
Cc: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, outreachy-kernel
On Fri, Mar 13, 2020 at 07:49:53AM -0600, Enrique Vargas wrote:
> Eliminate code that is never used inside #ifdef 0 / #endif. This eliminates WARNING found using checkpatch.
>
> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
> ---
> drivers/staging/media/imx/imx-media-csi.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
What changed from v1?
Always put that below the --- line.
Please fix up and send a v3.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Staging: media: imx: eliminate unused code
2020-03-13 16:15 ` Greg Kroah-Hartman
@ 2020-03-13 17:22 ` Enrique Vargas
0 siblings, 0 replies; 3+ messages in thread
From: Enrique Vargas @ 2020-03-13 17:22 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Steve Longerbeam, Philipp Zabel, Mauro Carvalho Chehab, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, outreachy-kernel
On 3/13/20 10:15 AM, Greg Kroah-Hartman wrote:
> On Fri, Mar 13, 2020 at 07:49:53AM -0600, Enrique Vargas wrote:
>> Eliminate code that is never used inside #ifdef 0 / #endif. This eliminates WARNING found using checkpatch.
>>
>> Signed-off-by: Enrique Vargas <jevargas@seas.upenn.edu>
>> ---
>> drivers/staging/media/imx/imx-media-csi.c | 8 +-------
>> 1 file changed, 1 insertion(+), 7 deletions(-)
> What changed from v1?
>
> Always put that below the --- line.
>
> Please fix up and send a v3.
>
> thanks,
>
> greg k-h
Thanks, I sent v3.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-13 17:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-13 13:49 [PATCH v2] Staging: media: imx: eliminate unused code Enrique Vargas
2020-03-13 16:15 ` Greg Kroah-Hartman
2020-03-13 17:22 ` Enrique Vargas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.