All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 2/5] lib/i915: Dynamic subtest constructor for sysfs/engines
Date: Sat, 14 Mar 2020 00:21:39 +0200	[thread overview]
Message-ID: <20200313222139.GC3001@intel.intel> (raw)
In-Reply-To: <20200311093448.4103262-2-chris@chris-wilson.co.uk>

Hi Chris,

> +	lseek(engines, 0, SEEK_SET);
> +	while ((len = syscall(SYS_getdents64, engines, buf, sizeof(buf))) > 0) {
> +		void *ptr = buf;
> +
> +		while (len) {
> +			struct linux_dirent64 {
> +				ino64_t        d_ino;
> +				off64_t        d_off;
> +				unsigned short d_reclen;
> +				unsigned char  d_type;
> +				char           d_name[];
> +			} *de = ptr;

it's unfortunate to be in the situation of doing this, But I
don't see better alternative, it needs to be fixed in the
glibc :(

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/i915: Dynamic subtest constructor for sysfs/engines
Date: Sat, 14 Mar 2020 00:21:39 +0200	[thread overview]
Message-ID: <20200313222139.GC3001@intel.intel> (raw)
In-Reply-To: <20200311093448.4103262-2-chris@chris-wilson.co.uk>

Hi Chris,

> +	lseek(engines, 0, SEEK_SET);
> +	while ((len = syscall(SYS_getdents64, engines, buf, sizeof(buf))) > 0) {
> +		void *ptr = buf;
> +
> +		while (len) {
> +			struct linux_dirent64 {
> +				ino64_t        d_ino;
> +				off64_t        d_off;
> +				unsigned short d_reclen;
> +				unsigned char  d_type;
> +				char           d_name[];
> +			} *de = ptr;

it's unfortunate to be in the situation of doing this, But I
don't see better alternative, it needs to be fixed in the
glibc :(

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-03-13 22:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  9:34 [igt-dev] [PATCH i-g-t 1/5] lib/i915: Create a context wrapping one specific engine Chris Wilson
2020-03-11  9:34 ` [Intel-gfx] " Chris Wilson
2020-03-11  9:34 ` [Intel-gfx] [PATCH i-g-t 2/5] lib/i915: Dynamic subtest constructor for sysfs/engines Chris Wilson
2020-03-13 22:21   ` Andi Shyti [this message]
2020-03-13 22:21     ` Andi Shyti
2020-03-11  9:34 ` [igt-dev] [PATCH i-g-t 3/5] i915: Exercise preemption timeout controls in sysfs Chris Wilson
2020-03-11  9:34   ` [Intel-gfx] " Chris Wilson
2020-03-13 22:26   ` Andi Shyti
2020-03-11  9:34 ` [igt-dev] [PATCH i-g-t 4/5] i915: Exercise sysfs heartbeat controls Chris Wilson
2020-03-11  9:34   ` [Intel-gfx] " Chris Wilson
2020-03-11  9:34 ` [igt-dev] [PATCH i-g-t 5/5] i915: Exercise timeslice sysfs property Chris Wilson
2020-03-11  9:34   ` [Intel-gfx] " Chris Wilson
2020-03-11 15:42 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [i-g-t,1/5] lib/i915: Create a context wrapping one specific engine Patchwork
2020-03-11 15:46 ` [igt-dev] ✗ Fi.CI.BAT: " Patchwork
2020-03-13 22:02 ` [igt-dev] [Intel-gfx] [PATCH i-g-t 1/5] " Andi Shyti
2020-03-13 22:02   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200313222139.GC3001@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.