* [PATCH] staging: comedi: ni_tio: Reformat function call arguments
@ 2020-03-14 21:42 Deepak R Varma
2020-03-17 12:19 ` [Outreachy kernel] " Stefano Brivio
0 siblings, 1 reply; 2+ messages in thread
From: Deepak R Varma @ 2020-03-14 21:42 UTC (permalink / raw)
To: outreachy-kernel
Cc: gregkh, daniel.baluta, kieran.bingham, abbotti, hsweeten,
mh12gx2825
Reformat function call arguments so that the function call is clearly
visible. Issue detected by checkpatch.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
drivers/staging/comedi/drivers/ni_tio.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c
index b264db32a411..f6154addaa95 100644
--- a/drivers/staging/comedi/drivers/ni_tio.c
+++ b/drivers/staging/comedi/drivers/ni_tio.c
@@ -1342,8 +1342,8 @@ static int ni_m_gate2_to_generic_gate(unsigned int gate, unsigned int *src)
static inline unsigned int ni_tio_get_gate_mode(struct ni_gpct *counter)
{
- unsigned int mode = ni_tio_get_soft_copy(
- counter, NITIO_MODE_REG(counter->counter_index));
+ unsigned int mode = ni_tio_get_soft_copy(counter,
+ NITIO_MODE_REG(counter->counter_index));
unsigned int ret = 0;
if ((mode & GI_GATING_MODE_MASK) == GI_GATING_DISABLED)
@@ -1358,8 +1358,8 @@ static inline unsigned int ni_tio_get_gate_mode(struct ni_gpct *counter)
static inline unsigned int ni_tio_get_gate2_mode(struct ni_gpct *counter)
{
- unsigned int mode = ni_tio_get_soft_copy(
- counter, NITIO_GATE2_REG(counter->counter_index));
+ unsigned int mode = ni_tio_get_soft_copy(counter,
+ NITIO_GATE2_REG(counter->counter_index));
unsigned int ret = 0;
if (!(mode & GI_GATE2_MODE))
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: comedi: ni_tio: Reformat function call arguments
2020-03-14 21:42 [PATCH] staging: comedi: ni_tio: Reformat function call arguments Deepak R Varma
@ 2020-03-17 12:19 ` Stefano Brivio
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2020-03-17 12:19 UTC (permalink / raw)
To: Deepak R Varma
Cc: outreachy-kernel, gregkh, daniel.baluta, kieran.bingham, abbotti,
hsweeten
On Sun, 15 Mar 2020 03:12:57 +0530
Deepak R Varma <mh12gx2825@gmail.com> wrote:
> Reformat function call arguments so that the function call is clearly
> visible. Issue detected by checkpatch.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/comedi/drivers/ni_tio.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c
> index b264db32a411..f6154addaa95 100644
> --- a/drivers/staging/comedi/drivers/ni_tio.c
> +++ b/drivers/staging/comedi/drivers/ni_tio.c
> @@ -1342,8 +1342,8 @@ static int ni_m_gate2_to_generic_gate(unsigned int gate, unsigned int *src)
>
> static inline unsigned int ni_tio_get_gate_mode(struct ni_gpct *counter)
> {
> - unsigned int mode = ni_tio_get_soft_copy(
> - counter, NITIO_MODE_REG(counter->counter_index));
> + unsigned int mode = ni_tio_get_soft_copy(counter,
> + NITIO_MODE_REG(counter->counter_index));
> unsigned int ret = 0;
>
> if ((mode & GI_GATING_MODE_MASK) == GI_GATING_DISABLED)
> @@ -1358,8 +1358,8 @@ static inline unsigned int ni_tio_get_gate_mode(struct ni_gpct *counter)
>
> static inline unsigned int ni_tio_get_gate2_mode(struct ni_gpct *counter)
> {
> - unsigned int mode = ni_tio_get_soft_copy(
> - counter, NITIO_GATE2_REG(counter->counter_index));
> + unsigned int mode = ni_tio_get_soft_copy(counter,
> + NITIO_GATE2_REG(counter->counter_index));
> unsigned int ret = 0;
>
> if (!(mode & GI_GATE2_MODE))
I think both the original version and the "fixed" one are quite hard to
read, the proper way to fix this is to initialise 'mode' after the
declaration.
--
Stefano
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-17 12:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-14 21:42 [PATCH] staging: comedi: ni_tio: Reformat function call arguments Deepak R Varma
2020-03-17 12:19 ` [Outreachy kernel] " Stefano Brivio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.