From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, dmitry.torokhov@gmail.com,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
rui.zhang@intel.com, daniel.lezcano@linaro.org,
amit.kucheria@verdurent.com, wim@linux-watchdog.org,
linux@roeck-us.net, daniel.baluta@nxp.com,
gregkh@linuxfoundation.org, linux@rempel-privat.de,
tglx@linutronix.de, m.felsch@pengutronix.de,
andriy.shevchenko@linux.intel.com, arnd@arndb.de,
ronald@innovation.ch, krzk@kernel.org, robh@kernel.org,
leonard.crestez@nxp.com, aisheng.dong@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org,
linux-watchdog@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support
Date: Mon, 16 Mar 2020 11:37:53 +0800 [thread overview]
Message-ID: <20200316033752.GF17221@dragon> (raw)
In-Reply-To: <1583714300-19085-2-git-send-email-Anson.Huang@nxp.com>
On Mon, Mar 09, 2020 at 08:38:15AM +0800, Anson Huang wrote:
> Add COMPILE_TEST support to i.MX SCU drivers for better compile
> testing coverage.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> No change.
> ---
> drivers/firmware/imx/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig
> index 1d2e5b8..116707a 100644
> --- a/drivers/firmware/imx/Kconfig
> +++ b/drivers/firmware/imx/Kconfig
> @@ -12,7 +12,7 @@ config IMX_DSP
>
> config IMX_SCU
> bool "IMX SCU Protocol driver"
> - depends on IMX_MBOX
> + depends on IMX_MBOX || COMPILE_TEST
> help
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and
> @@ -24,6 +24,6 @@ config IMX_SCU
>
> config IMX_SCU_PD
> bool "IMX SCU Power Domain driver"
> - depends on IMX_SCU
> + depends on IMX_SCU || COMPILE_TEST
Just reminded by Peng, as we go without adding stubs for !IMX_SCU, any
driver depending on IMX_SCU shouldn't have COMPILE_TEST. I fixed it up
by dropping COMPILE_TEST from IMX_SCU_PD.
Shawn
> help
> The System Controller Firmware (SCFW) based power domain driver.
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: alexandre.belloni@bootlin.com, m.felsch@pengutronix.de,
leonard.crestez@nxp.com, festevam@gmail.com,
linux-rtc@vger.kernel.org, robh@kernel.org,
amit.kucheria@verdurent.com, wim@linux-watchdog.org,
daniel.lezcano@linaro.org, krzk@kernel.org, Linux-imx@nxp.com,
linux-input@vger.kernel.org, rui.zhang@intel.com,
ronald@innovation.ch, linux@roeck-us.net,
linux-watchdog@vger.kernel.org, arnd@arndb.de,
linux-pm@vger.kernel.org, s.hauer@pengutronix.de,
tglx@linutronix.de, andriy.shevchenko@linux.intel.com,
daniel.baluta@nxp.com, linux-arm-kernel@lists.infradead.org,
aisheng.dong@nxp.com, a.zummo@towertech.it,
gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org, linux@rempel-privat.de,
kernel@pengutronix.de
Subject: Re: [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support
Date: Mon, 16 Mar 2020 11:37:53 +0800 [thread overview]
Message-ID: <20200316033752.GF17221@dragon> (raw)
In-Reply-To: <1583714300-19085-2-git-send-email-Anson.Huang@nxp.com>
On Mon, Mar 09, 2020 at 08:38:15AM +0800, Anson Huang wrote:
> Add COMPILE_TEST support to i.MX SCU drivers for better compile
> testing coverage.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> No change.
> ---
> drivers/firmware/imx/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig
> index 1d2e5b8..116707a 100644
> --- a/drivers/firmware/imx/Kconfig
> +++ b/drivers/firmware/imx/Kconfig
> @@ -12,7 +12,7 @@ config IMX_DSP
>
> config IMX_SCU
> bool "IMX SCU Protocol driver"
> - depends on IMX_MBOX
> + depends on IMX_MBOX || COMPILE_TEST
> help
> The System Controller Firmware (SCFW) is a low-level system function
> which runs on a dedicated Cortex-M core to provide power, clock, and
> @@ -24,6 +24,6 @@ config IMX_SCU
>
> config IMX_SCU_PD
> bool "IMX SCU Power Domain driver"
> - depends on IMX_SCU
> + depends on IMX_SCU || COMPILE_TEST
Just reminded by Peng, as we go without adding stubs for !IMX_SCU, any
driver depending on IMX_SCU shouldn't have COMPILE_TEST. I fixed it up
by dropping COMPILE_TEST from IMX_SCU_PD.
Shawn
> help
> The System Controller Firmware (SCFW) based power domain driver.
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-16 3:38 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 0:38 [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-16 0:53 ` Shawn Guo
2020-03-16 0:53 ` Shawn Guo
2020-03-16 3:37 ` Shawn Guo [this message]
2020-03-16 3:37 ` Shawn Guo
2020-03-09 0:38 ` [PATCH V3 3/7] rtc: add COMPILE_TEST support for i.MX SC RTC Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 4/7] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 5/7] input: keyboard: imx_sc_key: Fix build warning for !CONFIG_IMX_SCU case Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 6/7] watchdog: add COMPILE_TEST support for IMX_SC_WDT Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 0:38 ` [PATCH V3 7/7] thermal: add COMPILE_TEST support for IMX_SC_THERMAL Anson Huang
2020-03-09 0:38 ` Anson Huang
2020-03-09 11:06 ` [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Alexandre Belloni
2020-03-09 11:06 ` Alexandre Belloni
2020-03-09 12:20 ` Anson Huang
2020-03-09 12:20 ` Anson Huang
2020-03-09 13:27 ` Guenter Roeck
2020-03-09 13:27 ` Guenter Roeck
2020-03-09 13:37 ` Anson Huang
2020-03-09 13:37 ` Anson Huang
2020-03-09 16:47 ` Alexandre Belloni
2020-03-09 16:47 ` Alexandre Belloni
2020-03-09 17:10 ` Guenter Roeck
2020-03-09 17:10 ` Guenter Roeck
2020-03-09 17:30 ` Alexandre Belloni
2020-03-09 17:30 ` Alexandre Belloni
2020-03-09 18:19 ` Guenter Roeck
2020-03-09 18:19 ` Guenter Roeck
2020-03-09 13:40 ` Peng Fan
2020-03-09 13:40 ` Peng Fan
2020-03-09 14:09 ` Anson Huang
2020-03-09 14:09 ` Anson Huang
2020-03-16 0:52 ` Shawn Guo
2020-03-16 0:52 ` Shawn Guo
2020-03-16 2:51 ` Peng Fan
2020-03-16 2:51 ` Peng Fan
2020-03-16 3:07 ` Shawn Guo
2020-03-16 3:07 ` Shawn Guo
2020-03-16 3:18 ` Peng Fan
2020-03-16 3:18 ` Peng Fan
2020-03-16 3:34 ` Shawn Guo
2020-03-16 3:34 ` Shawn Guo
2020-03-16 8:04 ` Anson Huang
2020-03-16 8:04 ` Anson Huang
2020-03-16 8:40 ` Alexandre Belloni
2020-03-16 8:40 ` Alexandre Belloni
2020-03-16 8:44 ` Anson Huang
2020-03-16 8:44 ` Anson Huang
2020-03-16 9:00 ` Alexandre Belloni
2020-03-16 9:00 ` Alexandre Belloni
2020-03-16 9:08 ` Anson Huang
2020-03-16 9:08 ` Anson Huang
2020-03-16 9:15 ` Alexandre Belloni
2020-03-16 9:15 ` Alexandre Belloni
2020-03-16 9:40 ` Anson Huang
2020-03-16 9:40 ` Anson Huang
2020-03-16 10:00 ` Alexandre Belloni
2020-03-16 10:00 ` Alexandre Belloni
2020-03-16 10:18 ` Anson Huang
2020-03-16 10:18 ` Anson Huang
2020-03-17 2:18 ` Peng Fan
2020-03-17 2:18 ` Peng Fan
2020-03-17 2:29 ` Anson Huang
2020-03-17 2:29 ` Anson Huang
2020-03-17 2:32 ` Guenter Roeck
2020-03-17 2:32 ` Guenter Roeck
2020-03-17 2:35 ` Anson Huang
2020-03-17 2:35 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316033752.GF17221@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=a.zummo@towertech.it \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=linux@roeck-us.net \
--cc=m.felsch@pengutronix.de \
--cc=robh@kernel.org \
--cc=ronald@innovation.ch \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.