From: Stefano Brivio <sbrivio@redhat.com>
To: Deepak R Varma <mh12gx2825@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
daniel.baluta@gmail.com, kieran.bingham@ideasonboard.com
Subject: Re: [Outreachy kernel] [PATCH 4/4] staging: fbtft: Avoid potential precedence issues
Date: Mon, 16 Mar 2020 14:44:03 +0100 [thread overview]
Message-ID: <20200316144403.5b08bfdc@elisabeth> (raw)
In-Reply-To: <5c8520a5c3da453460608deee9a25232d52f4513.1584314604.git.mh12gx2825@gmail.com>
By "carrying" the tag I really meant that you would, here (not in the
cover letter), add:
On Mon, 16 Mar 2020 05:12:32 +0530
Deepak R Varma <mh12gx2825@gmail.com> wrote:
> Put parentheses around uses of macro parameters to avoid possible
> precedence issues. Problem detected by checkpatch.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
"Reviewed-by: Stefano Brivio <sbrivio@redhat.com>"
after your Signed-off-by. Mind, however, that you should only do this
in case the reviewer tells you explicitly (I've seen it being done
implicitly, with myself and others, it's really not nice).
In any case,
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
(will check the rest later).
--
Stefano
next prev parent reply other threads:[~2020-03-16 13:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 23:40 [PATCH v3 0/4] staging: fbtft: code cleanup patchset - checkpatch Deepak R Varma
2020-03-15 23:41 ` [PATCH 1/4] staging: fbtft: Reformat line over 80 characters Deepak R Varma
2020-03-15 23:41 ` [PATCH 2/4] staging: fbtft: Reformat long macro definitions Deepak R Varma
2020-03-15 23:42 ` [PATCH 3/4] staging: fbtft: simplify array index computation Deepak R Varma
2020-03-15 23:42 ` [PATCH 4/4] staging: fbtft: Avoid potential precedence issues Deepak R Varma
2020-03-16 13:44 ` Stefano Brivio [this message]
2020-03-16 14:55 ` [Outreachy kernel] " Deepak Varma
2020-03-17 11:46 ` Greg KH
2020-03-17 18:19 ` DEEPAK VARMA
2020-03-21 11:26 ` DEEPAK VARMA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316144403.5b08bfdc@elisabeth \
--to=sbrivio@redhat.com \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=mh12gx2825@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.