All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak R Varma <mh12gx2825@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, daniel.baluta@gmail.com,
	kieran.bingham@ideasonboard.com
Subject: [PATCH v3 0/4] staging: fbtft: code cleanup patchset - checkpatch
Date: Mon, 16 Mar 2020 05:10:08 +0530	[thread overview]
Message-ID: <cover.1584314603.git.mh12gx2825@gmail.com> (raw)

Implement code formatting corrections as flagged by checkpatch
script. Common issues around lines exceeding 80 column limit and similar
formatting issues for the fbtft driver files are considered in the scope
of this patchset.

Note that top two patches in the list below were sent to the mailing
list for review as individual patches earlier. As I found additional
similar issues in the same area, I am requesting to combine these
related patches in this patchset.


Changes since v2:
    - Implement Corrections suggested by Stefano for [patch 1/4, 2/4, 3/4]:
        1. Typos in patch description.
	2. Improve variable name as per coding style guidelines.
    - Advised following for Patch 4/4
	1. Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

Changes since v1:
    - Corrections suggested by Julia for [patch 4 /4]:
        1. Update commit message - use word "potential" in place of "likely".
        2. Update log message - use word "parentheses" in place of "braces".
        3. Rephrase log message - make it concise and easy to understand.


Deepak R Varma (4):
  staging: fbtft: Reformat line over 80 characters
  staging: fbtft: Reformat long macro definitions
  staging: fbtft: simplify array index computation
  staging: fbtft: Avoid potential precedence issues

 drivers/staging/fbtft/fbtft-core.c  |  4 +++-
 drivers/staging/fbtft/fbtft-sysfs.c |  6 +++++-
 drivers/staging/fbtft/fbtft.h       | 18 +++++++++++++-----
 3 files changed, 21 insertions(+), 7 deletions(-)

-- 
2.17.1



             reply	other threads:[~2020-03-15 23:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15 23:40 Deepak R Varma [this message]
2020-03-15 23:41 ` [PATCH 1/4] staging: fbtft: Reformat line over 80 characters Deepak R Varma
2020-03-15 23:41 ` [PATCH 2/4] staging: fbtft: Reformat long macro definitions Deepak R Varma
2020-03-15 23:42 ` [PATCH 3/4] staging: fbtft: simplify array index computation Deepak R Varma
2020-03-15 23:42 ` [PATCH 4/4] staging: fbtft: Avoid potential precedence issues Deepak R Varma
2020-03-16 13:44   ` [Outreachy kernel] " Stefano Brivio
2020-03-16 14:55     ` Deepak Varma
2020-03-17 11:46   ` Greg KH
2020-03-17 18:19     ` DEEPAK VARMA
2020-03-21 11:26     ` DEEPAK VARMA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1584314603.git.mh12gx2825@gmail.com \
    --to=mh12gx2825@gmail.com \
    --cc=daniel.baluta@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.