All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
	Daniel Drake <drake@endlessm.com>
Subject: Re: [PATCH 2/2] iommu/vt-d: Ignore devices with out-of-spec domain number
Date: Mon, 16 Mar 2020 08:53:08 -0700	[thread overview]
Message-ID: <20200316155308.GC18704@infradead.org> (raw)
In-Reply-To: <20200312060955.8523-3-baolu.lu@linux.intel.com>

On Thu, Mar 12, 2020 at 02:09:55PM +0800, Lu Baolu wrote:
> @@ -128,6 +129,13 @@ dmar_alloc_pci_notify_info(struct pci_dev *dev, unsigned long event)
>  
>  	BUG_ON(dev->is_virtfn);
>  
> +	/*
> +	 * Ignore devices that have a domain number higher than what can
> +	 * be looked up in DMAR, e.g. VMD subdevices with domain 0x10000
> +	 */
> +	if (pci_domain_nr(dev->bus) > U16_MAX)

I think this needs a well documented core PCI layer function, as that
is where these "fake" domains are create.

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org,
	Daniel Drake <drake@endlessm.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] iommu/vt-d: Ignore devices with out-of-spec domain number
Date: Mon, 16 Mar 2020 08:53:08 -0700	[thread overview]
Message-ID: <20200316155308.GC18704@infradead.org> (raw)
In-Reply-To: <20200312060955.8523-3-baolu.lu@linux.intel.com>

On Thu, Mar 12, 2020 at 02:09:55PM +0800, Lu Baolu wrote:
> @@ -128,6 +129,13 @@ dmar_alloc_pci_notify_info(struct pci_dev *dev, unsigned long event)
>  
>  	BUG_ON(dev->is_virtfn);
>  
> +	/*
> +	 * Ignore devices that have a domain number higher than what can
> +	 * be looked up in DMAR, e.g. VMD subdevices with domain 0x10000
> +	 */
> +	if (pci_domain_nr(dev->bus) > U16_MAX)

I think this needs a well documented core PCI layer function, as that
is where these "fake" domains are create.


  reply	other threads:[~2020-03-16 15:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12  6:09 [PULL REQUEST] iommu/vt-d: fixes for v5.6 Lu Baolu
2020-03-12  6:09 ` [PATCH 1/2] iommu/vt-d: Fix the wrong printing in RHSA parsing Lu Baolu
2020-03-12  6:09 ` [PATCH 2/2] iommu/vt-d: Ignore devices with out-of-spec domain number Lu Baolu
2020-03-16 15:53   ` Christoph Hellwig [this message]
2020-03-16 15:53     ` Christoph Hellwig
2020-03-13 13:41 ` [PULL REQUEST] iommu/vt-d: fixes for v5.6 Joerg Roedel
2020-03-13 13:46 ` Joerg Roedel
2020-03-14  1:23   ` Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200316155308.GC18704@infradead.org \
    --to=hch@infradead.org \
    --cc=baolu.lu@linux.intel.com \
    --cc=drake@endlessm.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.