From: Christoph Hellwig <hch@lst.de>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: amd-gfx@lists.freedesktop.org, linux-mm@kvack.org,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kvm-ppc@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Jerome Glisse" <jglisse@redhat.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Bharata B Rao" <bharata@linux.ibm.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 2/2] mm: remove device private page support from hmm_range_fault
Date: Mon, 16 Mar 2020 19:58:22 +0100 [thread overview]
Message-ID: <20200316185822.GA25473@lst.de> (raw)
In-Reply-To: <20200316184935.GA25322@lst.de>
On Mon, Mar 16, 2020 at 07:49:35PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 16, 2020 at 11:42:19AM -0700, Ralph Campbell wrote:
> >
> > On 3/16/20 10:52 AM, Christoph Hellwig wrote:
> >> No driver has actually used properly wire up and support this feature.
> >> There is various code related to it in nouveau, but as far as I can tell
> >> it never actually got turned on, and the only changes since the initial
> >> commit are global cleanups.
> >
> > This is not actually true. OpenCL 2.x does support SVM with nouveau and
> > device private memory via clEnqueueSVMMigrateMem().
> > Also, Ben Skeggs has accepted a set of patches to map GPU memory after being
> > migrated and this change would conflict with that.
>
> Can you explain me how we actually invoke this code?
>
> For that we'd need HMM_PFN_DEVICE_PRIVATE NVIF_VMM_PFNMAP_V0_VRAM
> set in ->pfns before calling hmm_range_fault, which isn't happening.
Ok, looks like the fault side is unused, but we need to keep the
non-fault path in place. I'll fix up the patch.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Dan Williams" <dan.j.williams@intel.com>,
"Bharata B Rao" <bharata@linux.ibm.com>,
"Christian König" <christian.koenig@amd.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Jerome Glisse" <jglisse@redhat.com>,
kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm: remove device private page support from hmm_range_fault
Date: Mon, 16 Mar 2020 18:58:22 +0000 [thread overview]
Message-ID: <20200316185822.GA25473@lst.de> (raw)
In-Reply-To: <20200316184935.GA25322@lst.de>
On Mon, Mar 16, 2020 at 07:49:35PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 16, 2020 at 11:42:19AM -0700, Ralph Campbell wrote:
> >
> > On 3/16/20 10:52 AM, Christoph Hellwig wrote:
> >> No driver has actually used properly wire up and support this feature.
> >> There is various code related to it in nouveau, but as far as I can tell
> >> it never actually got turned on, and the only changes since the initial
> >> commit are global cleanups.
> >
> > This is not actually true. OpenCL 2.x does support SVM with nouveau and
> > device private memory via clEnqueueSVMMigrateMem().
> > Also, Ben Skeggs has accepted a set of patches to map GPU memory after being
> > migrated and this change would conflict with that.
>
> Can you explain me how we actually invoke this code?
>
> For that we'd need HMM_PFN_DEVICE_PRIVATE NVIF_VMM_PFNMAP_V0_VRAM
> set in ->pfns before calling hmm_range_fault, which isn't happening.
Ok, looks like the fault side is unused, but we need to keep the
non-fault path in place. I'll fix up the patch.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: "Christoph Hellwig" <hch@lst.de>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Dan Williams" <dan.j.williams@intel.com>,
"Bharata B Rao" <bharata@linux.ibm.com>,
"Christian König" <christian.koenig@amd.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Jerome Glisse" <jglisse@redhat.com>,
kvm-ppc@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm: remove device private page support from hmm_range_fault
Date: Mon, 16 Mar 2020 19:58:22 +0100 [thread overview]
Message-ID: <20200316185822.GA25473@lst.de> (raw)
In-Reply-To: <20200316184935.GA25322@lst.de>
On Mon, Mar 16, 2020 at 07:49:35PM +0100, Christoph Hellwig wrote:
> On Mon, Mar 16, 2020 at 11:42:19AM -0700, Ralph Campbell wrote:
> >
> > On 3/16/20 10:52 AM, Christoph Hellwig wrote:
> >> No driver has actually used properly wire up and support this feature.
> >> There is various code related to it in nouveau, but as far as I can tell
> >> it never actually got turned on, and the only changes since the initial
> >> commit are global cleanups.
> >
> > This is not actually true. OpenCL 2.x does support SVM with nouveau and
> > device private memory via clEnqueueSVMMigrateMem().
> > Also, Ben Skeggs has accepted a set of patches to map GPU memory after being
> > migrated and this change would conflict with that.
>
> Can you explain me how we actually invoke this code?
>
> For that we'd need HMM_PFN_DEVICE_PRIVATE NVIF_VMM_PFNMAP_V0_VRAM
> set in ->pfns before calling hmm_range_fault, which isn't happening.
Ok, looks like the fault side is unused, but we need to keep the
non-fault path in place. I'll fix up the patch.
next prev parent reply other threads:[~2020-03-16 19:13 UTC|newest]
Thread overview: 196+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:52 ensure device private pages have an owner Christoph Hellwig
2020-03-16 17:52 ` Christoph Hellwig
2020-03-16 17:52 ` Christoph Hellwig
2020-03-16 17:52 ` [PATCH 1/2] mm: handle multiple owners of device private pages in migrate_vma Christoph Hellwig
2020-03-16 17:52 ` Christoph Hellwig
2020-03-16 17:52 ` Christoph Hellwig
2020-03-16 18:17 ` Jason Gunthorpe
2020-03-16 18:17 ` Jason Gunthorpe
2020-03-16 18:17 ` Jason Gunthorpe
2020-03-16 18:17 ` Jason Gunthorpe
2020-03-16 18:20 ` Christoph Hellwig
2020-03-16 18:20 ` Christoph Hellwig
2020-03-16 18:20 ` Christoph Hellwig
2020-03-16 17:52 ` [PATCH 2/2] mm: remove device private page support from hmm_range_fault Christoph Hellwig
2020-03-16 17:52 ` Christoph Hellwig
2020-03-16 17:52 ` Christoph Hellwig
2020-03-16 18:42 ` Ralph Campbell
2020-03-16 18:42 ` Ralph Campbell
2020-03-16 18:42 ` Ralph Campbell
2020-03-16 18:42 ` Ralph Campbell
2020-03-16 18:42 ` Ralph Campbell
2020-03-16 18:49 ` Christoph Hellwig
2020-03-16 18:49 ` Christoph Hellwig
2020-03-16 18:49 ` Christoph Hellwig
2020-03-16 18:58 ` Christoph Hellwig [this message]
2020-03-16 18:58 ` Christoph Hellwig
2020-03-16 18:58 ` Christoph Hellwig
2020-03-16 19:56 ` Ralph Campbell
2020-03-16 19:56 ` Ralph Campbell
2020-03-16 19:56 ` Ralph Campbell
2020-03-16 19:56 ` Ralph Campbell
2020-03-16 20:09 ` Jason Gunthorpe
2020-03-16 20:09 ` Jason Gunthorpe
2020-03-16 20:09 ` Jason Gunthorpe
2020-03-16 20:09 ` Jason Gunthorpe
2020-03-16 20:24 ` Ralph Campbell
2020-03-16 20:24 ` Ralph Campbell
2020-03-16 20:24 ` Ralph Campbell
2020-03-16 20:24 ` Ralph Campbell
2020-03-17 11:56 ` Jason Gunthorpe
2020-03-17 11:56 ` Jason Gunthorpe
2020-03-17 11:56 ` Jason Gunthorpe
2020-03-17 11:56 ` Jason Gunthorpe
2020-03-17 22:46 ` Ralph Campbell
2020-03-17 22:46 ` Ralph Campbell
2020-03-17 22:46 ` Ralph Campbell
2020-03-17 22:46 ` Ralph Campbell
2020-03-16 19:04 ` Jason Gunthorpe
2020-03-16 19:04 ` Jason Gunthorpe
2020-03-16 19:04 ` Jason Gunthorpe
2020-03-16 19:04 ` Jason Gunthorpe
2020-03-16 19:07 ` Christoph Hellwig
2020-03-16 19:07 ` Christoph Hellwig
2020-03-16 19:07 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-03-16 19:32 ensure device private pages have an owner v2 Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 19:32 ` [PATCH 1/4] memremap: add an owner field to struct dev_pagemap Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 20:55 ` Ralph Campbell
2020-03-16 20:55 ` Ralph Campbell
2020-03-16 20:55 ` Ralph Campbell
2020-03-16 20:55 ` Ralph Campbell
2020-03-16 20:55 ` Ralph Campbell
2020-03-16 19:32 ` [PATCH 2/4] mm: handle multiple owners of device private pages in migrate_vma Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 21:43 ` Ralph Campbell
2020-03-16 21:43 ` Ralph Campbell
2020-03-16 21:43 ` Ralph Campbell
2020-03-16 21:43 ` Ralph Campbell
2020-03-16 21:43 ` Ralph Campbell
2020-03-16 19:32 ` [PATCH 3/4] mm: simplify device private page handling in hmm_range_fault Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 19:59 ` Jason Gunthorpe
2020-03-16 19:59 ` Jason Gunthorpe
2020-03-16 19:59 ` Jason Gunthorpe
2020-03-16 19:59 ` Jason Gunthorpe
2020-03-16 21:33 ` Christoph Hellwig
2020-03-16 21:33 ` Christoph Hellwig
2020-03-16 21:33 ` Christoph Hellwig
2020-03-16 22:49 ` Ralph Campbell
2020-03-16 22:49 ` Ralph Campbell
2020-03-16 22:49 ` Ralph Campbell
2020-03-16 22:49 ` Ralph Campbell
2020-03-16 22:49 ` Ralph Campbell
2020-03-17 7:34 ` Christoph Hellwig
2020-03-17 7:34 ` Christoph Hellwig
2020-03-17 7:34 ` Christoph Hellwig
2020-03-17 22:43 ` Ralph Campbell
2020-03-17 22:43 ` Ralph Campbell
2020-03-17 22:43 ` Ralph Campbell
2020-03-17 22:43 ` Ralph Campbell
2020-03-18 9:34 ` Christoph Hellwig
2020-03-18 9:34 ` Christoph Hellwig
2020-03-18 9:34 ` Christoph Hellwig
2020-03-17 12:15 ` Jason Gunthorpe
2020-03-17 12:15 ` Jason Gunthorpe
2020-03-17 12:15 ` Jason Gunthorpe
2020-03-17 12:15 ` Jason Gunthorpe
2020-03-17 12:24 ` Christoph Hellwig
2020-03-17 12:24 ` Christoph Hellwig
2020-03-17 12:24 ` Christoph Hellwig
2020-03-17 12:28 ` Christoph Hellwig
2020-03-17 12:28 ` Christoph Hellwig
2020-03-17 12:28 ` Christoph Hellwig
2020-03-17 12:47 ` Jason Gunthorpe
2020-03-17 12:47 ` Jason Gunthorpe
2020-03-17 12:47 ` Jason Gunthorpe
2020-03-17 12:47 ` Jason Gunthorpe
2020-03-17 12:59 ` Christoph Hellwig
2020-03-17 12:59 ` Christoph Hellwig
2020-03-17 12:59 ` Christoph Hellwig
2020-03-17 17:32 ` Jason Gunthorpe
2020-03-17 17:32 ` Jason Gunthorpe
2020-03-17 17:32 ` Jason Gunthorpe
2020-03-17 17:32 ` Jason Gunthorpe
2020-03-17 17:32 ` Jason Gunthorpe
2020-03-17 23:14 ` Ralph Campbell
2020-03-17 23:14 ` Ralph Campbell
2020-03-17 23:14 ` Ralph Campbell
2020-03-17 23:14 ` Ralph Campbell
2020-03-19 18:17 ` Jason Gunthorpe
2020-03-19 18:17 ` Jason Gunthorpe
2020-03-19 18:17 ` Jason Gunthorpe
2020-03-19 18:17 ` Jason Gunthorpe
2020-03-19 22:56 ` Ralph Campbell
2020-03-19 22:56 ` Ralph Campbell
2020-03-19 22:56 ` Ralph Campbell
2020-03-19 22:56 ` Ralph Campbell
2020-03-20 0:03 ` Jason Gunthorpe
2020-03-20 0:03 ` Jason Gunthorpe
2020-03-20 0:03 ` Jason Gunthorpe
2020-03-20 0:03 ` Jason Gunthorpe
2020-03-21 8:20 ` Christoph Hellwig
2020-03-21 8:20 ` Christoph Hellwig
2020-03-21 8:20 ` Christoph Hellwig
2020-03-20 0:14 ` Jason Gunthorpe
2020-03-20 0:14 ` Jason Gunthorpe
2020-03-20 0:14 ` Jason Gunthorpe
2020-03-20 0:14 ` Jason Gunthorpe
2020-03-20 1:33 ` Ralph Campbell
2020-03-20 1:33 ` Ralph Campbell
2020-03-20 1:33 ` Ralph Campbell
2020-03-20 1:33 ` Ralph Campbell
2020-03-20 12:58 ` Jason Gunthorpe
2020-03-20 12:58 ` Jason Gunthorpe
2020-03-20 12:58 ` Jason Gunthorpe
2020-03-20 12:58 ` Jason Gunthorpe
2020-03-20 12:58 ` Jason Gunthorpe
2020-03-16 19:32 ` [PATCH 4/4] mm: check the device private page owner " Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 19:32 ` Christoph Hellwig
2020-03-16 19:49 ` Jason Gunthorpe
2020-03-16 19:49 ` Jason Gunthorpe
2020-03-16 19:49 ` Jason Gunthorpe
2020-03-16 19:49 ` Jason Gunthorpe
2020-03-16 23:11 ` Ralph Campbell
2020-03-16 23:11 ` Ralph Campbell
2020-03-16 23:11 ` Ralph Campbell
2020-03-16 23:11 ` Ralph Campbell
2020-03-16 23:11 ` Ralph Campbell
2020-03-20 13:41 ` Jason Gunthorpe
2020-03-20 13:41 ` Jason Gunthorpe
2020-03-20 13:41 ` Jason Gunthorpe
2020-03-20 13:41 ` Jason Gunthorpe
2020-03-21 8:22 ` Christoph Hellwig
2020-03-21 8:22 ` Christoph Hellwig
2020-03-21 8:22 ` Christoph Hellwig
2020-03-21 12:38 ` Jason Gunthorpe
2020-03-21 12:38 ` Jason Gunthorpe
2020-03-21 12:38 ` Jason Gunthorpe
2020-03-21 12:38 ` Jason Gunthorpe
2020-03-21 15:18 ` Christoph Hellwig
2020-03-21 15:18 ` Christoph Hellwig
2020-03-21 15:18 ` Christoph Hellwig
2020-03-17 5:31 ` ensure device private pages have an owner v2 Bharata B Rao
2020-03-17 5:43 ` Bharata B Rao
2020-03-17 5:31 ` Bharata B Rao
2020-03-19 0:28 ` Jason Gunthorpe
2020-03-19 0:28 ` Jason Gunthorpe
2020-03-19 0:28 ` Jason Gunthorpe
2020-03-19 0:28 ` Jason Gunthorpe
2020-03-19 7:16 ` Christoph Hellwig
2020-03-19 7:16 ` Christoph Hellwig
2020-03-19 7:16 ` Christoph Hellwig
2020-03-19 11:50 ` Jason Gunthorpe
2020-03-19 11:50 ` Jason Gunthorpe
2020-03-19 11:50 ` Jason Gunthorpe
2020-03-19 11:50 ` Jason Gunthorpe
2020-03-19 18:50 ` Jason Gunthorpe
2020-03-19 18:50 ` Jason Gunthorpe
2020-03-19 18:50 ` Jason Gunthorpe
2020-03-19 18:50 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316185822.GA25473@lst.de \
--to=hch@lst.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bharata@linux.ibm.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.