* [PATCH v3] staging: sm750fb: Better Fix of long line in makefile variable
@ 2020-03-13 16:50 R Veera Kumar
2020-03-17 0:50 ` [Outreachy kernel] " Stefano Brivio
0 siblings, 1 reply; 4+ messages in thread
From: R Veera Kumar @ 2020-03-13 16:50 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Sudip Mukherjee, Teddy Wang, outreachy-kernel
A simple fix of long line in makefile variable assignment.
Found using checkpatch.pl.
Signed-off-by: R Veera Kumar <vkor@vkten.in>
---
Changes in v3:
- change make variable definition using a clean style
Changes in v2:
- Make the subject line imperative one
---
drivers/staging/sm750fb/Makefile | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/Makefile b/drivers/staging/sm750fb/Makefile
index 1cf3849cef23..b89aa4c12e9d 100644
--- a/drivers/staging/sm750fb/Makefile
+++ b/drivers/staging/sm750fb/Makefile
@@ -1,5 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_FB_SM750) += sm750fb.o
-sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
-sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
+sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o \
+ ddk750_chip.o ddk750_power.o ddk750_mode.o \
+ ddk750_display.o ddk750_swi2c.o ddk750_sii164.o \
+ ddk750_dvi.o ddk750_hwi2c.o
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v3] staging: sm750fb: Better Fix of long line in makefile variable
2020-03-13 16:50 [PATCH v3] staging: sm750fb: Better Fix of long line in makefile variable R Veera Kumar
@ 2020-03-17 0:50 ` Stefano Brivio
2020-03-17 1:59 ` Veera
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Brivio @ 2020-03-17 0:50 UTC (permalink / raw)
To: R Veera Kumar
Cc: Greg Kroah-Hartman, Sudip Mukherjee, Teddy Wang, outreachy-kernel
On Fri, 13 Mar 2020 22:20:30 +0530
R Veera Kumar <vkor@vkten.in> wrote:
> A simple fix of long line in makefile variable assignment.
> Found using checkpatch.pl.
Same comment as v2 for your rtl8172 patch: I think "Better" should be
omitted in the commit title. It looks good to me otherwise.
--
Stefano
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH v3] staging: sm750fb: Better Fix of long line in makefile variable
2020-03-17 0:50 ` [Outreachy kernel] " Stefano Brivio
@ 2020-03-17 1:59 ` Veera
2020-03-17 9:41 ` Stefano Brivio
0 siblings, 1 reply; 4+ messages in thread
From: Veera @ 2020-03-17 1:59 UTC (permalink / raw)
To: Stefano Brivio
Cc: Greg Kroah-Hartman, Sudip Mukherjee, Teddy Wang, outreachy-kernel
On Tue, Mar 17, 2020 at 01:50:30AM +0100, Stefano Brivio wrote:
> On Fri, 13 Mar 2020 22:20:30 +0530
> R Veera Kumar <vkor@vkten.in> wrote:
>
> > A simple fix of long line in makefile variable assignment.
> > Found using checkpatch.pl.
>
> Same comment as v2 for your rtl8172 patch: I think "Better" should be
> omitted in the commit title. It looks good to me otherwise.
>
Please see my reply for rtl8712 patch comment.
Also should I make a new patch revision and send again?
Veera
> --
> Stefano
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200317015030.0de5ef50%40elisabeth.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-17 9:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-13 16:50 [PATCH v3] staging: sm750fb: Better Fix of long line in makefile variable R Veera Kumar
2020-03-17 0:50 ` [Outreachy kernel] " Stefano Brivio
2020-03-17 1:59 ` Veera
2020-03-17 9:41 ` Stefano Brivio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.