All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Lourdes Pedrajas <lu@pplo.net>,
	outreachy-kernel@googlegroups.com, jerome.pouiller@silabs.com
Subject: Re: [Outreachy kernel] [PATCH] staging: wfx: remove unneeded spaces
Date: Tue, 17 Mar 2020 13:51:14 +0100	[thread overview]
Message-ID: <20200317125114.GA1275972@kroah.com> (raw)
In-Reply-To: <20200317134505.2e417b36@elisabeth>

On Tue, Mar 17, 2020 at 01:45:05PM +0100, Stefano Brivio wrote:
> On Sun, 15 Mar 2020 05:49:22 +0100
> Lourdes Pedrajas <lu@pplo.net> wrote:
> 
> > Remove spaces after type casting operators in order to comply codding
> 
> with coding...
> 
> > standards.
> >
> > Issue found with checkpatch.
> > 
> > Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> 
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> 
> By the way, question for Greg:
> 
> > [...]
> >
> > index a60ac03fa73d..07a9991929fd 100644
> > --- a/drivers/staging/wfx/sta.c
> > +++ b/drivers/staging/wfx/sta.c
> > @@ -903,7 +903,7 @@ static void wfx_update_tim_work(struct work_struct *work)
> >  int wfx_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, bool set)
> >  {
> >  	struct wfx_dev *wdev = hw->priv;
> > -	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *) &sta->drv_priv;
> > +	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *)&sta->drv_priv;
> >  	struct wfx_vif *wvif = wdev_to_wvif(wdev, sta_dev->vif_id);
> 
> Will this eventually have to conform to networking coding style? At
> what point in time is this stuff checked, if at all?

When the maintainer wants it merged to the "real" part of the kernel,
that will be needed to be checked.

thanks,

greg k-h


      reply	other threads:[~2020-03-17 12:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15  4:49 [PATCH] staging: wfx: remove unneeded spaces Lourdes Pedrajas
2020-03-17 12:45 ` [Outreachy kernel] " Stefano Brivio
2020-03-17 12:51   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317125114.GA1275972@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jerome.pouiller@silabs.com \
    --cc=lu@pplo.net \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.