[PATCH] staging: wfx: remove unneeded spaces

[PATCH] staging: wfx: remove unneeded spaces

[Lourdes Pedrajas]

Remove spaces after type casting operators in order to comply codding
standards.
Issue found with checkpatch.

Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
---
 drivers/staging/wfx/queue.c | 2 +-
 drivers/staging/wfx/sta.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c
index ed6dc8297738..39d9127ce4b9 100644
--- a/drivers/staging/wfx/queue.c
+++ b/drivers/staging/wfx/queue.c
@@ -540,7 +540,7 @@ struct hif_msg *wfx_tx_queues_get(struct wfx_dev *wdev)
 		skb = wfx_tx_queue_get(wdev, queue, tx_allowed_mask);
 		if (!skb)
 			continue;
-		hif = (struct hif_msg *) skb->data;
+		hif = (struct hif_msg *)skb->data;
 		wvif = wdev_to_wvif(wdev, hif->interface);
 		WARN_ON(!wvif);
 
diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index a60ac03fa73d..07a9991929fd 100644
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -903,7 +903,7 @@ static void wfx_update_tim_work(struct work_struct *work)
 int wfx_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, bool set)
 {
 	struct wfx_dev *wdev = hw->priv;
-	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *) &sta->drv_priv;
+	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *)&sta->drv_priv;
 	struct wfx_vif *wvif = wdev_to_wvif(wdev, sta_dev->vif_id);
 
 	schedule_work(&wvif->update_tim_work);
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] staging: wfx: remove unneeded spaces

[Stefano Brivio]

On Sun, 15 Mar 2020 05:49:22 +0100
Lourdes Pedrajas <lu@pplo.net> wrote:

> Remove spaces after type casting operators in order to comply codding

with coding...

> standards.
>
> Issue found with checkpatch.
> 
> Signed-off-by: Lourdes Pedrajas <lu@pplo.net>

Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

By the way, question for Greg:

> [...]
>
> index a60ac03fa73d..07a9991929fd 100644
> --- a/drivers/staging/wfx/sta.c
> +++ b/drivers/staging/wfx/sta.c
> @@ -903,7 +903,7 @@ static void wfx_update_tim_work(struct work_struct *work)
>  int wfx_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, bool set)
>  {
>  	struct wfx_dev *wdev = hw->priv;
> -	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *) &sta->drv_priv;
> +	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *)&sta->drv_priv;
>  	struct wfx_vif *wvif = wdev_to_wvif(wdev, sta_dev->vif_id);

Will this eventually have to conform to networking coding style? At
what point in time is this stuff checked, if at all?

-- 
Stefano

Re: [Outreachy kernel] [PATCH] staging: wfx: remove unneeded spaces

[Greg KH]

On Tue, Mar 17, 2020 at 01:45:05PM +0100, Stefano Brivio wrote:
> On Sun, 15 Mar 2020 05:49:22 +0100
> Lourdes Pedrajas <lu@pplo.net> wrote:
> 
> > Remove spaces after type casting operators in order to comply codding
> 
> with coding...
> 
> > standards.
> >
> > Issue found with checkpatch.
> > 
> > Signed-off-by: Lourdes Pedrajas <lu@pplo.net>
> 
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> 
> By the way, question for Greg:
> 
> > [...]
> >
> > index a60ac03fa73d..07a9991929fd 100644
> > --- a/drivers/staging/wfx/sta.c
> > +++ b/drivers/staging/wfx/sta.c
> > @@ -903,7 +903,7 @@ static void wfx_update_tim_work(struct work_struct *work)
> >  int wfx_set_tim(struct ieee80211_hw *hw, struct ieee80211_sta *sta, bool set)
> >  {
> >  	struct wfx_dev *wdev = hw->priv;
> > -	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *) &sta->drv_priv;
> > +	struct wfx_sta_priv *sta_dev = (struct wfx_sta_priv *)&sta->drv_priv;
> >  	struct wfx_vif *wvif = wdev_to_wvif(wdev, sta_dev->vif_id);
> 
> Will this eventually have to conform to networking coding style? At
> what point in time is this stuff checked, if at all?

When the maintainer wants it merged to the "real" part of the kernel,
that will be needed to be checked.

thanks,

greg k-h