* [PATCH] staging: comedi: dt3000: Reformat multiple line dereference
@ 2020-03-14 13:58 Deepak R Varma
2020-03-17 12:16 ` [Outreachy kernel] " Stefano Brivio
0 siblings, 1 reply; 2+ messages in thread
From: Deepak R Varma @ 2020-03-14 13:58 UTC (permalink / raw)
To: outreachy-kernel
Cc: gregkh, daniel.baluta, kieran.bingham, abbotti, hsweeten,
mh12gx2825
Reformat multiple line dereferences for &cmd->scan_begin_arg. Problem
detected by checkpatch.
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
drivers/staging/comedi/drivers/dt3000.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt3000.c b/drivers/staging/comedi/drivers/dt3000.c
index f7c365b70106..011e19161b78 100644
--- a/drivers/staging/comedi/drivers/dt3000.c
+++ b/drivers/staging/comedi/drivers/dt3000.c
@@ -439,9 +439,8 @@ static int dt3k_ai_cmdtest(struct comedi_device *dev,
if (cmd->scan_begin_src == TRIG_TIMER) {
arg = cmd->convert_arg * cmd->scan_end_arg;
- err |= comedi_check_trigger_arg_min(&cmd->
- scan_begin_arg,
- arg);
+ err |= comedi_check_trigger_arg_min(
+ &cmd->scan_begin_arg, arg);
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: comedi: dt3000: Reformat multiple line dereference
2020-03-14 13:58 [PATCH] staging: comedi: dt3000: Reformat multiple line dereference Deepak R Varma
@ 2020-03-17 12:16 ` Stefano Brivio
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2020-03-17 12:16 UTC (permalink / raw)
To: Deepak R Varma
Cc: outreachy-kernel, gregkh, daniel.baluta, kieran.bingham, abbotti,
hsweeten
On Sat, 14 Mar 2020 19:28:57 +0530
Deepak R Varma <mh12gx2825@gmail.com> wrote:
> Reformat multiple line dereferences for &cmd->scan_begin_arg. Problem
> detected by checkpatch.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt3000.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt3000.c b/drivers/staging/comedi/drivers/dt3000.c
> index f7c365b70106..011e19161b78 100644
> --- a/drivers/staging/comedi/drivers/dt3000.c
> +++ b/drivers/staging/comedi/drivers/dt3000.c
> @@ -439,9 +439,8 @@ static int dt3k_ai_cmdtest(struct comedi_device *dev,
>
> if (cmd->scan_begin_src == TRIG_TIMER) {
> arg = cmd->convert_arg * cmd->scan_end_arg;
> - err |= comedi_check_trigger_arg_min(&cmd->
> - scan_begin_arg,
> - arg);
> + err |= comedi_check_trigger_arg_min(
> + &cmd->scan_begin_arg, arg);
Isn't this introducing an equivalent issue to the one you're fixing in:
[PATCH] staging: comedi: s626: Reformat function arguments
?
That is, I think this should be more indented than that.
--
Stefano
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-17 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-14 13:58 [PATCH] staging: comedi: dt3000: Reformat multiple line dereference Deepak R Varma
2020-03-17 12:16 ` [Outreachy kernel] " Stefano Brivio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.