* [PATCH 0/2] staging: qlge: simple formatting cleanup
@ 2020-03-14 23:46 Lourdes Pedrajas
2020-03-14 23:46 ` [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces Lourdes Pedrajas
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Lourdes Pedrajas @ 2020-03-14 23:46 UTC (permalink / raw)
To: outreachy-kernel, gregkh, GR-Linux-NIC-Dev, manishc
Patchset that performs simple code cleanup in qlge driver.
Some issues found with checkpatch.
Lourdes Pedrajas (2):
staging: qlge: qlge_dbg: remove unneeded spaces
staging: qlge: qlge_main: remove unused code
drivers/staging/qlge/qlge_dbg.c | 22 +++++++++++-----------
drivers/staging/qlge/qlge_main.c | 4 ----
2 files changed, 11 insertions(+), 15 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces 2020-03-14 23:46 [PATCH 0/2] staging: qlge: simple formatting cleanup Lourdes Pedrajas @ 2020-03-14 23:46 ` Lourdes Pedrajas 2020-03-17 12:22 ` [Outreachy kernel] " Stefano Brivio 2020-03-14 23:46 ` [PATCH 2/2] staging: qlge: qlge_main: remove unused code Lourdes Pedrajas 2020-03-17 12:23 ` [Outreachy kernel] [PATCH 0/2] staging: qlge: simple formatting cleanup Stefano Brivio 2 siblings, 1 reply; 6+ messages in thread From: Lourdes Pedrajas @ 2020-03-14 23:46 UTC (permalink / raw) To: outreachy-kernel, gregkh, GR-Linux-NIC-Dev, manishc Remove spaces after type casting operators in order to comply codding standards. Issue found with checkpatch. Signed-off-by: Lourdes Pedrajas <lu@pplo.net> --- drivers/staging/qlge/qlge_dbg.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 670361873d1d..e2fa2a907d0d 100644 --- a/drivers/staging/qlge/qlge_dbg.c +++ b/drivers/staging/qlge/qlge_dbg.c @@ -1620,9 +1620,9 @@ void ql_dump_wqicb(struct wqicb *wqicb) le16_to_cpu(wqicb->cq_id_rss)); pr_err("wqicb->rid = 0x%x\n", le16_to_cpu(wqicb->rid)); pr_err("wqicb->wq_addr = 0x%llx\n", - (unsigned long long) le64_to_cpu(wqicb->addr)); + (unsigned long long)le64_to_cpu(wqicb->addr)); pr_err("wqicb->wq_cnsmr_idx_addr = 0x%llx\n", - (unsigned long long) le64_to_cpu(wqicb->cnsmr_idx_addr)); + (unsigned long long)le64_to_cpu(wqicb->cnsmr_idx_addr)); } void ql_dump_tx_ring(struct tx_ring *tx_ring) @@ -1633,7 +1633,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring) tx_ring->wq_id); pr_err("tx_ring->base = %p\n", tx_ring->wq_base); pr_err("tx_ring->base_dma = 0x%llx\n", - (unsigned long long) tx_ring->wq_base_dma); + (unsigned long long)tx_ring->wq_base_dma); pr_err("tx_ring->cnsmr_idx_sh_reg, addr = 0x%p, value = %d\n", tx_ring->cnsmr_idx_sh_reg, tx_ring->cnsmr_idx_sh_reg @@ -1686,21 +1686,21 @@ void ql_dump_cqicb(struct cqicb *cqicb) pr_err("cqicb->flags = %x\n", cqicb->flags); pr_err("cqicb->len = %d\n", le16_to_cpu(cqicb->len)); pr_err("cqicb->addr = 0x%llx\n", - (unsigned long long) le64_to_cpu(cqicb->addr)); + (unsigned long long)le64_to_cpu(cqicb->addr)); pr_err("cqicb->prod_idx_addr = 0x%llx\n", - (unsigned long long) le64_to_cpu(cqicb->prod_idx_addr)); + (unsigned long long)le64_to_cpu(cqicb->prod_idx_addr)); pr_err("cqicb->pkt_delay = 0x%.04x\n", le16_to_cpu(cqicb->pkt_delay)); pr_err("cqicb->irq_delay = 0x%.04x\n", le16_to_cpu(cqicb->irq_delay)); pr_err("cqicb->lbq_addr = 0x%llx\n", - (unsigned long long) le64_to_cpu(cqicb->lbq_addr)); + (unsigned long long)le64_to_cpu(cqicb->lbq_addr)); pr_err("cqicb->lbq_buf_size = 0x%.04x\n", le16_to_cpu(cqicb->lbq_buf_size)); pr_err("cqicb->lbq_len = 0x%.04x\n", le16_to_cpu(cqicb->lbq_len)); pr_err("cqicb->sbq_addr = 0x%llx\n", - (unsigned long long) le64_to_cpu(cqicb->sbq_addr)); + (unsigned long long)le64_to_cpu(cqicb->sbq_addr)); pr_err("cqicb->sbq_buf_size = 0x%.04x\n", le16_to_cpu(cqicb->sbq_buf_size)); pr_err("cqicb->sbq_len = 0x%.04x\n", @@ -1728,7 +1728,7 @@ void ql_dump_rx_ring(struct rx_ring *rx_ring) pr_err("rx_ring->cqicb = %p\n", &rx_ring->cqicb); pr_err("rx_ring->cq_base = %p\n", rx_ring->cq_base); pr_err("rx_ring->cq_base_dma = %llx\n", - (unsigned long long) rx_ring->cq_base_dma); + (unsigned long long)rx_ring->cq_base_dma); pr_err("rx_ring->cq_size = %d\n", rx_ring->cq_size); pr_err("rx_ring->cq_len = %d\n", rx_ring->cq_len); pr_err("rx_ring->prod_idx_sh_reg, addr = 0x%p, value = %d\n", @@ -1736,7 +1736,7 @@ void ql_dump_rx_ring(struct rx_ring *rx_ring) rx_ring->prod_idx_sh_reg ? ql_read_sh_reg(rx_ring->prod_idx_sh_reg) : 0); pr_err("rx_ring->prod_idx_sh_reg_dma = %llx\n", - (unsigned long long) rx_ring->prod_idx_sh_reg_dma); + (unsigned long long)rx_ring->prod_idx_sh_reg_dma); pr_err("rx_ring->cnsmr_idx_db_reg = %p\n", rx_ring->cnsmr_idx_db_reg); pr_err("rx_ring->cnsmr_idx = %d\n", rx_ring->cnsmr_idx); @@ -1959,7 +1959,7 @@ void ql_dump_ib_mac_rsp(struct ib_mac_iocb_rsp *ib_mac_rsp) pr_err("data_len = %d\n", le32_to_cpu(ib_mac_rsp->data_len)); pr_err("data_addr = 0x%llx\n", - (unsigned long long) le64_to_cpu(ib_mac_rsp->data_addr)); + (unsigned long long)le64_to_cpu(ib_mac_rsp->data_addr)); if (ib_mac_rsp->flags3 & IB_MAC_IOCB_RSP_RSS_MASK) pr_err("rss = %x\n", le32_to_cpu(ib_mac_rsp->rss)); @@ -1976,7 +1976,7 @@ void ql_dump_ib_mac_rsp(struct ib_mac_iocb_rsp *ib_mac_rsp) pr_err("hdr length = %d\n", le32_to_cpu(ib_mac_rsp->hdr_len)); pr_err("hdr addr = 0x%llx\n", - (unsigned long long) le64_to_cpu(ib_mac_rsp->hdr_addr)); + (unsigned long long)le64_to_cpu(ib_mac_rsp->hdr_addr)); } } #endif -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces 2020-03-14 23:46 ` [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces Lourdes Pedrajas @ 2020-03-17 12:22 ` Stefano Brivio 2020-03-17 17:16 ` Lourdes Pedrajas 0 siblings, 1 reply; 6+ messages in thread From: Stefano Brivio @ 2020-03-17 12:22 UTC (permalink / raw) To: Lourdes Pedrajas; +Cc: outreachy-kernel, gregkh, GR-Linux-NIC-Dev, manishc On Sun, 15 Mar 2020 00:46:07 +0100 Lourdes Pedrajas <lu@pplo.net> wrote: > Remove spaces after type casting operators in order to comply codding with coding? > standards. I personally don't care about typos in commit messages unless it's changes that fix typos, though. -- Stefano ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces 2020-03-17 12:22 ` [Outreachy kernel] " Stefano Brivio @ 2020-03-17 17:16 ` Lourdes Pedrajas 0 siblings, 0 replies; 6+ messages in thread From: Lourdes Pedrajas @ 2020-03-17 17:16 UTC (permalink / raw) To: Stefano Brivio; +Cc: outreachy-kernel, gregkh, GR-Linux-NIC-Dev, manishc On Tue, Mar 17, 2020 at 01:22:47PM +0100, Stefano Brivio wrote: > On Sun, 15 Mar 2020 00:46:07 +0100 > Lourdes Pedrajas <lu@pplo.net> wrote: > > > Remove spaces after type casting operators in order to comply codding > > with coding? > > > standards. > > I personally don't care about typos in commit messages unless it's > changes that fix typos, though. > > -- > Stefano > Agreed, that was funny. I will take more care the next time! :) Thank you, Lourdes ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] staging: qlge: qlge_main: remove unused code 2020-03-14 23:46 [PATCH 0/2] staging: qlge: simple formatting cleanup Lourdes Pedrajas 2020-03-14 23:46 ` [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces Lourdes Pedrajas @ 2020-03-14 23:46 ` Lourdes Pedrajas 2020-03-17 12:23 ` [Outreachy kernel] [PATCH 0/2] staging: qlge: simple formatting cleanup Stefano Brivio 2 siblings, 0 replies; 6+ messages in thread From: Lourdes Pedrajas @ 2020-03-14 23:46 UTC (permalink / raw) To: outreachy-kernel, gregkh, GR-Linux-NIC-Dev, manishc Remove commented out lines. They are not used since 2009. Signed-off-by: Lourdes Pedrajas <lu@pplo.net> --- drivers/staging/qlge/qlge_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index c712e1af90de..f997993f3c26 100644 --- a/drivers/staging/qlge/qlge_main.c +++ b/drivers/staging/qlge/qlge_main.c @@ -53,14 +53,10 @@ MODULE_VERSION(DRV_VERSION); static const u32 default_msg = NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK | -/* NETIF_MSG_TIMER | */ NETIF_MSG_IFDOWN | NETIF_MSG_IFUP | NETIF_MSG_RX_ERR | NETIF_MSG_TX_ERR | -/* NETIF_MSG_TX_QUEUED | */ -/* NETIF_MSG_INTR | NETIF_MSG_TX_DONE | NETIF_MSG_RX_STATUS | */ -/* NETIF_MSG_PKTDATA | */ NETIF_MSG_HW | NETIF_MSG_WOL | 0; static int debug = -1; /* defaults above */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/2] staging: qlge: simple formatting cleanup 2020-03-14 23:46 [PATCH 0/2] staging: qlge: simple formatting cleanup Lourdes Pedrajas 2020-03-14 23:46 ` [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces Lourdes Pedrajas 2020-03-14 23:46 ` [PATCH 2/2] staging: qlge: qlge_main: remove unused code Lourdes Pedrajas @ 2020-03-17 12:23 ` Stefano Brivio 2 siblings, 0 replies; 6+ messages in thread From: Stefano Brivio @ 2020-03-17 12:23 UTC (permalink / raw) To: Lourdes Pedrajas; +Cc: outreachy-kernel, gregkh, GR-Linux-NIC-Dev, manishc On Sun, 15 Mar 2020 00:46:06 +0100 Lourdes Pedrajas <lu@pplo.net> wrote: > Patchset that performs simple code cleanup in qlge driver. > Some issues found with checkpatch. > > Lourdes Pedrajas (2): > staging: qlge: qlge_dbg: remove unneeded spaces > staging: qlge: qlge_main: remove unused code For the series, Reviewed-by: Stefano Brivio <sbrivio@redhat.com> -- Stefano ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-17 17:16 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-14 23:46 [PATCH 0/2] staging: qlge: simple formatting cleanup Lourdes Pedrajas 2020-03-14 23:46 ` [PATCH 1/2] staging: qlge: qlge_dbg: remove unneeded spaces Lourdes Pedrajas 2020-03-17 12:22 ` [Outreachy kernel] " Stefano Brivio 2020-03-17 17:16 ` Lourdes Pedrajas 2020-03-14 23:46 ` [PATCH 2/2] staging: qlge: qlge_main: remove unused code Lourdes Pedrajas 2020-03-17 12:23 ` [Outreachy kernel] [PATCH 0/2] staging: qlge: simple formatting cleanup Stefano Brivio
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.