All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Rob Herring <robh@kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH v1 3/3] dt-bindings: display: grammar fixes in panel/
Date: Tue, 17 Mar 2020 21:25:22 +0200	[thread overview]
Message-ID: <20200317192522.GD2527@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200314153047.2486-4-sam@ravnborg.org>

Hi Sam,

Thank you for the patch.

On Sat, Mar 14, 2020 at 04:30:47PM +0100, Sam Ravnborg wrote:
> Fix a few grammar/editorial issues spotted by Laurent Pinchart.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/display/panel/display-timings.yaml           | 8 ++++----
>  .../devicetree/bindings/display/panel/panel-common.yaml   | 4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/display-timings.yaml b/Documentation/devicetree/bindings/display/panel/display-timings.yaml
> index c8c0c9cb0492..56903ded005e 100644
> --- a/Documentation/devicetree/bindings/display/panel/display-timings.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/display-timings.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/display/panel/display-timings.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: display timing bindings
> +title: display timings bindings
>  
>  maintainers:
>    - Thierry Reding <thierry.reding@gmail.com>
> @@ -14,7 +14,7 @@ maintainers:
>  description: |
>    A display panel may be able to handle several display timings,
>    with different resolutions.
> -  The display-timings node makes it possible to specify the timing
> +  The display-timings node makes it possible to specify the timings
>    and to specify the timing that is native for the display.
>  
>  properties:
> @@ -25,8 +25,8 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/phandle
>      description: |
>        The default display timing is the one specified as native-mode.
> -      If no native-mode is specified then the first node is assumed the
> -      native mode.
> +      If no native-mode is specified then the first node is assumed
> +      to be the native mode.
>  
>  patternProperties:
>    "^timing":
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index ed051ba12084..dee4faffd204 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -63,9 +63,9 @@ properties:
>  
>    display-timings:
>      description:
> -      Some display panels supports several resolutions with different timing.
> +      Some display panels supports several resolutions with different timings.

s/supports/support/

>        The display-timings bindings supports specifying several timings and
> -      optional specify which is the native mode.
> +      optionally specify which is the native mode.

s/specify/specifying/ ?

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>      allOf:
>        - $ref: display-timings.yaml#
>  

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 3/3] dt-bindings: display: grammar fixes in panel/
Date: Tue, 17 Mar 2020 21:25:22 +0200	[thread overview]
Message-ID: <20200317192522.GD2527@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200314153047.2486-4-sam@ravnborg.org>

Hi Sam,

Thank you for the patch.

On Sat, Mar 14, 2020 at 04:30:47PM +0100, Sam Ravnborg wrote:
> Fix a few grammar/editorial issues spotted by Laurent Pinchart.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/display/panel/display-timings.yaml           | 8 ++++----
>  .../devicetree/bindings/display/panel/panel-common.yaml   | 4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/display-timings.yaml b/Documentation/devicetree/bindings/display/panel/display-timings.yaml
> index c8c0c9cb0492..56903ded005e 100644
> --- a/Documentation/devicetree/bindings/display/panel/display-timings.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/display-timings.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/display/panel/display-timings.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: display timing bindings
> +title: display timings bindings
>  
>  maintainers:
>    - Thierry Reding <thierry.reding@gmail.com>
> @@ -14,7 +14,7 @@ maintainers:
>  description: |
>    A display panel may be able to handle several display timings,
>    with different resolutions.
> -  The display-timings node makes it possible to specify the timing
> +  The display-timings node makes it possible to specify the timings
>    and to specify the timing that is native for the display.
>  
>  properties:
> @@ -25,8 +25,8 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/phandle
>      description: |
>        The default display timing is the one specified as native-mode.
> -      If no native-mode is specified then the first node is assumed the
> -      native mode.
> +      If no native-mode is specified then the first node is assumed
> +      to be the native mode.
>  
>  patternProperties:
>    "^timing":
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index ed051ba12084..dee4faffd204 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -63,9 +63,9 @@ properties:
>  
>    display-timings:
>      description:
> -      Some display panels supports several resolutions with different timing.
> +      Some display panels supports several resolutions with different timings.

s/supports/support/

>        The display-timings bindings supports specifying several timings and
> -      optional specify which is the native mode.
> +      optionally specify which is the native mode.

s/specify/specifying/ ?

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>      allOf:
>        - $ref: display-timings.yaml#
>  

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-03-17 19:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-14 15:30 [PATCH v1 0/3] drm: drop data-mapping property from panel-dpi Sam Ravnborg
2020-03-14 15:30 ` Sam Ravnborg
2020-03-14 15:30 ` [PATCH v1 1/3] dt-bindings: display: drop data-mapping " Sam Ravnborg
2020-03-14 15:30   ` Sam Ravnborg
2020-03-17  8:49   ` Maxime Ripard
2020-03-17  8:49     ` Maxime Ripard
2020-03-17 11:22     ` Sam Ravnborg
2020-03-17 11:22       ` Sam Ravnborg
2020-03-19  9:55       ` Maxime Ripard
2020-03-19  9:55         ` Maxime Ripard
2020-03-17 19:23   ` Laurent Pinchart
2020-03-17 19:23     ` Laurent Pinchart
2020-03-14 15:30 ` [PATCH v1 2/3] drm/panel-simple: drop use of data-mapping property Sam Ravnborg
2020-03-14 15:30   ` Sam Ravnborg
2020-03-17 19:23   ` Laurent Pinchart
2020-03-17 19:23     ` Laurent Pinchart
2020-03-14 15:30 ` [PATCH v1 3/3] dt-bindings: display: grammar fixes in panel/ Sam Ravnborg
2020-03-14 15:30   ` Sam Ravnborg
2020-03-17 19:25   ` Laurent Pinchart [this message]
2020-03-17 19:25     ` Laurent Pinchart
2020-03-21 21:04     ` Sam Ravnborg
2020-03-21 21:04       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200317192522.GD2527@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.