All of lore.kernel.org
 help / color / mirror / Atom feed
* [nbd168-wireless:mt76 12/35] drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:147:5: sparse: sparse: symbol 'mt7615_mcu_wait_response' was not declared. Should it be static?
@ 2020-03-17 21:50 kbuild test robot
  2020-03-17 21:51 ` [RFC PATCH nbd168-wireless] mt76: mt7615: mt7615_mcu_wait_response() can be static kbuild test robot
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2020-03-17 21:50 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

tree:   https://github.com/nbd168/wireless mt76
head:   f40ac0f3d3c0e2b17185e1707a3b4552e5187dd5
commit: 044a43256a357e43bb3669ed46346f273a8d3e9c [12/35] mt76: mt7615: introduce mt7615_mcu_wait_response
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-180-g0558317d-dirty
        git checkout 044a43256a357e43bb3669ed46346f273a8d3e9c
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:147:5: sparse: sparse: symbol 'mt7615_mcu_wait_response' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [RFC PATCH nbd168-wireless] mt76: mt7615: mt7615_mcu_wait_response() can be static
  2020-03-17 21:50 [nbd168-wireless:mt76 12/35] drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:147:5: sparse: sparse: symbol 'mt7615_mcu_wait_response' was not declared. Should it be static? kbuild test robot
@ 2020-03-17 21:51 ` kbuild test robot
  2020-03-17 21:58   ` Lorenzo Bianconi
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2020-03-17 21:51 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]


Fixes: 044a43256a35 ("mt76: mt7615: introduce mt7615_mcu_wait_response")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 mcu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index a4e971d7f6a779..15f57d355a7feb 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -144,7 +144,7 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
 	return ret;
 }
 
-int mt7615_mcu_wait_response(struct mt7615_dev *dev, int cmd, int seq)
+static int mt7615_mcu_wait_response(struct mt7615_dev *dev, int cmd, int seq)
 {
 	unsigned long expires = jiffies + 20 * HZ;
 	struct sk_buff *skb;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RFC PATCH nbd168-wireless] mt76: mt7615: mt7615_mcu_wait_response() can be static
  2020-03-17 21:51 ` [RFC PATCH nbd168-wireless] mt76: mt7615: mt7615_mcu_wait_response() can be static kbuild test robot
@ 2020-03-17 21:58   ` Lorenzo Bianconi
  0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2020-03-17 21:58 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

> 
> Fixes: 044a43256a35 ("mt76: mt7615: introduce mt7615_mcu_wait_response")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  mcu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> index a4e971d7f6a779..15f57d355a7feb 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> @@ -144,7 +144,7 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
>  	return ret;
>  }
>  
> -int mt7615_mcu_wait_response(struct mt7615_dev *dev, int cmd, int seq)
> +static int mt7615_mcu_wait_response(struct mt7615_dev *dev, int cmd, int seq)

mt7615_mcu_wait_response will be reused adding usb support.

Regards,
Lorenzo

>  {
>  	unsigned long expires = jiffies + 20 * HZ;
>  	struct sk_buff *skb;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-17 21:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-17 21:50 [nbd168-wireless:mt76 12/35] drivers/net/wireless/mediatek/mt76/mt7615/mcu.c:147:5: sparse: sparse: symbol 'mt7615_mcu_wait_response' was not declared. Should it be static? kbuild test robot
2020-03-17 21:51 ` [RFC PATCH nbd168-wireless] mt76: mt7615: mt7615_mcu_wait_response() can be static kbuild test robot
2020-03-17 21:58   ` Lorenzo Bianconi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.