From: Eddie James <eajames@linux.ibm.com>
To: openbmc@lists.ozlabs.org
Subject: [PATCH linux dev-5.4 15/16] soc: aspeed: xdma: Disable PCI AHB bridge during probe
Date: Tue, 17 Mar 2020 17:13:35 -0500 [thread overview]
Message-ID: <20200317221336.19973-16-eajames@linux.ibm.com> (raw)
In-Reply-To: <20200317221336.19973-1-eajames@linux.ibm.com>
The XDMA engine cannot function unless the PCI AHB bridge is disabled,
so do so during the probe.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
drivers/soc/aspeed/aspeed-xdma.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/soc/aspeed/aspeed-xdma.c b/drivers/soc/aspeed/aspeed-xdma.c
index 6bc1357445bc..525214ce2c8b 100644
--- a/drivers/soc/aspeed/aspeed-xdma.c
+++ b/drivers/soc/aspeed/aspeed-xdma.c
@@ -30,6 +30,12 @@
#define DEVICE_NAME "aspeed-xdma"
+#define SCU_AST2600_MISC_CTRL 0x0c0
+#define SCU_AST2600_MISC_CTRL_DISABLE_PCI BIT(8)
+
+#define SCU_AST2600_DBG_CTRL 0x0c8
+#define SCU_AST2600_DBG_CTRL_DISABLE_PCI BIT(0)
+
#define SCU_AST2500_PCIE_CONF 0x180
#define SCU_AST2600_PCIE_CONF 0xc20
#define SCU_PCIE_CONF_VGA_EN BIT(0)
@@ -188,6 +194,8 @@ struct aspeed_xdma;
struct aspeed_xdma_chip {
u32 control;
u32 scu_bmc_class;
+ u32 scu_dbg_ctrl;
+ u32 scu_misc_ctrl;
u32 scu_pcie_conf;
u32 sdmc_remap;
unsigned int queue_entry_size;
@@ -798,6 +806,16 @@ static int aspeed_xdma_init_scu(struct aspeed_xdma *ctx, struct device *dev)
regmap_update_bits(scu, ctx->chip->scu_pcie_conf, bmc | vga,
selection);
+
+ if (ctx->chip->scu_dbg_ctrl)
+ regmap_update_bits(scu, ctx->chip->scu_dbg_ctrl,
+ SCU_AST2600_DBG_CTRL_DISABLE_PCI,
+ SCU_AST2600_DBG_CTRL_DISABLE_PCI);
+
+ if (ctx->chip->scu_misc_ctrl)
+ regmap_update_bits(scu, ctx->chip->scu_misc_ctrl,
+ SCU_AST2600_MISC_CTRL_DISABLE_PCI,
+ SCU_AST2600_MISC_CTRL_DISABLE_PCI);
} else {
dev_warn(dev, "Unable to configure PCIe: %ld; continuing.\n",
PTR_ERR(scu));
@@ -1000,6 +1018,8 @@ static const struct aspeed_xdma_chip aspeed_ast2500_xdma_chip = {
XDMA_AST2500_CTRL_DS_DIRTY | XDMA_AST2500_CTRL_DS_SIZE_256 |
XDMA_AST2500_CTRL_DS_TIMEOUT | XDMA_AST2500_CTRL_DS_CHECK_ID,
.scu_bmc_class = SCU_AST2500_BMC_CLASS_REV,
+ .scu_dbg_ctrl = 0,
+ .scu_misc_ctrl = 0,
.scu_pcie_conf = SCU_AST2500_PCIE_CONF,
.sdmc_remap = SDMC_AST2500_REMAP_PCIE | SDMC_AST2500_REMAP_XDMA,
.queue_entry_size = XDMA_AST2500_QUEUE_ENTRY_SIZE,
@@ -1023,6 +1043,8 @@ static const struct aspeed_xdma_chip aspeed_ast2600_xdma_chip = {
.control = XDMA_AST2600_CTRL_US_COMP | XDMA_AST2600_CTRL_DS_COMP |
XDMA_AST2600_CTRL_DS_DIRTY | XDMA_AST2600_CTRL_DS_SIZE_256,
.scu_bmc_class = SCU_AST2600_BMC_CLASS_REV,
+ .scu_dbg_ctrl = SCU_AST2600_DBG_CTRL,
+ .scu_misc_ctrl = SCU_AST2600_MISC_CTRL,
.scu_pcie_conf = SCU_AST2600_PCIE_CONF,
.sdmc_remap = SDMC_AST2600_REMAP_XDMA,
.queue_entry_size = XDMA_AST2600_QUEUE_ENTRY_SIZE,
--
2.24.0
next prev parent reply other threads:[~2020-03-17 22:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 22:13 [PATCH linux dev-5.4 00/16] Aspeed: Add XDMA and SCU interrupt controller drivers Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 01/16] dt-bindings: interrupt-controller: Add Aspeed SCU interrupt controller Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 02/16] irqchip: " Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 03/16] ARM: dts: aspeed: ast2500: Add " Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 04/16] ARM: dts: aspeed: ast2600: Add SCU interrupt controllers Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 05/16] dt-bindings: soc: Add Aspeed XDMA Engine Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 06/16] soc: aspeed: Add XDMA Engine Driver Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 07/16] soc: aspeed: xdma: Add user interface Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 08/16] soc: aspeed: xdma: Add reset ioctl Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 09/16] ARM: dts: aspeed: ast2500: Add XDMA Engine Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 10/16] ARM: dts: aspeed: ast2600: " Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 11/16] ARM: dts: aspeed: witherspoon: Enable " Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 12/16] ARM: dts: aspeed: tacoma: Enable XDMA engine Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 13/16] soc: aspeed: xdma: Add memory controller configuration Eddie James
2020-03-17 22:13 ` [PATCH linux dev-5.4 14/16] soc: aspeed: xdma: Add root complex reset Eddie James
2020-03-17 22:13 ` Eddie James [this message]
2020-03-17 22:13 ` [PATCH linux dev-5.4 16/16] soc: aspeed: xdma: Fix BMC PCI device class and revision for AST2600 Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317221336.19973-16-eajames@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.