Re: [Outreachy kernel] Outreachy patches caught up on.

Re: [Outreachy kernel] Outreachy patches caught up on.

[evan chime]

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

On Sat, 26 Oct 2019 at 19:50, Greg KH <gregkh@linuxfoundation.org> wrote:

> Hi all,
>
> I'm now caught up on all submitted outreachy patches that I can apply.
>
> If you have not gotten an email from my patch system saying that your
> patch was applied, consider it lost, and please rebase and resend it.
>
> thanks,
>
> greg k-h


Cheers



>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20191026185009.GA804847%40kroah.com
> .
>

[-- Attachment #2: Type: text/html, Size: 1484 bytes --]

Outreachy patches caught up on.

[Greg KH]

Hi all,

I'm now caught up on all submitted outreachy patches that I can apply.

If you have not gotten an email from my patch system saying that your
patch was applied, consider it lost, and please rebase and resend it.

thanks,

greg k-h

Re: [Outreachy kernel] Outreachy patches caught up on.

[DEEPAK VARMA]

On Tue, Mar 17, 2020 at 03:09:51PM +0100, Greg KH wrote:
> Hi all,
> 
> I'm now caught up on all submitted outreachy patches that I can apply.

Thank you Greg for your time.

> 
> If you have not gotten an email from my patch system saying that your
> patch was applied, consider it lost, and please rebase and resend it.

If we have a patch where the review comments by the experts were not
implemented, but it was accepted by you, what should we do with those
now? Would you suggest sending in a fresh patch with the comments
implemented or a vn in continuation of the old patch?

> 
> thanks,
> 
> greg k-h
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200317140951.GA1362367%40kroah.com.

Re: [Outreachy kernel] Outreachy patches caught up on.

[Greg KH]

On Wed, Mar 18, 2020 at 12:55:31AM +0530, DEEPAK VARMA wrote:
> > If you have not gotten an email from my patch system saying that your
> > patch was applied, consider it lost, and please rebase and resend it.
> 
> If we have a patch where the review comments by the experts were not
> implemented, but it was accepted by you, what should we do with those
> now? Would you suggest sending in a fresh patch with the comments
> implemented or a vn in continuation of the old patch?

Consider yourself lucky that I took the patch :)

You can send a follow-on patch, if the changes requested was in the
code, not the subject/changelog areas.  But as my tree is not rebased,
you can't send a "please replace my old patch with this one instead"
request as that's impossible for me to do.

thanks,

greg k-h

Re: [Outreachy kernel] Outreachy patches caught up on.

[DEEPAK VARMA]

On Tue, Mar 17, 2020 at 08:32:31PM +0100, Greg KH wrote:
> On Wed, Mar 18, 2020 at 12:55:31AM +0530, DEEPAK VARMA wrote:
> > > If you have not gotten an email from my patch system saying that your
> > > patch was applied, consider it lost, and please rebase and resend it.
> > 
> > If we have a patch where the review comments by the experts were not
> > implemented, but it was accepted by you, what should we do with those
> > now? Would you suggest sending in a fresh patch with the comments
> > implemented or a vn in continuation of the old patch?
> 
> Consider yourself lucky that I took the patch :)

Thank you Greg :)

> 
> You can send a follow-on patch, if the changes requested was in the
> code, not the subject/changelog areas.  But as my tree is not rebased,
> you can't send a "please replace my old patch with this one instead"
> request as that's impossible for me to do.
> 

That makes sense. Will do as necessary.

> thanks,
> 
> greg k-h

Re: [Outreachy kernel] Outreachy patches caught up on.

[John Wyatt]

On Fri, 2020-03-20 at 15:14 +0100, Greg KH wrote:
> Hi all,
> 
> I'm now caught up on all submitted outreachy patches that I can
> apply.
> 
> If you have not gotten an email from my patch system saying that your
> patch was applied, consider it lost, and please rebase and resend it.

Hi Greg,

I just sent my patch in ~10 hours ago.

Do I need to rebase/resend it?

If I do, should I make it a v2?

Apologies if you already answered this earlier in the mailing list.

> 
> thanks,
> 
> greg k-h
> 

Re: [Outreachy kernel] Outreachy patches caught up on.

[Greg KH]

On Fri, Mar 20, 2020 at 11:33:41AM -0700, John Wyatt wrote:
> On Fri, 2020-03-20 at 15:14 +0100, Greg KH wrote:
> > Hi all,
> > 
> > I'm now caught up on all submitted outreachy patches that I can
> > apply.
> > 
> > If you have not gotten an email from my patch system saying that your
> > patch was applied, consider it lost, and please rebase and resend it.
> 
> Hi Greg,
> 
> I just sent my patch in ~10 hours ago.
> 
> Do I need to rebase/resend it?
> 
> If I do, should I make it a v2?
> 
> Apologies if you already answered this earlier in the mailing list.

Julia provided comments on what you need to do to fix up your patch,
please follow them and resend a v2.

thanks,

greg k-h

Re: [Outreachy kernel] Outreachy patches caught up on.

[John Wyatt]

On Sat, 2020-03-21 at 07:51 +0100, Greg KH wrote:
> On Fri, Mar 20, 2020 at 11:33:41AM -0700, John Wyatt wrote:
> > On Fri, 2020-03-20 at 15:14 +0100, Greg KH wrote:
> > > Hi all,
> > > 
> > > I'm now caught up on all submitted outreachy patches that I can
> > > apply.
> > > 
> > > If you have not gotten an email from my patch system saying that
> > > your
> > > patch was applied, consider it lost, and please rebase and resend
> > > it.
> > 
> > Hi Greg,
> > 
> > I just sent my patch in ~10 hours ago.
> > 
> > Do I need to rebase/resend it?
> > 
> > If I do, should I make it a v2?
> > 
> > Apologies if you already answered this earlier in the mailing list.
> 
> Julia provided comments on what you need to do to fix up your patch,
> please follow them and resend a v2.

I believe I did in v2. The code wasn't at issue-the description was?

Julia-please advise.

https://groups.google.com/forum/#!original/outreachy-kernel/RqwZpdvL8Js/tIbnooMBBQAJ

Re: [Outreachy kernel] Outreachy patches caught up on.

[Greg KH]

On Sat, Mar 21, 2020 at 07:51:34AM +0100, Greg KH wrote:
> On Fri, Mar 20, 2020 at 11:33:41AM -0700, John Wyatt wrote:
> > On Fri, 2020-03-20 at 15:14 +0100, Greg KH wrote:
> > > Hi all,
> > > 
> > > I'm now caught up on all submitted outreachy patches that I can
> > > apply.
> > > 
> > > If you have not gotten an email from my patch system saying that your
> > > patch was applied, consider it lost, and please rebase and resend it.
> > 
> > Hi Greg,
> > 
> > I just sent my patch in ~10 hours ago.
> > 
> > Do I need to rebase/resend it?
> > 
> > If I do, should I make it a v2?
> > 
> > Apologies if you already answered this earlier in the mailing list.
> 
> Julia provided comments on what you need to do to fix up your patch,
> please follow them and resend a v2.

And you did just that, nevermind :)

Re: [Outreachy kernel] Outreachy patches caught up on.

[John Wyatt]

> > > I just sent my patch in ~10 hours ago.
> > > 
> > > Do I need to rebase/resend it?
> > > 
> > > If I do, should I make it a v2?
> > > 
> > > Apologies if you already answered this earlier in the mailing
> > > list.
> > 
> > Julia provided comments on what you need to do to fix up your
> > patch,
> > please follow them and resend a v2.
> 
> And you did just that, nevermind :)

:)

For future reference, if I send in a patch around 10 hours before you
ask to rebase-should I rebase?

If I do rebase, should I mark it as a v2?

Thank you for your time.

Re: [Outreachy kernel] Outreachy patches caught up on.

[Greg KH]

On Sat, Mar 21, 2020 at 12:26:34AM -0700, John Wyatt wrote:
> 
> > > > I just sent my patch in ~10 hours ago.
> > > > 
> > > > Do I need to rebase/resend it?
> > > > 
> > > > If I do, should I make it a v2?
> > > > 
> > > > Apologies if you already answered this earlier in the mailing
> > > > list.
> > > 
> > > Julia provided comments on what you need to do to fix up your
> > > patch,
> > > please follow them and resend a v2.
> > 
> > And you did just that, nevermind :)
> 
> :)
> 
> For future reference, if I send in a patch around 10 hours before you
> ask to rebase-should I rebase?

Once I send out this "I have caught up with all patches" email, consider
my queue empty, so you need to fix up anything I have not applied by
then.

> If I do rebase, should I mark it as a v2?

If you change something, yes.  If you change nothing, it is a "resend",
but say why you are resending it.  It could be as simple as "Greg missed
my previous patch", but the odds of that are kind of low :)

thanks,

greg k-h

Re: [Outreachy kernel] Outreachy patches caught up on.

[Sam Muhammed]

On Sat, 2020-03-21 at 08:41 +0100, Greg KH wrote:
> On Sat, Mar 21, 2020 at 12:26:34AM -0700, John Wyatt wrote:
> > 
> > > > > I just sent my patch in ~10 hours ago.
> > > > > 
> > > > > Do I need to rebase/resend it?
> > > > > 
> > > > > If I do, should I make it a v2?
> > > > > 
> > > > > Apologies if you already answered this earlier in the mailing
> > > > > list.
> > > > 
> > > > Julia provided comments on what you need to do to fix up your
> > > > patch,
> > > > please follow them and resend a v2.
> > > 
> > > And you did just that, nevermind :)
> > 
> > :)
> > 
> > For future reference, if I send in a patch around 10 hours before you
> > ask to rebase-should I rebase?
> 
> Once I send out this "I have caught up with all patches" email, consider
> my queue empty, so you need to fix up anything I have not applied by
> then.
> 

Newbie question, Ive sent two patches around ~12hrs ago
both are reviewed and acked, so i guess they are accepted?
when should i be concerned if they're lost ?

Sam

> > If I do rebase, should I mark it as a v2?
> 
> If you change something, yes.  If you change nothing, it is a "resend",
> but say why you are resending it.  It could be as simple as "Greg missed
> my previous patch", but the odds of that are kind of low :)
> 
> thanks,
> 
> greg k-h
> 

Re: [Outreachy kernel] Outreachy patches caught up on.

[Julia Lawall]

On Mon, 23 Mar 2020, Sam Muhammed wrote:

> On Sat, 2020-03-21 at 08:41 +0100, Greg KH wrote:
> > On Sat, Mar 21, 2020 at 12:26:34AM -0700, John Wyatt wrote:
> > >
> > > > > > I just sent my patch in ~10 hours ago.
> > > > > >
> > > > > > Do I need to rebase/resend it?
> > > > > >
> > > > > > If I do, should I make it a v2?
> > > > > >
> > > > > > Apologies if you already answered this earlier in the mailing
> > > > > > list.
> > > > >
> > > > > Julia provided comments on what you need to do to fix up your
> > > > > patch,
> > > > > please follow them and resend a v2.
> > > >
> > > > And you did just that, nevermind :)
> > >
> > > :)
> > >
> > > For future reference, if I send in a patch around 10 hours before you
> > > ask to rebase-should I rebase?
> >
> > Once I send out this "I have caught up with all patches" email, consider
> > my queue empty, so you need to fix up anything I have not applied by
> > then.
> >
>
> Newbie question, Ive sent two patches around ~12hrs ago
> both are reviewed and acked, so i guess they are accepted?
> when should i be concerned if they're lost ?

Patches are accepted when Greg takes them.

You should be concerned when Greg sends a message saying that he is caught
up, and you don't see your patch in his tree.

julia

>
> Sam
>
> > > If I do rebase, should I mark it as a v2?
> >
> > If you change something, yes.  If you change nothing, it is a "resend",
> > but say why you are resending it.  It could be as simple as "Greg missed
> > my previous patch", but the odds of that are kind of low :)
> >
> > thanks,
> >
> > greg k-h
> >
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/dff9ed66458ea26f0b3b6b588b8fbc0f477bb43f.camel%40gmail.com.
>

Re: [Outreachy kernel] Outreachy patches caught up on.

[Greg KH]

On Mon, Mar 23, 2020 at 05:56:28AM -0400, Sam Muhammed wrote:
> On Sat, 2020-03-21 at 08:41 +0100, Greg KH wrote:
> > On Sat, Mar 21, 2020 at 12:26:34AM -0700, John Wyatt wrote:
> > > 
> > > > > > I just sent my patch in ~10 hours ago.
> > > > > > 
> > > > > > Do I need to rebase/resend it?
> > > > > > 
> > > > > > If I do, should I make it a v2?
> > > > > > 
> > > > > > Apologies if you already answered this earlier in the mailing
> > > > > > list.
> > > > > 
> > > > > Julia provided comments on what you need to do to fix up your
> > > > > patch,
> > > > > please follow them and resend a v2.
> > > > 
> > > > And you did just that, nevermind :)
> > > 
> > > :)
> > > 
> > > For future reference, if I send in a patch around 10 hours before you
> > > ask to rebase-should I rebase?
> > 
> > Once I send out this "I have caught up with all patches" email, consider
> > my queue empty, so you need to fix up anything I have not applied by
> > then.
> > 
> 
> Newbie question, Ive sent two patches around ~12hrs ago
> both are reviewed and acked, so i guess they are accepted?
> when should i be concerned if they're lost ?

As Julia said, they will end up in my tree, if not, then worry.  You
will get an email from my scripts if a patch is accepted.

thanks,

greg k-h