* [PATCH] drm/hisilicon: Drop unused #include
@ 2020-03-18 7:31 Daniel Vetter
2020-03-18 8:06 ` Sam Ravnborg
2020-03-18 11:09 ` Laurent Pinchart
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Vetter @ 2020-03-18 7:31 UTC (permalink / raw)
To: DRI Development
Cc: Daniel Vetter, Tomi Valkeinen, Laurent Pinchart, Boris Brezillon,
Thomas Gleixner, Sam Ravnborg, Allison Randal
drm_encoder_slave is really not something anyone should be using,
the last real user is only nouveau.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Allison Randal <allison@lohutok.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
index f31068d74b18..d399c1077242 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -20,7 +20,6 @@
#include <drm/drm_atomic_helper.h>
#include <drm/drm_bridge.h>
#include <drm/drm_device.h>
-#include <drm/drm_encoder_slave.h>
#include <drm/drm_mipi_dsi.h>
#include <drm/drm_of.h>
#include <drm/drm_print.h>
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/hisilicon: Drop unused #include
2020-03-18 7:31 [PATCH] drm/hisilicon: Drop unused #include Daniel Vetter
@ 2020-03-18 8:06 ` Sam Ravnborg
2020-03-18 11:09 ` Laurent Pinchart
1 sibling, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2020-03-18 8:06 UTC (permalink / raw)
To: Daniel Vetter
Cc: DRI Development, Tomi Valkeinen, Laurent Pinchart,
Boris Brezillon, Thomas Gleixner, Allison Randal
On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote:
> drm_encoder_slave is really not something anyone should be using,
> the last real user is only nouveau.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Boris Brezillon <boris.brezillon@collabora.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Allison Randal <allison@lohutok.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
I did throw this after my build setup - no problems.
drm_encoder_slave is also used by i2c/ch7006 - but this
is a nouveau only driver so the explanation is also OK.
Sam
> ---
> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> index f31068d74b18..d399c1077242 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> @@ -20,7 +20,6 @@
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_bridge.h>
> #include <drm/drm_device.h>
> -#include <drm/drm_encoder_slave.h>
> #include <drm/drm_mipi_dsi.h>
> #include <drm/drm_of.h>
> #include <drm/drm_print.h>
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/hisilicon: Drop unused #include
2020-03-18 7:31 [PATCH] drm/hisilicon: Drop unused #include Daniel Vetter
2020-03-18 8:06 ` Sam Ravnborg
@ 2020-03-18 11:09 ` Laurent Pinchart
2020-03-18 13:30 ` Daniel Vetter
1 sibling, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2020-03-18 11:09 UTC (permalink / raw)
To: Daniel Vetter
Cc: DRI Development, Tomi Valkeinen, Boris Brezillon, Thomas Gleixner,
Sam Ravnborg, Allison Randal
Hi Daniel,
On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote:
> drm_encoder_slave is really not something anyone should be using,
> the last real user is only nouveau.
Fully agreed.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Is there any plan to convert nouveau to drm_bridge ?
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Boris Brezillon <boris.brezillon@collabora.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Allison Randal <allison@lohutok.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> index f31068d74b18..d399c1077242 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> @@ -20,7 +20,6 @@
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_bridge.h>
> #include <drm/drm_device.h>
> -#include <drm/drm_encoder_slave.h>
> #include <drm/drm_mipi_dsi.h>
> #include <drm/drm_of.h>
> #include <drm/drm_print.h>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/hisilicon: Drop unused #include
2020-03-18 11:09 ` Laurent Pinchart
@ 2020-03-18 13:30 ` Daniel Vetter
2020-03-18 13:39 ` Laurent Pinchart
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2020-03-18 13:30 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Daniel Vetter, DRI Development, Tomi Valkeinen, Boris Brezillon,
Thomas Gleixner, Sam Ravnborg, Allison Randal
On Wed, Mar 18, 2020 at 01:09:37PM +0200, Laurent Pinchart wrote:
> Hi Daniel,
>
> On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote:
> > drm_encoder_slave is really not something anyone should be using,
> > the last real user is only nouveau.
>
> Fully agreed.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Is there any plan to convert nouveau to drm_bridge ?
Apparently the only user in nouveau is for nv17 cards - after that the tv
encoder is integrated. This is so old and cards rare (quick irc chat among
the usual suspects suggested there might be none available anymore) that a
quick rm might be the better solution than trying to convert this over to
drm_bridge :-)
We should definitely look into pushing the drm_encoder_slave into
drm/nouveau, and maybe delete drm/i2c. The other two things in there kinda
don't belong - one isn't even a drm driver!
Cheers, Daniel
>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Boris Brezillon <boris.brezillon@collabora.com>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Cc: Allison Randal <allison@lohutok.net>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > index f31068d74b18..d399c1077242 100644
> > --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > @@ -20,7 +20,6 @@
> > #include <drm/drm_atomic_helper.h>
> > #include <drm/drm_bridge.h>
> > #include <drm/drm_device.h>
> > -#include <drm/drm_encoder_slave.h>
> > #include <drm/drm_mipi_dsi.h>
> > #include <drm/drm_of.h>
> > #include <drm/drm_print.h>
>
> --
> Regards,
>
> Laurent Pinchart
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/hisilicon: Drop unused #include
2020-03-18 13:30 ` Daniel Vetter
@ 2020-03-18 13:39 ` Laurent Pinchart
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2020-03-18 13:39 UTC (permalink / raw)
To: Daniel Vetter
Cc: Daniel Vetter, DRI Development, Tomi Valkeinen, Boris Brezillon,
Thomas Gleixner, Sam Ravnborg, Allison Randal
On Wed, Mar 18, 2020 at 02:30:24PM +0100, Daniel Vetter wrote:
> On Wed, Mar 18, 2020 at 01:09:37PM +0200, Laurent Pinchart wrote:
> > Hi Daniel,
> >
> > On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote:
> > > drm_encoder_slave is really not something anyone should be using,
> > > the last real user is only nouveau.
> >
> > Fully agreed.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Is there any plan to convert nouveau to drm_bridge ?
>
> Apparently the only user in nouveau is for nv17 cards - after that the tv
> encoder is integrated. This is so old and cards rare (quick irc chat among
> the usual suspects suggested there might be none available anymore) that a
> quick rm might be the better solution than trying to convert this over to
> drm_bridge :-)
>
> We should definitely look into pushing the drm_encoder_slave into
> drm/nouveau, and maybe delete drm/i2c. The other two things in there kinda
> don't belong - one isn't even a drm driver!
I was going to mention that :-) Pushing the last slave encoder driver
into its only user would be a good way to ensure nobody will take the
slave encoder path ever again.
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Cc: Boris Brezillon <boris.brezillon@collabora.com>
> > > Cc: Sam Ravnborg <sam@ravnborg.org>
> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > Cc: Allison Randal <allison@lohutok.net>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > > index f31068d74b18..d399c1077242 100644
> > > --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > > +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > > @@ -20,7 +20,6 @@
> > > #include <drm/drm_atomic_helper.h>
> > > #include <drm/drm_bridge.h>
> > > #include <drm/drm_device.h>
> > > -#include <drm/drm_encoder_slave.h>
> > > #include <drm/drm_mipi_dsi.h>
> > > #include <drm/drm_of.h>
> > > #include <drm/drm_print.h>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-18 13:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-18 7:31 [PATCH] drm/hisilicon: Drop unused #include Daniel Vetter
2020-03-18 8:06 ` Sam Ravnborg
2020-03-18 11:09 ` Laurent Pinchart
2020-03-18 13:30 ` Daniel Vetter
2020-03-18 13:39 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.