Re: [PATCH 1/2] staging: iio: adc: ad7192: Reformat lines crossing 80 columns

[DEEPAK VARMA <mh12gx2825@gmail.com>]

On Wed, Mar 18, 2020 at 07:00:04AM +0100, Greg KH wrote:
> On Wed, Mar 18, 2020 at 09:56:59AM +0530, Deepak R Varma wrote:
> > Macro arguments are computed at the time of macro invocation. This makes
> > the lines cross 80 column width. Add variables to perform the
> > calculations before hand and use these new variable in the macro calls
> > instead.
> > 
> > Also re-indent enum members to address checkpatch warning / check messages.
> 
> When you say "also" in a changelog description, that's a huge hint the
> patch needs to be broken up.
> 
> And that is what needs to happen here.
> 
> > 
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> > ---
> >  drivers/staging/iio/adc/ad7192.c | 15 ++++++++-------
> >  1 file changed, 8 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> > index bf3e2a9cc07f..0265f6607d75 100644
> > --- a/drivers/staging/iio/adc/ad7192.c
> > +++ b/drivers/staging/iio/adc/ad7192.c
> > @@ -156,8 +156,8 @@
> >   */
> >  
> >  enum {
> > -   AD7192_SYSCALIB_ZERO_SCALE,
> > -   AD7192_SYSCALIB_FULL_SCALE,
> > +	AD7192_SYSCALIB_ZERO_SCALE,
> > +	AD7192_SYSCALIB_FULL_SCALE,
> 
> Because this has nothing to do with the subject, please make it a
> separate patch.
> 

Okay. Got your point. I was thinking since this is a clean up patch I can include both
the changes for the same file in a single patch. No problem; I will
correct and send in a v2.

Thank you,
Deepak.


> thanks,
> 
> greg k-h