Re: [PATCH 2/2] staging: iio: adc: ad7280a: Add spaces around operators

[DEEPAK VARMA <mh12gx2825@gmail.com>]

On Wed, Mar 18, 2020 at 04:19:24PM +0100, Greg KH wrote:
> On Wed, Mar 18, 2020 at 04:12:28PM +0100, Lars-Peter Clausen wrote:
> > On 3/18/20 7:00 AM, Greg KH wrote:
> > > On Wed, Mar 18, 2020 at 09:58:13AM +0530, Deepak R Varma wrote:
> > > > Add spaces around operator symbols to improve readability. Warning
> > > > flagged by checkpatch script.
> > > > 
> > > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
> > > > ---
> > > >   drivers/staging/iio/adc/ad7280a.c | 4 ++--
> > > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> > > > index 19a5f244dcae..34ca0d09db85 100644
> > > > --- a/drivers/staging/iio/adc/ad7280a.c
> > > > +++ b/drivers/staging/iio/adc/ad7280a.c
> > > > @@ -825,14 +825,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
> > > >   }
> > > >   static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> > > > -			     in_voltage-voltage_thresh_low_value,
> > > > +			     in_voltage - voltage_thresh_low_value,
> > > >   			     0644,
> > > >   			     ad7280_read_channel_config,
> > > >   			     ad7280_write_channel_config,
> > > >   			     AD7280A_CELL_UNDERVOLTAGE);
> > > >   static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> > > > -			     in_voltage-voltage_thresh_high_value,
> > > > +			     in_voltage - voltage_thresh_high_value,
> > > >   			     0644,
> > > >   			     ad7280_read_channel_config,
> > > >   			     ad7280_write_channel_config,
> > > 
> > > Did you try building this code?
> > > 
> > > It catches everyone...
> > 
> > The problem is it builds. The token is stringyfied and
> > "in_voltage - voltage_thresh_high_value" is a valid string.
> 
> Ah, I thought it used to break the build when it happened.  Oh well,
> it's still a great "trick" to see if people understand C or not :)
> 
Yes, it did build. I am sorry but I am not following you fully. Can you
please let me know if the change I introduced is not good. You may
please direct me to a document where I can read more about it.

Thanks,
Deepak.
> thanks,
> 
> greg k-h