* [PATCH 1/1] nvme: release ida resources
@ 2020-03-18 15:27 Max Gurtovoy
2020-03-18 15:33 ` Christoph Hellwig
2020-03-18 19:18 ` Keith Busch
0 siblings, 2 replies; 3+ messages in thread
From: Max Gurtovoy @ 2020-03-18 15:27 UTC (permalink / raw)
To: linux-nvme, sagi, hch, kbusch; +Cc: shlomin, Max Gurtovoy
ida instances allocate some internal memory in addition to the base
'struct ida'. Use ida_destroy() to release that memory at module_exit().
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
---
drivers/nvme/host/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index a4d8c90..31bbf40 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -4299,6 +4299,7 @@ static void __exit nvme_core_exit(void)
destroy_workqueue(nvme_delete_wq);
destroy_workqueue(nvme_reset_wq);
destroy_workqueue(nvme_wq);
+ ida_destroy(&nvme_instance_ida);
}
MODULE_LICENSE("GPL");
--
1.8.3.1
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nvme: release ida resources
2020-03-18 15:27 [PATCH 1/1] nvme: release ida resources Max Gurtovoy
@ 2020-03-18 15:33 ` Christoph Hellwig
2020-03-18 19:18 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-03-18 15:33 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: kbusch, shlomin, sagi, linux-nvme, hch
On Wed, Mar 18, 2020 at 05:27:59PM +0200, Max Gurtovoy wrote:
> ida instances allocate some internal memory in addition to the base
> 'struct ida'. Use ida_destroy() to release that memory at module_exit().
>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
> ---
> drivers/nvme/host/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index a4d8c90..31bbf40 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -4299,6 +4299,7 @@ static void __exit nvme_core_exit(void)
> destroy_workqueue(nvme_delete_wq);
> destroy_workqueue(nvme_reset_wq);
> destroy_workqueue(nvme_wq);
> + ida_destroy(&nvme_instance_ida);
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nvme: release ida resources
2020-03-18 15:27 [PATCH 1/1] nvme: release ida resources Max Gurtovoy
2020-03-18 15:33 ` Christoph Hellwig
@ 2020-03-18 19:18 ` Keith Busch
1 sibling, 0 replies; 3+ messages in thread
From: Keith Busch @ 2020-03-18 19:18 UTC (permalink / raw)
To: Max Gurtovoy; +Cc: shlomin, sagi, linux-nvme, hch
On Wed, Mar 18, 2020 at 05:27:59PM +0200, Max Gurtovoy wrote:
> ida instances allocate some internal memory in addition to the base
> 'struct ida'. Use ida_destroy() to release that memory at module_exit().
>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
> ---
> drivers/nvme/host/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index a4d8c90..31bbf40 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -4299,6 +4299,7 @@ static void __exit nvme_core_exit(void)
> destroy_workqueue(nvme_delete_wq);
> destroy_workqueue(nvme_reset_wq);
> destroy_workqueue(nvme_wq);
> + ida_destroy(&nvme_instance_ida);
> }
>
> MODULE_LICENSE("GPL");
Thank you, applied to nvme-5.7.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-18 19:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-18 15:27 [PATCH 1/1] nvme: release ida resources Max Gurtovoy
2020-03-18 15:33 ` Christoph Hellwig
2020-03-18 19:18 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.