* [PATCH] Staging: qlge: Add a blank line after variable declaration.
@ 2020-03-18 20:03 Sam Muhammed
2020-03-18 20:23 ` [Outreachy kernel] " Julia Lawall
2020-03-18 20:24 ` Sam Muhammed
0 siblings, 2 replies; 4+ messages in thread
From: Sam Muhammed @ 2020-03-18 20:03 UTC (permalink / raw)
To: Manish Chopra, GR-Linux-NIC-Dev, Greg Kroah-Hartman,
outreachy-kernel
Cc: Sam Muhammed
Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
---
---
drivers/staging/qlge/qlge_dbg.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 737d6abd8076..1795533cbd3a 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf,
u32 offset, u32 count)
{
int i, status = 0;
+
for (i = 0; i < count; i++, buf++) {
status = ql_read_mpi_reg(qdev, offset + i, buf);
if (status)
@@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
{
int i;
u32 value;
+
for (i = 0; i < qdev->intr_count; i++) {
ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
value = ql_read32(qdev, INTR_EN);
@@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev)
{
int i;
u32 value;
+
i = ql_sem_spinlock(qdev, SEM_RT_IDX_MASK);
if (i)
return;
@@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)
void ql_dump_qdev(struct ql_adapter *qdev)
{
int i;
+
DUMP_QDEV_FIELD(qdev, "%lx", flags);
DUMP_QDEV_FIELD(qdev, "%p", vlgrp);
DUMP_QDEV_FIELD(qdev, "%p", pdev);
@@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)
void ql_dump_ricb(struct ricb *ricb)
{
int i;
+
pr_err("===================== Dumping ricb ===============\n");
pr_err("Dumping ricb stuff...\n");
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: qlge: Add a blank line after variable declaration.
2020-03-18 20:03 [PATCH] Staging: qlge: Add a blank line after variable declaration Sam Muhammed
@ 2020-03-18 20:23 ` Julia Lawall
2020-03-18 20:24 ` Sam Muhammed
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2020-03-18 20:23 UTC (permalink / raw)
To: Sam Muhammed
Cc: Manish Chopra, GR-Linux-NIC-Dev, Greg Kroah-Hartman,
outreachy-kernel
On Wed, 18 Mar 2020, Sam Muhammed wrote:
> Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
This is a revision of what you did before. So there should be v2 in the
subject line. And under the --- there should be a description of what you
did differently as compared to the previous version.
>
> Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
> ---
> ---
Only one --- is needed. Perhaps you added one and another one was added
automatically?
julia
> drivers/staging/qlge/qlge_dbg.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 737d6abd8076..1795533cbd3a 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf,
> u32 offset, u32 count)
> {
> int i, status = 0;
> +
> for (i = 0; i < count; i++, buf++) {
> status = ql_read_mpi_reg(qdev, offset + i, buf);
> if (status)
> @@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
> {
> int i;
> u32 value;
> +
> for (i = 0; i < qdev->intr_count; i++) {
> ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
> value = ql_read32(qdev, INTR_EN);
> @@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev)
> {
> int i;
> u32 value;
> +
> i = ql_sem_spinlock(qdev, SEM_RT_IDX_MASK);
> if (i)
> return;
> @@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)
> void ql_dump_qdev(struct ql_adapter *qdev)
> {
> int i;
> +
> DUMP_QDEV_FIELD(qdev, "%lx", flags);
> DUMP_QDEV_FIELD(qdev, "%p", vlgrp);
> DUMP_QDEV_FIELD(qdev, "%p", pdev);
> @@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)
> void ql_dump_ricb(struct ricb *ricb)
> {
> int i;
> +
> pr_err("===================== Dumping ricb ===============\n");
> pr_err("Dumping ricb stuff...\n");
>
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200318200352.3497-1-jane.pnx9%40gmail.com.
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: qlge: Add a blank line after variable declaration.
2020-03-18 20:03 [PATCH] Staging: qlge: Add a blank line after variable declaration Sam Muhammed
2020-03-18 20:23 ` [Outreachy kernel] " Julia Lawall
@ 2020-03-18 20:24 ` Sam Muhammed
2020-03-19 8:35 ` Greg Kroah-Hartman
1 sibling, 1 reply; 4+ messages in thread
From: Sam Muhammed @ 2020-03-18 20:24 UTC (permalink / raw)
To: Manish Chopra, GR-Linux-NIC-Dev, Greg Kroah-Hartman,
outreachy-kernel
On Wed, 2020-03-18 at 16:03 -0400, Sam Muhammed wrote:
> Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
>
> Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
> ---
> ---
duplicate :(, should i resend or revision?
> drivers/staging/qlge/qlge_dbg.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
> index 737d6abd8076..1795533cbd3a 100644
> --- a/drivers/staging/qlge/qlge_dbg.c
> +++ b/drivers/staging/qlge/qlge_dbg.c
> @@ -497,6 +497,7 @@ static int ql_get_mpi_regs(struct ql_adapter *qdev, u32 *buf,
> u32 offset, u32 count)
> {
> int i, status = 0;
> +
> for (i = 0; i < count; i++, buf++) {
> status = ql_read_mpi_reg(qdev, offset + i, buf);
> if (status)
> @@ -1330,6 +1331,7 @@ static void ql_dump_intr_states(struct ql_adapter *qdev)
> {
> int i;
> u32 value;
> +
> for (i = 0; i < qdev->intr_count; i++) {
> ql_write32(qdev, INTR_EN, qdev->intr_context[i].intr_read_mask);
> value = ql_read32(qdev, INTR_EN);
> @@ -1415,6 +1417,7 @@ void ql_dump_routing_entries(struct ql_adapter *qdev)
> {
> int i;
> u32 value;
> +
> i = ql_sem_spinlock(qdev, SEM_RT_IDX_MASK);
> if (i)
> return;
> @@ -1565,6 +1568,7 @@ void ql_dump_stat(struct ql_adapter *qdev)
> void ql_dump_qdev(struct ql_adapter *qdev)
> {
> int i;
> +
> DUMP_QDEV_FIELD(qdev, "%lx", flags);
> DUMP_QDEV_FIELD(qdev, "%p", vlgrp);
> DUMP_QDEV_FIELD(qdev, "%p", pdev);
> @@ -1650,6 +1654,7 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)
> void ql_dump_ricb(struct ricb *ricb)
> {
> int i;
> +
> pr_err("===================== Dumping ricb ===============\n");
> pr_err("Dumping ricb stuff...\n");
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: qlge: Add a blank line after variable declaration.
2020-03-18 20:24 ` Sam Muhammed
@ 2020-03-19 8:35 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-19 8:35 UTC (permalink / raw)
To: Sam Muhammed; +Cc: Manish Chopra, GR-Linux-NIC-Dev, outreachy-kernel
On Wed, Mar 18, 2020 at 04:24:32PM -0400, Sam Muhammed wrote:
> On Wed, 2020-03-18 at 16:03 -0400, Sam Muhammed wrote:
> > Cleanup checkpatch.pl WARNINGS: Missing a blank line after declarations.
> >
> > Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com>
> > ---
> > ---
>
> duplicate :(, should i resend or revision?
I need a v2 of this please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-19 8:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-18 20:03 [PATCH] Staging: qlge: Add a blank line after variable declaration Sam Muhammed
2020-03-18 20:23 ` [Outreachy kernel] " Julia Lawall
2020-03-18 20:24 ` Sam Muhammed
2020-03-19 8:35 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.